Bug 549733 - [GTK] [API] Query the current system setting for dark mode
Summary: [GTK] [API] Query the current system setting for dark mode
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.13   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.13 M3   Edit
Assignee: Eric Williams CLA
QA Contact:
URL:
Whiteboard: RHT
Keywords: triaged
Depends on:
Blocks: 546859 547038
  Show dependency tree
 
Reported: 2019-08-01 15:15 EDT by Eric Williams CLA
Modified: 2020-05-08 04:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2019-08-01 15:15:24 EDT 
Bug 546859 captures the discussion for the complete set of APIs to get and set the Theme for SWT applications. 

This bug tracks the implementation of the API on GTK.
Comment 1 Eclipse Genie CLA 2019-08-01 15:26:39 EDT 
New Gerrit change created: https://git.eclipse.org/r/146931
Comment 2 Lakshmi P Shanmugam CLA 2019-08-07 05:58:17 EDT 
@Eric,
Windows & Mac changes are in. Can you push this change?
Comment 3 Eric Williams CLA 2019-08-07 08:03:18 EDT 
Yes, will do so today.
Comment 5 Eric Williams CLA 2019-08-07 11:15:14 EDT 
(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/146931 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=fa11ff36da52a61e9e7769e9664ed86a5dd68240

In master now.
Comment 6 Eclipse Genie CLA 2019-08-07 15:36:30 EDT 
New Gerrit change created: https://git.eclipse.org/r/147229
Comment 7 Eric Williams CLA 2019-08-07 15:57:36 EDT 
(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/147229

Reopening due to an oversight in the original patch. The gerrit above has an update to the fix.
Comment 9 Eric Williams CLA 2019-08-08 13:52:37 EDT 
(In reply to Eclipse Genie from comment #8)
> Gerrit change https://git.eclipse.org/r/147229 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=e810121a9c756a3e2600f7eb79b5ee64527235ea

Updated fix in master now.
Comment 10 Eric Williams CLA 2019-08-20 10:20:22 EDT 
Verified in I20190820-0600.
Comment 11 Simeon Andreev CLA 2020-05-08 04:38:40 EDT 
There is something wrong with the native code added here, see bug 562951.