Bug 547038 - [Mac][Linux] Start eclipse in dark theme based on system theme
Summary: [Mac][Linux] Start eclipse in dark theme based on system theme
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.12   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.13 M3   Edit
Assignee: Lakshmi P Shanmugam CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on: 549451 549713 549733
Blocks:
  Show dependency tree
 
Reported: 2019-05-07 06:26 EDT by Lakshmi P Shanmugam CLA
Modified: 2022-02-15 09:35 EST (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lakshmi P Shanmugam CLA 2019-05-07 06:26:22 EDT 
If Mac system theme is dark, start Eclipse automatically in dark theme if user has not set/changed the theme explicitly.

This requires an SWT API to check if the system theme is Dark (Bug 546859).
Comment 1 Eclipse Genie CLA 2019-05-08 06:22:38 EDT 
New Gerrit change created: https://git.eclipse.org/r/141764
Comment 2 Dani Megert CLA 2019-05-30 11:10:33 EDT 
Lakshmi, what's the status here? 4.13?
Comment 3 Lakshmi P Shanmugam CLA 2019-05-31 00:11:15 EDT 
(In reply to Dani Megert from comment #2)
> Lakshmi, what's the status here? 4.13?

It requires SWT APIs tracked by Bug 546859. Targetting 4.13.
Comment 4 Lakshmi P Shanmugam CLA 2019-08-08 06:04:19 EDT 
The SWT API isSystemThemeDark() is available on all platforms now, should this feature be enabled for all platforms?
Comment 5 Lakshmi P Shanmugam CLA 2019-08-08 06:05:28 EDT 
(In reply to Lakshmi Shanmugam from comment #4)
> The SWT API isSystemThemeDark() is available on all platforms now, should
> this feature be enabled for all platforms?

It's isSystemDarkTheme().
Comment 6 Lakshmi P Shanmugam CLA 2019-08-09 03:21:03 EDT 
The change will work on Mac and Linux.
Comment 7 Lars Vogel CLA 2019-08-09 03:35:55 EDT 
(In reply to Lakshmi Shanmugam from comment #6)
> The change will work on Mac and Linux.

Why not on Windows? Do we have a bug for Windows?
Comment 8 Lakshmi P Shanmugam CLA 2019-08-09 06:32:36 EDT 
(In reply to Lars Vogel from comment #7)
> (In reply to Lakshmi Shanmugam from comment #6)
> > The change will work on Mac and Linux.
> 
> Why not on Windows? Do we have a bug for Windows?

The SWT API isSystemDarkTheme() works on all platforms. But, Windows itself doesn't support dark theme for win32 applications yet. So, Eclipse will not have any native dark theming, only the CSS theming.
This is different from Mac & GTK, where Eclipse Dark theme also enables the native dark theme for the app. So, Eclipse will look like the other native apps.

I'm not sure if we should enable this on Windows as the native dark look is not complete, that's why I posted the question in comment#4.
Comment 10 Eclipse Genie CLA 2019-08-12 04:10:37 EDT 
New Gerrit change created: https://git.eclipse.org/r/147531
Comment 12 Lakshmi P Shanmugam CLA 2019-08-21 03:30:38 EDT 
Verified with I20190819-2355.