Community
Participate
Working Groups
Created attachment 277709 [details] Java example and information not read Currently developing a refactoring API with the LTK plugins, we notice that some information such as "changed to be performed" and the tree can't be read. Test Tool Type: JAWS 2018 ===== DEFECT DESCRIPTION ===== The information in red rectangles in pics (see attachment) can't be read out =====STEPS TO REPRODUCE ===== With a Java example: 1.Open JAWS 2.Right click on a Java class 3. Refactor > Extract interface 4. Preview ===== EXPECTED RESULT ===== The information should be read out
Problem reproducible at my end with Jaws17 on Win7 as well, am investigating the reason.
As per the current behavior, JAWS(of even Microsoft's Narrator) reads out the text of the label which are immediately added before any specified Text field which is in focus. In this case the Label's text which we expect to read out: - is part of a Toolbar(added before the associated Text filed's Label) - Also this label is non-focus able. So, we can go about with two possible approaches to fix this: 1. Either we could establish relationship between the two widgets. 2. Or we could make the mentioned label as focus, so tab stops by. I am trying out what works best.
We need to take clues from below SWT snippet to get to a solution for this bug: SWT snippet, which tells a screen reader about updates to a non-focused descriptive area: https://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet79.java Moving out of 4.12
In my plan for 4.13, I plan to work on this issue after bug 544868.
New Gerrit change created: https://git.eclipse.org/r/147901
(In reply to Eclipse Genie from comment #5) > New Gerrit change created: https://git.eclipse.org/r/147901 Reached a partial fix, will investigate further on this in 4.14
(In reply to Niraj Modi from comment #6) > (In reply to Eclipse Genie from comment #5) > > New Gerrit change created: https://git.eclipse.org/r/147901 Posted an updated gerrit on Eclipse compare module, which improves on above patch. > Reached a partial fix, will investigate further on this in 4.14 We also need a change in JDT UI component to get above patch working: Below setText(String text) method conditionally avoids setting the 'text' argument, without notifying the corresponding viewer: ------------------------------------------------------------------------- org.eclipse.ltk.internal.ui.refactoring.TextEditChangePreviewViewer.java public void setText(String text) { if (fLabel != null) { super.setText(fLabel); } else { super.setText(text); } I have a working changes on JDT UI, will share a gerrit shortly.
New Gerrit change created: https://git.eclipse.org/r/152437
(In reply to Nadine LE NOUVEAU from comment #0) > Created attachment 277709 [details] > Java example and information not read Referring to above screen-shot, current pair of gerrit patches will read out the class name in the Refactor > Extract interface workflow.
(In reply to Eclipse Genie from comment #8) > New Gerrit change created: https://git.eclipse.org/r/152437 With revised JDT UI patch, both of the texts(referred in attachment 277709 [details]) are now covered, targeting this bug for 4.14 M3
Gerrit change https://git.eclipse.org/r/152437 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=f19623c48b13c11a9a25116d136d8cacb5a3f003
Gerrit change https://git.eclipse.org/r/147901 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=1db5d00c72dd69ac6161cf04145cc7918842c5c0
(In reply to Eclipse Genie from comment #11) > Gerrit change https://git.eclipse.org/r/152437 was merged to [master]. > Commit: > http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/ > ?id=f19623c48b13c11a9a25116d136d8cacb5a3f003 (In reply to Eclipse Genie from comment #12) > Gerrit change https://git.eclipse.org/r/147901 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/ > ?id=1db5d00c72dd69ac6161cf04145cc7918842c5c0 Verified the fix in Eclipse Build id: I20191112-1800, resolving now.
Reopening for back-port the fix to 4.11+, 4.8+ and R4_6_maintenance branches.
New Gerrit change created: https://git.eclipse.org/r/153162
New Gerrit change created: https://git.eclipse.org/r/153164
New Gerrit change created: https://git.eclipse.org/r/153165
New Gerrit change created: https://git.eclipse.org/r/153166
New Gerrit change created: https://git.eclipse.org/r/153167
New Gerrit change created: https://git.eclipse.org/r/153168
Gerrit change https://git.eclipse.org/r/153166 was merged to [R4_8_maintenance]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=d9e301700c4e749873cb8172fb088348af8ce672
Gerrit change https://git.eclipse.org/r/153164 was merged to [R4_11_maintenance]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=baf40310a51d179b7f42d83b69d4fc3ec45203cd
Gerrit change https://git.eclipse.org/r/153162 was merged to [R4_11_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=480d50435a33e11757644f6fcab04aa0d5897920
Gerrit change https://git.eclipse.org/r/153165 was merged to [R4_8_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=4e86d3bf51d96f36a8f9f68f5179800676d7408e
Gerrit change https://git.eclipse.org/r/153168 was merged to [R4_6_maintenance]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=1fbe14d8383c1aaab305bddd517120ec32393c77
Gerrit change https://git.eclipse.org/r/153167 was merged to [R4_6_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=e5eec30c484df196d8c4fae5149dda2d1735590e
(In reply to Niraj Modi from comment #14) > Reopening for back-port the fix to 4.11+, 4.8+ and R4_6_maintenance branches. Both set of patches(eclipse.jdt.ui.git and eclipse.platform.team.git) are back-ported to above set of releases, resolving now.
