Community
Participate
Working Groups
Test Tool for accessibility: JAWS 2019 ===== DEFECT DESCRIPTION ===== When swapping left and right view, Column name Local history: xxx is read as Local: xxx =====STEPS TO REPRODUCE ===== 1.Open JAWS 2. Open a file 3. Right-click in the editor 4. Select Compare with ->Local 4. Click the icon of swap left and right view 6.Press tab key to focus the left column ===== EXPECTED RESULT ===== The column should be read out correctly
This bug is also reproducible at my end on Win7 using Jaws17, will take a look at the Compare view's code to narrow down on the problem.
Possible root cause: It looks like some initial labels String values get cached in the accessibility initialization which needs to be refreshed after swapping the left and right views.
Moving out of 4.12, for now.
This problem is caused by enhancement bug 213780. What I notice the way above enhancement handles the Left and Right label value swap, doesn't work well with Accessibility tools. Sharing the implementation trick that was used in bug 213780, which is causing JAW tool to wrongly read the values. public String getLeftLabel(Object input) { return delegate.getRightLabel(input); } I am investigating a fix for this. Link to the class commit: https://git.eclipse.org/c/platform/eclipse.platform.team.git/diff/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/MirroredMergeViewerContentProvider.java?id=d12c403fa89f023f6e29425649bab0780712002c
Root cause of this bug: Bug 213780 introduced the concept of mirroring of the Compare-configuration. So, we need to use the same mirroring concept when adding the Accessibility listeners for the Left and Right label headers. I have a working solution for this, will share a gerrit shortly.
New Gerrit change created: https://git.eclipse.org/r/146544
Gerrit change https://git.eclipse.org/r/146544 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=7cb37653f01abad8f14ef73d2c31cc004b3d674e
(In reply to Eclipse Genie from comment #7) > Gerrit change https://git.eclipse.org/r/146544 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/ > ?id=7cb37653f01abad8f14ef73d2c31cc004b3d674e Resolving now.
I have verified the fix using JAWS17.0 on Win7 using latest Eclipse build: Build id: I20190724-1800 Marking verified.
Reopening for back-port to 4.11+
New Gerrit change created: https://git.eclipse.org/r/148173
Gerrit change https://git.eclipse.org/r/148173 was merged to [R4_11_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=2b2f786238a8e4725cf4ebcbf5a74303bc08b594
Also back-porting to R4_6_maintenance, shortly.
New Gerrit change created: https://git.eclipse.org/r/148175
Gerrit change https://git.eclipse.org/r/148175 was merged to [R4_6_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=f2762260f42ebb4b57774dcdd8a883c1346b5172
Fix back-ported to 'R4_11_maintenance' and 'R4_6_maintenance' branches, resolving.
New Gerrit change created: https://git.eclipse.org/r/148185
New Gerrit change created: https://git.eclipse.org/r/148226
Gerrit change https://git.eclipse.org/r/148185 was merged to [R4_11_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=38c45ad0092b3d188cc4b1995f200415a93efb5c
New Gerrit change created: https://git.eclipse.org/r/148335
Gerrit change https://git.eclipse.org/r/148226 was merged to [R4_6_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=81250c5b05f940f4c79d3cd2354321c831929341
Also back-porting to previous LTS branch 'R4_8_maintenance' branch. Will share a gerrit shortly.
New Gerrit change created: https://git.eclipse.org/r/151511
Gerrit change https://git.eclipse.org/r/151511 was merged to [R4_8_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=61351d0e8e218ec444e9f2c07a7b38401af19258
