Community
Participate
Working Groups
Created attachment 275205 [details] Screenshot With photon, no error markers are shown at project level in the "project explorer" with "Hierarchical" project presentation. Steps to reproduce: - Create a fresh workspace - Switch to project explorer, switch view to "hierarchical" - Create a java project - Create a class - type something in the class that produces an error, save the class Result: - error markers (little red cross at the folder icon) are shown up to the "src" folder but not at project level Expected result: - the project should be marked as "error"
I can reproduce the issue on MacOs with Eclipse SDK Version: 4.9 Build id: I20180731-1305 OS: Mac OS X, v.10.13.3, x86_64 / cocoa Java version: 1.8.0_144
@Mickael in c/c: IIRC, you contributed to the project explorer development. Can you recall if there is a specific reason for not showing an error marker on the top project when the project presentation is hierarchical?
I don't recall a specific reason for not showing it. But one important thing to keep in mind when doing this development is that we need to have performant code, and there is a risk the calling `resource.findMarkers(..., IResource.DEPTH_INFINITE)` on all visible folders can be a very expensive approach so the naive implementation is probably not suitable (and I didn't have time for more consideration back then).
But this one is most likely a bug as the exepctation is that the hierarchical view would at least show the marker on the containing project. Showing it on the whole upper hierarchy is more an enhancement, already tracked in bug 478117
Mickael, I absolutely agree that "showing at project level" is an expectation and it's lack is a bug, while "showing at complete hierarchie" can be thread as a feature request (although I wonder why this would need to scan with infinite depth - if all components report markers from it's contents, each should need to scan it's directy children only). I'm pretty sure that it worked on oxygene. The first time I saw it was shortly after migrating a workspace and I wondered why a (collapsed) project did not run but did not show the error mark. Regards, Michael.
I can reproduce it, and I agree with you it used to work in Oxygen. I fail at understanding the actual reason why this changed, but I'm working on a patch that fixes it.
New Gerrit change created: https://git.eclipse.org/r/126908
Gerrit change https://git.eclipse.org/r/126908 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=50a2bc13401133978e3b878a6b36dc1b5a22dac2
A patch fixing it was merged. Please try a build from http://download.eclipse.org/eclipse/downloads/drops4/ later today (so it should contain the fix) and report whether it fixes it for you too.
Created attachment 275246 [details] Verified. Note the icon is different w.r.t. other markers on MacOs.
(In reply to Patrik Suzzi from comment #10) > Verified. Note the icon is different w.r.t. other markers on MacOs. Interesting. I think it could be a bug. Can you please open a new ticket?
Added bug 537686
*** Bug 538965 has been marked as a duplicate of this bug. ***
