Community
Participate
Working Groups
There are two failures in SWT related to active shell in Mac OS X. The test machine is changed from Mac OSX 10.11 to 10.13 on 27th June
New Gerrit change created: https://git.eclipse.org/r/125329
Gerrit change https://git.eclipse.org/r/125329 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e3d85de8d7b6cdbe683cdf4224e66299de6c3be0
The tests pass locally now but they are still failing on the test machine. (http://download.eclipse.org/eclipse/downloads/drops4/I20180704-0805/testresults/html/org.eclipse.swt.tests_ep49I-unit-mac64_macosx.cocoa.x86_64_8.0.html) I'll increase the timeouts and try again.
New Gerrit change created: https://git.eclipse.org/r/125574
Gerrit change https://git.eclipse.org/r/125574 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2b780e84b5e18379f86348ebb0e087e666a80b3f
Increasing the timeouts didn't fix the problem, the tests are still failing on the Test machine.
Lakshmi, can it be that we started to have test failures on Mac *and* Windows at same time?
(In reply to Andrey Loskutov from comment #7) > Lakshmi, can it be that we started to have test failures on Mac *and* > Windows at same time? Andrey, I don't see any Windows failures for SWT. Which failures are you referring to?
(In reply to Lakshmi Shanmugam from comment #8) > (In reply to Andrey Loskutov from comment #7) > > Lakshmi, can it be that we started to have test failures on Mac *and* > > Windows at same time? > > Andrey, I don't see any Windows failures for SWT. Which failures are you > referring to? Failures on Windows, but I've found they are unrelated, see bug 453954 comment 6 and comment 7. Looking on the Mac specific tests failures, I believe they are all due the not active shell: "Application does not have an active window". We had this in the past if some "Mac update" window appears during the test. Can we check that?
(In reply to Andrey Loskutov from comment #9) > (In reply to Lakshmi Shanmugam from comment #8) > > (In reply to Andrey Loskutov from comment #7) > > > Lakshmi, can it be that we started to have test failures on Mac *and* > > > Windows at same time? > > > > Andrey, I don't see any Windows failures for SWT. Which failures are you > > referring to? > > Failures on Windows, but I've found they are unrelated, see bug 453954 > comment 6 and comment 7. > > Looking on the Mac specific tests failures, I believe they are all due the > not active shell: "Application does not have an active window". We had this > in the past if some "Mac update" window appears during the test. Can we > check that? I verified that there is no dialog open on the machine.
New Gerrit change created: https://git.eclipse.org/r/127475
Gerrit change https://git.eclipse.org/r/127475 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=1bed5097125869173fe23b4f4ba7becb2bd06208
I added code to sleep and capture screenshots in the failing tests. The screenshots [1] & [2] show that the shells are not active, but there is no other active shell. So, I'm not sure why. The screenshots captured locally show the shells be tested are active. [1] http://download.eclipse.org/eclipse/downloads/drops4/I20180816-2000/testresults/ep49I-unit-mac64_macosx.cocoa.x86_64_8.0/org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Display.test_setActive2.png [2] http://download.eclipse.org/eclipse/downloads/drops4/I20180816-2000/testresults/ep49I-unit-mac64_macosx.cocoa.x86_64_8.0/org.eclipse.swt.tests.junit.Test_org_eclipse_swt_widgets_Shell.test_setActive1.png The screenshots are captured by a AWT application. Will remove the code and try again to ensure that it's not interfering with the shell activation.
New Gerrit change created: https://git.eclipse.org/r/127576
Gerrit change https://git.eclipse.org/r/127576 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4d3727a152ea3b005e4d886560a6a84404828007
New Gerrit change created: https://git.eclipse.org/r/132162
Gerrit change https://git.eclipse.org/r/132162 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c7c5b3cf1f6cd1c15bb48f636ae3cf05c6ed047c
(In reply to Eclipse Genie from comment #17) > Gerrit change https://git.eclipse.org/r/132162 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=c7c5b3cf1f6cd1c15bb48f636ae3cf05c6ed047c Reordering fixes the local test failure in Shell.setActive() failure on 10.14.
New Gerrit change created: https://git.eclipse.org/r/153782
Gerrit change https://git.eclipse.org/r/153782 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e6caf796ec280c52a246b71ace1c685ea0b7c45e
(In reply to Eclipse Genie from comment #20) > Gerrit change https://git.eclipse.org/r/153782 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=e6caf796ec280c52a246b71ace1c685ea0b7c45e The commit disables the 2 failing tests on Mac.
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
