Community
Participate
Working Groups
Using Eclipse 3.5-I20141202-0800 1. Open an existing .target file. If on Windows, the files needs to have Unix line delimiters (\n). On Linux/Mac, the file needs to have Windows delimiters (\r\n). 2. Modify the file by adding a feature from a p2 repository, for example. 3. Save the file. The file now has the system default line delimiters instead of using the existing delimiter from the original file.
Patch: https://git.eclipse.org/r/#/c/37221/
Ran into this again today but this time by pressing the "Reload" button which edits the target file to bump the sequence number. It's not the most urgent fix but perhaps for SR1? :)
New Gerrit change created: https://git.eclipse.org/r/119426
Gerrit change https://git.eclipse.org/r/119426 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=2d42bf841e39599cd26198f6f486191caf22d848
Gerrit change https://git.eclipse.org/r/125005 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=a0d0479ac5a8070d173ea0c1081d4443f73452af
(In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/119426 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=2d42bf841e39599cd26198f6f486191caf22d848 This caused regression on Windows immediately (see http://download.eclipse.org/eclipse/downloads/drops4/I20180625-1545/testresults/html/org.eclipse.pde.ui.tests_ep49I-unit-win32_win32.win32.x86_8.0.html) and on Linux since we have milliseconds in file timestamps. See bug 537037. BTW, it looks like LocalTargetDefinitionTests aren't executed on Gerrit? Vikas, where is configured which tests run on Gerrit?
(In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/119426 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=2d42bf841e39599cd26198f6f486191caf22d848 Also this caused 5 new failures in pde.genericeditor.extension.tests on Windows, because the "golden samples" are saved with Linux line delimiters, and test compares Linux files with output on Windows. See for example http://download.eclipse.org/eclipse/downloads/drops4/I20180713-2000/testresults/html/org.eclipse.pde.genericeditor.extension.tests_ep49I-unit-win32_win32.win32.x86_8.0.html testMultipleContainersWithSameRepoPersist org.junit.ComparisonFailure: expected:<...sion="3.8"?><target>[ <locations> <location includeAllPlatforms="true" includeConfigurePhase="false" includeMode="slicer" includeSource="false" type="InstallableUnit"> <unit id="unit1" version="1.0.0"/> <unit id="unit2" version="2.0.0"/> <repository location="TESTURI"/> </location> <location includeAllPlatforms="true" includeConfigurePhase="false" includeMode="slicer" includeSource="false" type="InstallableUnit"> <repository location="TESTURI"/> </location> </locations>] </target>> but was:<...sion="3.8"?><target>[ <locations> <location includeAllPlatforms="true" includeConfigurePhase="false" includeMode="slicer" includeSource="false" type="InstallableUnit"> <unit id="unit1" version="1.0.0"/> <unit id="unit2" version="2.0.0"/> <repository location="TESTURI"/> </location> <location includeAllPlatforms="true" includeConfigurePhase="false" includeMode="slicer" includeSource="false" type="InstallableUnit"> <repository location="TESTURI"/> </location> </locations> ] </target>> at org.eclipse.pde.genericeditor.extension.tests.Bug531602FormattingTests.confirmMatch(Bug531602FormattingTests.java:129) at org.eclipse.pde.genericeditor.extension.tests.Bug531602FormattingTests.testMultipleContainersWithSameRepoPersist(Bug531602FormattingTests.java:99) @Lucas, please fix those tests.
>>Vikas, where is configured which tests run on Gerrit? Only AllPDEMinimalTests runs on gerrit. Also API tools tests dont run. So around 437 out of 530 tests run on gerrit.
(In reply to Vikas Chandra from comment #8) > >>Vikas, where is configured which tests run on Gerrit? > > Only AllPDEMinimalTests runs on gerrit. Also API tools tests dont run. > > So around 437 out of 530 tests run on gerrit. I see, but *where* is specified, which tests should run on Gerrit / main build and which not? Can we enable missing tests, or they are known to fail on Gerrit?
See bug 488036 >> Can we enable missing tests, or they are known to fail on Gerrit? You can give it another try to enable all tests.
New Gerrit change created: https://git.eclipse.org/r/126112
Gerrit change https://git.eclipse.org/r/126112 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=185a5db35c54b46dd7ce644cc3357811d9e9161a
(In reply to Vikas Chandra from comment #10) > See bug 488036 > > >> Can we enable missing tests, or they are known to fail on Gerrit? > > You can give it another try to enable all tests. Thanks Vikas, I've created bug 537108 to follow up here.
New Gerrit change created: https://git.eclipse.org/r/126295
Gerrit change https://git.eclipse.org/r/126295 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=da0e669267c6805a8caecbed8dec7ed093f264e5
(In reply to Eclipse Genie from comment #15) > Gerrit change https://git.eclipse.org/r/126295 was merged to [master]. > Commit: > http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/ > ?id=da0e669267c6805a8caecbed8dec7ed093f264e5 THis shows finally no fails in pde.genericeditor.extension.tests on Windows, see http://download.eclipse.org/eclipse/downloads/drops4/I20180718-2000/testResults.php
I'm coming from a regression caused by this patch, see bug 541678, and wonder what is the state of this bug? It is still shown as open?
Marking this as resolved.
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=541678#c35
(In reply to Vikas Chandra from comment #19) > See https://bugs.eclipse.org/bugs/show_bug.cgi?id=541678#c35 So, you reverted the changes for this bug here? If so, why is the revert not attached here?
(In reply to Dani Megert from comment #20) > (In reply to Vikas Chandra from comment #19) > > See https://bugs.eclipse.org/bugs/show_bug.cgi?id=541678#c35 > So, you reverted the changes for this bug here? If so, why is the revert not > attached here? The revert had conflicts. So I had to manually revert it and it didn't appear on this bug. I have now added it to "See Also".
(In reply to Vikas Chandra from comment #21) > (In reply to Dani Megert from comment #20) > > (In reply to Vikas Chandra from comment #19) > > > See https://bugs.eclipse.org/bugs/show_bug.cgi?id=541678#c35 > > So, you reverted the changes for this bug here? If so, why is the revert not > > attached here? > > The revert had conflicts. So I had to manually revert it and it didn't > appear on this bug. I have now added it to "See Also". Thanks.
New Gerrit change created: https://git.eclipse.org/r/136899
Comment#23 has a patch ( WIP) which modifies patch in comment#1 1) For getting line separator from an IFile, TextUtilities.getDefaultLineDelimiter is used 2) For files external to workspace, line separator from InputStream is taken ( ExternalFileTargetHandle) 3) Utility function used at multiple places are now put in CoreUtility This fixes target editor issues in windows and Mac and doesn't create a new problem while creating a new target file.
New Gerrit change created: https://git.eclipse.org/r/136903
(In reply to Vikas Chandra from comment #24) > Comment#23 has a patch ( WIP) which modifies patch in comment#1 > > 1) For getting line separator from an IFile, > TextUtilities.getDefaultLineDelimiter is used > > 2) For files external to workspace, line separator from InputStream is taken > ( ExternalFileTargetHandle) > > 3) Utility function used at multiple places are now put in CoreUtility > > This fixes target editor issues in windows and Mac and doesn't create a new > problem while creating a new target file. This is still a hack with lots of (existing) duplicated code. PDE should change all the code to directly use file buffers (see also bug 515662).
The current implementation utilize the javax.xml.transform.Transformer and very sensitive to JRE version. In particular, the line endings may be set (or preserved, who knows) by transformer implementation. Let's try to use standard PDE way of writing manifests. It is a bit vintage and has a lot of hand-made xml processing, but provides fine control over the file content. I suggest to move this one to 4.13 @Vikas, @Julian WDYT?
(In reply to Alexander Fedorov from comment #27) > The current implementation utilize the javax.xml.transform.Transformer and > very sensitive to JRE version. In particular, the line endings may be set > (or preserved, who knows) by transformer implementation. > > Let's try to use standard PDE way of writing manifests. It is a bit vintage > and has a lot of hand-made xml processing, but provides fine control over > the file content. > > I suggest to move this one to 4.13 > > @Vikas, @Julian WDYT? Lets take this up in 4.14 !
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie.
