Bug 534554 - [Wayland] Javadoc doesn't dissapear via Esc until you clicked into it
Summary: [Wayland] Javadoc doesn't dissapear via Esc until you clicked into it
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.8   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.9 M3   Edit
Assignee: Xi Yan CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks: 535260 542104
  Show dependency tree
 
Reported: 2018-05-10 14:54 EDT by Leo Ufimtsev CLA
Modified: 2018-12-04 13:22 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Ufimtsev CLA 2018-05-10 14:54:33 EDT
Fedora 28/Gtk3.22

On wayland only:

- Hover over an element
- Press F2 to make Javadoc popup.
- Try to press ESC.

Expected:
- Javadoc should close

Actual:
- Javadoc stays open.
- But if you click into the javadoc, then press ESC, then it closes.

Note:
- This is a regression of the Gnome-Crash fix:
  https://git.eclipse.org/r/#/c/122135/
  I.e, hiding the window and showing it after seems to make window focus work.
  But one should note, that the snippet in the bug still works.
- We noticed that this seems to be webkit related. If we go into Browser's constructor and comment out creation of Webbrowser/webkit instance, then the javadoc is created via styledText (?) and the issue doesn't occur.
- It might be that webkit is swallowing certain keyboard events that it shouldn't or isn't emitting SWT keyevents when it should.

However, we shouldn't revert : https://git.eclipse.org/r/#/c/122135/ because that would lead to gnome crashing. So we need to find another solution.
Comment 1 Eric Williams CLA 2018-08-07 10:34:32 EDT
Xi, please investigate. I believe this is a Wayland issue and not really related to Webkit.
Comment 2 Eclipse Genie CLA 2018-08-09 10:20:38 EDT
New Gerrit change created: https://git.eclipse.org/r/127249
Comment 4 Eric Williams CLA 2018-08-13 10:55:19 EDT
(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/127249 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=26b042e525d770ec2bb9884d4d12f3a6e98d6210

In master now, thanks for the patch Xi.
Comment 5 Eric Williams CLA 2018-08-23 08:50:33 EDT
Verified in I20180821-2000.