Bug 531784 - [Tips] Make Tip of the Day ready for release
Summary: [Tips] Make Tip of the Day ready for release
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.8 RC2   Edit
Assignee: Wim Jongman CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
: 480550 (view as bug list)
Depends on: 307889 531786 531788 531792 531842 531863 531983 532012 532051 532293 534050 534062 534073 534178 534252 534595 534920 534921
Blocks:
  Show dependency tree
 
Reported: 2018-02-28 05:53 EST by Wim Jongman CLA
Modified: 2018-05-24 04:54 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wim Jongman CLA 2018-02-28 05:53:53 EST 

    


    


      



        
          Comment 1
        

        
          Ed Merks CLA

        

        
        

        
          2018-03-23 06:52:07 EDT
        

      






I'm working on the Oomph setup for all the platform projects and I noticed that the test org.eclipse.tips.manual.tests.SleakTipManager doesn't compile.

Description	Resource	Path	Location	Type
The method addDisposeListener((<no type> pE) -> {}) is undefined for the type TipDialog	SleakTipManager.java	/org.eclipse.tips.tests/src/org/eclipse/tips/manual/tests	line 69	Java Problem

It would be great if the workspace didn't contain projects with errors.  I'm not sure if this project should be ignored?  Probably better if there compile error were fixed.  Should I open a separate bug?

    


    


      



        
          Comment 2
        

        
          Wim Jongman CLA

        

        
        

        
          2018-03-23 07:11:07 EDT
        

      






Thanks for reporting. This one fell through because it is not listed as a module in the UA pom (yet).

I have fixed it with: https://git.eclipse.org/r/120059 

It is in Bug 531863: [Tips] Unit tests

    


    


      



        
          Comment 3
        

        
          Wim Jongman CLA

        

        
        

        
          2018-03-23 08:06:59 EDT
        

      






(In reply to Wim Jongman from comment #2)
> 
> I have fixed it with: https://git.eclipse.org/r/120059 


Correction there were already two patches waiting to be released. I combined them into one. Details on Bug 531863

    


    


      



        
          Comment 4
        

        
          Mickael Istria CLA

        

        
        

        
          2018-04-29 04:13:59 EDT
        

      






Many of the bugs marked as dependencies seems more possible enhancements which are not blockers for a release.
I suggest for easier planning you keep the list of bugs here to a very minimal set that would make it good to go, and we should focus effort on those ones at the moment and ignore others.

    


    


      



        
          Comment 5
        

        
          Mickael Istria CLA

        

        
        

        
          2018-04-29 16:10:07 EDT
        

      






*** Bug 480550 has been marked as a duplicate of this bug. ***

    


    


      



        
          Comment 6
        

        
          Wim Jongman CLA

        

        
        

        
          2018-05-17 11:18:31 EDT
        

      






*** Bug 480550 has been marked as a duplicate of this bug. ***

    


    


      



        
          Comment 7
        

        
          Mickael Istria CLA

        

        
        

        
          2018-05-23 04:57:27 EDT
        

      






From Platform POV, Tips are released with 4.8 (in the p2 repo only, but still released). If they're release, it's hopefully because they are ready. So the bug can be closed.
Thanks a lot Wim for brining this now pleasant flow to Eclipse IDE users!