Bug 531709 - Open resource dialog should always show the path
Summary: Open resource dialog should always show the path
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7.1   Edit
Hardware: PC Linux
: P3 normal with 1 vote (vote)
Target Milestone: 4.8 M6   Edit
Assignee: Jonas Hungershausen CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation, noteworthy
Depends on:
Blocks:
 
Reported: 2018-02-27 03:05 EST by Lars Vogel CLA
Modified: 2018-03-02 12:03 EST (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2018-02-27 03:05:08 EST 
Currently the Open resource dialog shows only the path of resources if there are duplicate entries. This makes is harder to extract the path name for a resource and has been confusing to user like me. The very fist time I noticed that some path were missing, I though this was a bug. 

There was an intensive discussion on the platform-ui-dev mailing list. The majority of developers were in favor of always showing the path. See https://dev.eclipse.org/mhonarc/lists/platform-ui-dev/msg08027.html
Comment 1 Lars Vogel CLA 2018-02-27 03:07:18 EST 
Jonas, can you provide a patch which always shows the paths? We can find the relevant code via Bug 531610 and its commits.
Comment 2 Mickael Istria CLA 2018-02-27 05:22:59 EST 
If we do that, it's also worth considering getting rid of the status bar in the dialog too.
Added a "documentation" tag as this may have impact on documentation (ie some screenshots may need to be updated)
Comment 3 Lars Vogel CLA 2018-02-27 05:28:30 EST 
(In reply to Mickael Istria from comment #2)
> If we do that, it's also worth considering getting rid of the status bar in
> the dialog too.

Ah, that was what Dani talked about, I never noticed this one. +1 for removing it, once we always display the path.
Comment 4 Brian de Alwis CLA 2018-02-27 10:20:06 EST 
You can already remove it with the drop-down's _Show Status Line_ option.
Comment 5 Dani Megert CLA 2018-02-27 12:32:49 EST 
(In reply to Lars Vogel from comment #3)
> (In reply to Mickael Istria from comment #2)
> > If we do that, it's also worth considering getting rid of the status bar in
> > the dialog too.
> 
> Ah, that was what Dani talked about, I never noticed this one. +1 for
> removing it, once we always display the path.

However works on this be careful. The Open Type dialog also shows package information in the status line. Make sure your change does not remove the status line for any other dialog than the Open Resource dialog.
Comment 6 Dani Megert CLA 2018-02-27 12:43:42 EST 
(In reply to Dani Megert from comment #5)
> (In reply to Lars Vogel from comment #3)
> > (In reply to Mickael Istria from comment #2)
> > > If we do that, it's also worth considering getting rid of the status bar in
> > > the dialog too.
> > 
> > Ah, that was what Dani talked about, I never noticed this one. +1 for
> > removing it, once we always display the path.
> 
> However works on this be careful.

Whoever...
Comment 7 Eclipse Genie CLA 2018-02-27 13:57:47 EST 
New Gerrit change created: https://git.eclipse.org/r/118295
Comment 9 Lars Vogel CLA 2018-03-02 09:38:08 EST 
Thanks Jonas and Lucas.
Comment 10 Eclipse Genie CLA 2018-03-02 09:47:56 EST 
New Gerrit change created: https://git.eclipse.org/r/118537