531610 – Open Resource dialog doesn't show paths for duplicated files

Bug 531610 - Open Resource dialog doesn't show paths for duplicated files

Summary: Open Resource dialog doesn't show paths for duplicated files

Status:	VERIFIED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	IDE (show other bugs)
Version:	4.8
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	4.8 M6
Assignee:	Lucas Bullen
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	528301
	Show dependency tree

Reported:	2018-02-23 11:17 EST by Andrey Loskutov
Modified:	2018-02-27 03:06 EST (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit 531709

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrey Loskutov

2018-02-23 11:17:01 EST

Regression in 4.8 M5 (M4 OK).

Create a/file.txt and b/file.txt and open resource dialog, type file.txt.

There is no path shown for two entries, only the name. In M4 the path was there.

Comment 1 Dani Megert

2018-02-23 11:24:41 EST

Lucas, I think this got broken by one of your changes.

Comment 2 Andrey Loskutov

2018-02-23 11:29:41 EST

I've bisected this to bug 528301 commit b105a174363cffdd389ee1ef930f8b28720d2bd0.

Commit e17d485d7898de45c168fac20e34cb80f76fc995 is fine.

Comment 3 Eclipse Genie

2018-02-23 12:42:23 EST

New Gerrit change created: https://git.eclipse.org/r/118070

Comment 4 Eclipse Genie

2018-02-24 09:43:19 EST

Gerrit change https://git.eclipse.org/r/118070 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8813c2bea752bcbbb70c49256faca6a03ee041cf

Comment 5 Dani Megert

2018-02-25 11:28:21 EST

Verified in I20180224-1500.

Comment 6 Jens Lideström

2018-02-26 03:28:46 EST

The new test for this bug is causing trouble:

https://git.eclipse.org/r/#/c/118070/2/tests/org.eclipse.ui.tests/Eclipse+UI+Tests/org/eclipse/ui/tests/dialogs/ResourceItemLabelTest.java

Even if the test passed on the review branch it seems to be failing intermittently later.

It has failed in these two builds:

https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/14501/
https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/14504/

Comment 7 Eclipse Genie

2018-02-26 08:01:15 EST

New Gerrit change created: https://git.eclipse.org/r/118153

Comment 8 Eclipse Genie

2018-02-26 09:11:53 EST

Gerrit change https://git.eclipse.org/r/118153 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=5e46351189958dc60019e84c512f8aa55fceae79

Comment 9 Alexander Kurtakov

2018-02-26 09:14:21 EST

Jens, tests should be better now.