Bug 530966 - Add "Clear History" item to "Recent Files" menu
Summary: Add "Clear History" item to "Recent Files" menu
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.8   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-02-09 14:06 EST by Patrik Suzzi CLA
Modified: 2020-08-05 12:56 EDT (History)
1 user (show)

See Also:

Attachments
Clear History in the Open Recent menu (234.08 KB, image/png)
2018-02-09 16:56 EST, Patrik Suzzi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Suzzi CLA 2018-02-09 14:06:16 EST 
Add a "Clear History" menu item to the "Recent Documents" menu added in bug 529885.
Comment 1 Patrik Suzzi CLA 2018-02-09 16:56:23 EST 
Created attachment 272621 [details]
Clear History in the Open Recent menu
Comment 2 Patrik Suzzi CLA 2018-02-09 19:07:12 EST 
New Gerrit change created: https://git.eclipse.org/r/#/c/117087/
Comment 3 Patrik Suzzi CLA 2018-02-10 05:04:25 EST 
As reported in Gerrit's comment: 

Please hide or disable the menu item if the history is empty.


However, 

I think it is better to leave the menu and show only one menuitem, like "Clear History", to signal the history is empty. 
For example, in VS code, you still have the "Reopen Closed Editor" item, see https://i.imgur.com/DgzulSR.png
Or, in Atom you still have the Clear History item, see https://imgur.com/RMWe7E9.png.
Since this is part of the discussion, I'll put it on the bug.

Aby contribution to the discussion is welcome!
Comment 4 Andrey Loskutov CLA 2018-02-10 14:32:55 EST 
I think we can leave "Clear history" if there is no history, but this entry must be disabled.
Comment 5 Eclipse Genie CLA 2018-02-11 10:15:35 EST 
Gerrit change https://git.eclipse.org/r/117087 was merged to [master].
Commit: http://git.eclipse.org/c/.git/commit/?id=dac960ed50b8732911fa4c252c1d836773fd782f