Bug 526802 - [Win32] Update SWT Windows native build scripts to work with latest VisualStudio2107 and Win10 SDKs
Summary: [Win32] Update SWT Windows native build scripts to work with latest VisualStu...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.8   Edit
Hardware: PC Windows All
: P3 enhancement (vote)
Target Milestone: 4.8 M5   Edit
Assignee: Niraj Modi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 528319
Blocks: 520299 536562 559865
  Show dependency tree
 
Reported: 2017-11-03 06:19 EDT by Niraj Modi CLA
Modified: 2020-02-13 04:50 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Niraj Modi CLA 2017-11-03 06:19:53 EDT
This bug is to investigate/upgrade SWT to latest VisualStudio and Windows-SDK.
Comment 1 Niraj Modi CLA 2017-11-03 06:23:31 EDT
Started experimenting SWT with below on a Windows10 machine:
1. Latest Windows 10 SDK
2. VisualStudio 2017 community edition
Comment 2 Niraj Modi CLA 2017-11-13 07:45:23 EST
(In reply to Niraj Modi from comment #1)
> Started experimenting SWT with below on a Windows10 machine:
> 1. Latest Windows 10 SDK
> 2. VisualStudio 2017 community edition

I am using the "VisualStudio 2017 Community Edition" which is free, corresponding web installer link for reference:
https://www.visualstudio.com/thank-you-downloading-visual-studio/?sku=Community&rel=15
Comment 3 Eclipse Genie CLA 2017-11-17 05:25:44 EST
New Gerrit change created: https://git.eclipse.org/r/111780
Comment 4 Niraj Modi CLA 2017-11-17 05:29:53 EST
(In reply to Eclipse Genie from comment #3)
> New Gerrit change created: https://git.eclipse.org/r/111780

Above is a working patch.. have workaround few unknowns, which still needs to be analyzed.
Comment 5 Niraj Modi CLA 2017-12-20 11:44:32 EST
(In reply to Niraj Modi from comment #4)
> (In reply to Eclipse Genie from comment #3)
> > New Gerrit change created: https://git.eclipse.org/r/111780
> 
> Above is a working patch.. have workaround few unknowns, which still needs
> to be analyzed.

Addressed the workarounds, latest gerrit patch is ready to go.
Waiting for the bug 528319 to be addressed.
Comment 6 Niraj Modi CLA 2017-12-20 11:48:35 EST
Hi Conrad,
If possible, can you try the latest gerrit patch on you local setup ?
You will need to install latest Windows 10 SDK and VisualStudio 2017 community edition SDK which are free, for exact details you can refer below:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=528319#c0
Comment 8 Niraj Modi CLA 2018-01-05 07:57:29 EST
(In reply to Eclipse Genie from comment #7)
> Gerrit change https://git.eclipse.org/r/111780 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=c5e9c5f34ab0f7d4b11000197dda66a4d6564911

With above changes, we have are done with the necessary changes in SWT build scripts/code to move to the latest Windows 10 SDK and Visual Studio 2017 SDK.
Also done with the SWT native build input, all seems fine.

Tonight's Eclipse Windows build will be consuming the latest binaries.
Comment 9 Niraj Modi CLA 2018-01-08 07:43:16 EST
(In reply to Niraj Modi from comment #8)
> (In reply to Eclipse Genie from comment #7)
> > Gerrit change https://git.eclipse.org/r/111780 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> > ?id=c5e9c5f34ab0f7d4b11000197dda66a4d6564911
> 
> With above changes, we have are done with the necessary changes in SWT build
> scripts/code to move to the latest Windows 10 SDK and Visual Studio 2017 SDK.
> Also done with the SWT native build input, all seems fine.
> 
> Tonight's Eclipse Windows build will be consuming the latest binaries.

I20180105-2000 and on-wards Eclipse Windows builds are consuming the binaries built using the latest Win10SDK and VS2017.

Will be refactoring the build.bat to work with updated directory structure on the Eclipse Foundation build machine.
Comment 10 Eclipse Genie CLA 2018-01-08 09:11:10 EST
New Gerrit change created: https://git.eclipse.org/r/115058
Comment 12 Niraj Modi CLA 2018-01-09 08:40:53 EST
(In reply to Eclipse Genie from comment #11)
> Gerrit change https://git.eclipse.org/r/115058 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=93e4378c824ab449f9ae4b4fc4fe7c9e0f13e776

Above patch does the required clean-up of the build.bat and now matches the directory structure of current Windows build machine on Eclipse Foundation.

In our testing we haven't noticed any major changes w.r.t. Eclipse UI or SWT widgets, waiting for community feedback.
Comment 13 Niraj Modi CLA 2018-01-16 03:46:48 EST
SWT Windows native setup page has been updated for newer SDKs:
https://www.eclipse.org/swt/swt_win_native.php

Resolving this bug now.
Comment 14 Niraj Modi CLA 2018-01-24 03:54:04 EST
Verified latest Eclipse 64/32bit Builds Id: I20180122-2000 on Win7/Win10.
Comment 15 Andrey Loskutov CLA 2019-06-21 00:49:07 EDT
*** Bug 544750 has been marked as a duplicate of this bug. ***
Comment 16 Andrey Loskutov CLA 2019-06-21 00:49:38 EDT
*** Bug 541523 has been marked as a duplicate of this bug. ***