521985 – [CSS][Dark][Mac] Styling for dark buttons on Mac

Bug 521985 - [CSS][Dark][Mac] Styling for dark buttons on Mac

Summary: [CSS][Dark][Mac] Styling for dark buttons on Mac

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.8
Hardware:	PC Mac OS X

Importance:	P3 normal (vote)
Target Milestone:	4.8 M2
Assignee:	Till Brychcy
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:	505835
Blocks:
	Show dependency tree

Reported:	2017-09-07 07:07 EDT by Till Brychcy
Modified:	2017-09-13 03:09 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
screen shot: buttons in dark design (38.84 KB, image/png) 2017-09-07 07:55 EDT, Till Brychcy	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Till Brychcy

2017-09-07 07:07:04 EDT

Now that Bug 505835 is merged, the css needs to be adjusted.

Comment 1 Till Brychcy

2017-09-07 07:47:27 EDT

@Lakshmi, can you please commit this? Or is somebody else needed for this?

Comment 2 Lars Vogel

2017-09-07 07:49:40 EDT

Till, can you add a screenshot to the bug?

Comment 3 Till Brychcy

2017-09-07 07:55:33 EDT

Created attachment 270108 [details]
screen shot: buttons in dark design

Comment 4 Eclipse Genie

2017-09-07 08:02:46 EDT

Gerrit change https://git.eclipse.org/r/95215 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=14005feea266cf63cc198aff0d1b3afab0868418

Comment 5 Lars Vogel

2017-09-07 08:05:05 EDT

Thanks Till, please add also the N&N M2.

Comment 6 Lars Vogel

2017-09-07 08:07:59 EDT

I suggest to downport this to 4.7.2. Till and Lakshmi, if you agree, please adjust the target.

Comment 7 Lakshmi P Shanmugam

2017-09-08 06:30:28 EDT

(In reply to Lars Vogel from comment #6)
> I suggest to downport this to 4.7.2. Till and Lakshmi, if you agree, please
> adjust the target.

This requires more testing as part of the builds before being backported. Also, there is one open issue - Bug 522040, which needs to investigated before backporting.

Comment 8 Lars Vogel

2017-09-08 06:36:06 EDT

(In reply to Lakshmi Shanmugam from comment #7)
> (In reply to Lars Vogel from comment #6)
> > I suggest to downport this to 4.7.2. Till and Lakshmi, if you agree, please
> > adjust the target.
> 
> This requires more testing as part of the builds before being backported.
> Also, there is one open issue - Bug 522040, which needs to investigated
> before backporting.

My understanding is that if you set the target to a maintenance release you indicated that you plan to backport. It is IMHO different than the actual backport. More like a reminder, yes, we are planning to backport, if all goes well.

Comment 9 Eclipse Genie

2017-09-10 15:49:41 EDT

New Gerrit change created: https://git.eclipse.org/r/104813

Comment 10 Eclipse Genie

2017-09-10 15:50:22 EDT

Gerrit change https://git.eclipse.org/r/104813 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=947da68207b09836196260d93d461be6bdd16e2a

Comment 11 Till Brychcy

2017-09-10 15:50:57 EDT

(In reply to Lars Vogel from comment #5)
> Thanks Till, please add also the N&N M2.

(In reply to Eclipse Genie from comment #9)
> New Gerrit change created: https://git.eclipse.org/r/104813

Done.