Community
Participate
Working Groups
The same behavior described in Bug 516365 happens for the Tree widget, i.e. the background gets a system default color when the widget is disabled. Can be easily reproduced with the ControlExample.
(In reply to Conrad Groth from comment #0) > The same behavior described in Bug 516365 happens for the Tree widget, i.e. > the background gets a system default color when the widget is disabled. Can > be easily reproduced with the ControlExample. Hi Conrad, With fix for Table widget bug 516365 in place, we can proceed with Tree changes. For consistency between Table and Tree widgets please target M3 itself. Thanks!
Recent note from Conrad, regarding his availability in M3: ---------------------------------------------------------------- Hi Niraj, > With fix for Table widget bug 516365 in place, we can proceed with Tree changes. > For consistency between Table and Tree widgets please target M3 itself. Thanks! I’m on vacation until October 17th. So I can only provide the Tree patch after that date. Best regards Conrad
New Gerrit change created: https://git.eclipse.org/r/110486
Gerrit change https://git.eclipse.org/r/110486 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=dd3790a1446afe8dae6516c0cd3905ef4d295a8a
(In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/110486 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=dd3790a1446afe8dae6516c0cd3905ef4d295a8a Thanks Conrad for the fix, resolving now.
Verified with 4.8 M3 candidate Eclipse Build: I20171023-2000 on Win10.
Very bad! This breaks makes the sort column dark gray and removes the row lines for that column. We might have to respin M3.
This bug should never have been pushed to M3. Only regressions found in the test pass and blockers should be committed after a test pass. Why was this pushed?
Created attachment 271216 [details] Picture showing broken tree
In fact this behavior wasn't introduced by this patch only. It was introduced by some other custom-coloring bug (I caouldn't find the number quickly) and already reported as bug 511355. I already proposed a patch for that ticket, but unfortunately I lost that patch from my radar totally. Sorry for that. Will provide an updated patch for bug 511355 shortly and that will also address Table and Tree coloring issue.
(In reply to Dani Megert from comment #8) > This bug should never have been pushed to M3. Only regressions found in the > test pass and blockers should be committed after a test pass. Why was this > pushed? Sorry, I looked at the wrong date. The fix was pushed before the test pass. I wonder why no one detected this.
(In reply to Conrad Groth from comment #10) > In fact this behavior wasn't introduced by this patch only. It was > introduced by some other custom-coloring bug (I caouldn't find the number > quickly) and already reported as bug 511355. I already proposed a patch for > that ticket, but unfortunately I lost that patch from my radar totally. > Sorry for that. Will provide an updated patch for bug 511355 shortly and > that will also address Table and Tree coloring issue. The PMC decided to respin M3 to provide a fix. I tested that reverting the change brings back the old look. Another approach is to provide the fix for bug 511355 today or early tomorrow, so that we can respin on early on Monday. Reverting is probably less risky.
(In reply to Dani Megert from comment #12) > The PMC decided to respin M3 to provide a fix. I tested that reverting the > change brings back the old look. Another approach is to provide the fix for > bug 511355 today or early tomorrow, so that we can respin on early on > Monday. Reverting is probably less risky. I prefer reverting, as it's the easiest and least risky option.
I cannot revert the commit as I'm no committer. This has to be done by someone else.
New Gerrit change created: https://git.eclipse.org/r/110710
(In reply to Eclipse Genie from comment #15) > New Gerrit change created: https://git.eclipse.org/r/110710 We will revert the fix, via above gerrit shortly.
Gerrit change https://git.eclipse.org/r/110710 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6d54623bc929a1ff670c6cde1f13b511105ad805
(In reply to Eclipse Genie from comment #17) > Gerrit change https://git.eclipse.org/r/110710 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=6d54623bc929a1ff670c6cde1f13b511105ad805 Reverted, moving the bug to M4.
(In reply to Niraj Modi from comment #18) > (In reply to Eclipse Genie from comment #17) > > Gerrit change https://git.eclipse.org/r/110710 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > > ?id=6d54623bc929a1ff670c6cde1f13b511105ad805 > > Reverted, moving the bug to M4. Verified the fix on Windows with eclipse-SDK-4.7.1-win32-x86_64.
(In reply to Dani Megert from comment #19) > (In reply to Niraj Modi from comment #18) > > (In reply to Eclipse Genie from comment #17) > > > Gerrit change https://git.eclipse.org/r/110710 was merged to [master]. > > > Commit: > > > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > > > ?id=6d54623bc929a1ff670c6cde1f13b511105ad805 > > > > Reverted, moving the bug to M4. > > Verified the fix on Windows with eclipse-SDK-4.7.1-win32-x86_64. I tested with eclipse-SDK-I20171030-0400-win32-x86_64.
(In reply to Conrad Groth from comment #10) > In fact this behavior wasn't introduced by this patch only. It was > introduced by some other custom-coloring bug (I caouldn't find the number > quickly) and already reported as bug 511355. I already proposed a patch for > that ticket, but unfortunately I lost that patch from my radar totally. > Sorry for that. Will provide an updated patch for bug 511355 shortly and > that will also address Table and Tree coloring issue. Combined tested, the latest patch from bug 511355 along with the original fix proposed for this bug 518737 and it doesn't have the problem w.r.t. Tree/Table Sort columns mentioned in https://bugs.eclipse.org/bugs/show_bug.cgi?id=518737#c7 Will push the changes for both these bugs shortly.
New Gerrit change created: https://git.eclipse.org/r/111122
Gerrit change https://git.eclipse.org/r/111122 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=41b7b40e2bce65b5731c64c608596c9dd5c042d6
Thanks Conrad for your contribution. Resolving now.
(In reply to Niraj Modi from comment #24) > Thanks Conrad for your contribution. Resolving now. Could we downport this to 4.7.2?
(In reply to Lars Vogel from comment #25) > (In reply to Niraj Modi from comment #24) > > Thanks Conrad for your contribution. Resolving now. > > Could we downport this to 4.7.2? -1. 4.7.3 could be an option though. Not sure how much it depends on other changes that were made in that area.
(In reply to Dani Megert from comment #26) > (In reply to Lars Vogel from comment #25) > > (In reply to Niraj Modi from comment #24) > > > Thanks Conrad for your contribution. Resolving now. > > > > Could we downport this to 4.7.2? > > -1. 4.7.3 could be an option though. Not sure how much it depends on other > changes that were made in that area. See https://bugs.eclipse.org/bugs/showdependencytree.cgi?id=518737&hide_resolved=0 which shows 4 dependent bugs.
(In reply to Lars Vogel from comment #25) > Could we downport this to 4.7.2? I'm not interested in it and I will not do it.
Verified using Eclipse Build id: I20171205-2000 on Win7
