Bug 517681 - 'No suggestions available' always visible in quick fix
Summary: 'No suggestions available' always visible in quick fix
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.11   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.13 M1   Edit
Assignee: Lakshminarayana CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 513314
Blocks:
  Show dependency tree
 
Reported: 2017-06-02 04:14 EDT by Michal Niewrzal CLA
Modified: 2019-06-28 09:41 EDT (History)
2 users (show)

See Also:

Attachments
screenshot (20.47 KB, image/png)
2017-06-02 04:14 EDT, Michal Niewrzal CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Niewrzal CLA 2017-06-02 04:14:48 EDT 
Created attachment 268711 [details]
screenshot

To reproduce use CSS integration. See screenshot.

Code:
.aaaa {
	color2: antiquewhite
}
Comment 1 Michal Niewrzal CLA 2017-06-06 03:01:58 EDT 
Additional entry comes from org.eclipse.ui.texteditor.spelling.SpellingCorrectionProcessor
Comment 2 Mickael Istria CLA 2017-06-06 04:11:25 EDT 
I think it's a dup of #513314 , which was fixed in Platform M7. Which version of Platform are you using?
Comment 3 Michal Niewrzal CLA 2017-06-06 05:14:58 EDT 
I checked with platform from 20170524-2000 and generic editor 1.0.0.v20170516-0821
Comment 4 Michal Niewrzal CLA 2017-06-06 05:45:22 EDT 
SpellingCorrectionProcessor was added with this commit
https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=7246e5b58d418d14b6647937bc83bc16a7db7083

and with empty proposals list will return default NoCompletionsProposal.
Comment 5 Mickael Istria CLA 2017-06-06 05:53:21 EDT 
Ok, but the spell-checker should be disabled on the generic editor; the commit you link has for goal that if a spelling error is reported, then quick-fix are offered, but in most case, spelling shouldn't be checked. Or maybe you did open the file in another editor that has activated spell-checking on it?
In any case, I think it's an issue in Platform-Text has there is no reason for a quick-fix to create an entry for empty results.
Comment 6 Michal Niewrzal CLA 2017-06-06 06:01:19 EDT 
(In reply to Mickael Istria from comment #5)
> maybe you did open the file in another editor that has activated
> spell-checking on it?

I had only generic editor.

> In any case, I think it's an issue in Platform-Text has there is no reason
> for a quick-fix to create an entry for empty results.

Yes, most probably it will be the best fix.
Comment 7 Eclipse Genie CLA 2019-06-28 09:15:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/145118
Comment 8 Lakshminarayana CLA 2019-06-28 09:23:28 EDT 
(In reply to Eclipse Genie from comment #7)
> New Gerrit change created: https://git.eclipse.org/r/145118

@Mickael Istria  Can you review it?. I don't have much context.

As per my understanding, it was missed in this commit

https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=2506487936fb97d773fe2797e919a44d830b23b2
Comment 9 Mickael Istria CLA 2019-06-28 09:41:34 EDT 
Thanks  Lakshminarayana!