Community
Participate
Working Groups
While converting editors to the generic one I faced the spellcheck annotation/underline and what's worse it provides hovers which take precedence over hovers added for the given editor thus actually decreasing functionality.
I disagree regarding disabling it, but it should only spell check partitions that have natural language, e.g. Javadoc or "normal" text files.
The partition mechanism is not necessary to work the generic editor. It's made optional at the convenience of contributors. So we cannot rely on it for decision. Concretely, the partition mechanism is one of the layers that are very Eclipse-specific and perceived as overkill for some language developers who have some tools applying on text files directly and who don't do partitioning in Eclipse. It's something we need to make fully optional for the success of the Generic Editor and we cannot rely on it as a part of a solution there. It's much simpler and more consistent with current state to disable spell-checking by default in Generic Editor and let people enable spell checking by themselves where and when they need it. I'll have the example and PDE template show how to enable spell checking where it makes sense.
(In reply to Mickael Istria from comment #2) > It's much simpler and more consistent with current state to disable > spell-checking by default in Generic Editor and let people enable spell > checking by themselves where and when they need it. OK, but then they must be able to enable it per generic editor extension. Otherwise it will always be useless for some.
On 2nd thought, as usual, I agree with you Dani ;) If there is a dedicated partition for "natural language", it's fine to enable spellcheck by default and shouldn't harm. However, I have the impression that currently the spellcheck applies on the Default partition type (which is not guaranteed to be natural language) so spellcheck applies on code. Is there an existing partition type in Platform Text for natural language that we could link to?
(In reply to Mickael Istria from comment #4) > However, I have the > impression that currently the spellcheck applies on the Default partition > type (which is not guaranteed to be natural language) so spellcheck applies > on code. That depends on how it is set up. This can differ from editor to editor. As you can see in the Java editor the code (default partition) isn't spell checked.
New Gerrit change created: https://git.eclipse.org/r/93144
A good example to add spell checking to the .project editor example, only on the "comment" element. This can be added to the example plugin and the template. However, I'd rather work on it in separate commits and let https://git.eclipse.org/r/93144 move forward separately.
Gerrit change https://git.eclipse.org/r/93144 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=2506487936fb97d773fe2797e919a44d830b23b2
New Gerrit change created: https://git.eclipse.org/r/93567
Gerrit change https://git.eclipse.org/r/93567 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=7246e5b58d418d14b6647937bc83bc16a7db7083
The example shows a possible way to enable spellcheck. On the long run, it might be interesting to create a generic "natural language" document partition type that document listener or whatever other mechanism could set on some areas of the document, then we could consider enabling a generic spell checker that would run spellcheck only on those partitions, independently of the file content-type or of other language-specific stuff.
New Gerrit change created: https://git.eclipse.org/r/93846
Gerrit change https://git.eclipse.org/r/93846 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=4d1c687563b083fa82a778a37f108483ab2aa217
