Bug 516403 - [Compatibility][PerspectiveExtension] closeable ignored on placeholders
Summary: [Compatibility][PerspectiveExtension] closeable ignored on placeholders
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.8 M3   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-10 06:42 EDT by Eugen Neufeld CLA
Modified: 2021-07-13 09:30 EDT (History)
3 users (show)

See Also:


Attachments
Example App (62.94 KB, application/zip)
2017-05-10 06:42 EDT, Eugen Neufeld CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Eugen Neufeld CLA 2017-05-10 06:42:43 EDT
Created attachment 268264 [details]
Example App

Hi, 
this might be a duplicate of https://bugs.eclipse.org/bugs/show_bug.cgi?id=433465 but I'm not sure. 

If you define an application with the compatibility layer and define your perspective using the perspectiveExtension you can define view placeholders. If you use ":*" in the id field, then you can define the position of views with with a secondary id. But the closeable attribute is ignored in this case.
The reason for this is, that during the startup all the placeholders are already created and the perspective settings are set on those placeholders.
But in the case of views with a secondary id this doesn't work as a new placeholder and a corresponding shared part is created. Thus only values from the partDescriptor are copied.

I attach an example demonstrating the issue.

Cheers,
Eugen
Comment 1 Eclipse Genie CLA 2017-05-10 06:47:16 EDT
New Gerrit change created: https://git.eclipse.org/r/96718
Comment 3 Andrey Loskutov CLA 2017-10-19 04:27:40 EDT
@All on CC: the patch was merged, but is this bug is still open - is here anything else to do? If not, please fix the bug status/milestone.

Is the fix related to bug 400771 and bug 433465?
Comment 4 Eugen Neufeld CLA 2017-10-19 06:45:09 EDT
I closed it, as it was merged and in my opinion no additional work is needed.

I think it is related to the two bugs bug 400771 and bug 433465 .