Community
Participate
Working Groups
The closable status for placeholders in the application model is incorrect. See attached screenshot. Eric any hints how I can fix that? I tried to set closable to true in ModeledPageLayout.createViewModel() does it did not make a difference. As our model should be the "basis of all truth", I think we should fix that.
Created attachment 242299 [details] Screenshot
Is the closeable status incorrect for all placeholders or only some of them? How do we know which placeholders have the right status? Or should all of the be set to true (like everything is closeable by default)?
(In reply to Dmitry Spiridenok from comment #2) > Is the closeable status incorrect for all placeholders or only some of them? > How do we know which placeholders have the right status? Or should all of > the be set to true (like everything is closeable by default)? You can check with the live model editor. Very placeholders for a view which is closable should have the model property set.
Lars, isn't there already a defect open for this ? In any case the 'NO_CLOSE' tag should be the winner in all cases; if it isn't being set using the ModeledPageLayout API then that's certainly a bug...
I have found the same problem for an application created by myself. No matter what the flag says, in the PlaceHolder or in the SharedElement, that the Part is closable.
Checked here with 4.7.3a. Workaround with tag on placeholder works for me, if you tag the placeholder with "NoClose". Closeable attribute is not working for placeholders, but tag does. (That tag don't work for native parts; you have to use Closeable attribute here.) You need to tag with the constant's value not the name, for sure. I'm not the only one who misunderstood that at first, I think. ;-) org.eclipse.e4.ui.workbench.IPresentationEngine.NO_CLOSE = "NoClose";
Just wondering if there is any progress on this? I can confirm that setting the Tag works but setting the checkbox does not, so in general there seems to be a place where the tag is evaluated but the check is ignored.
(In reply to Christoph Laeubrich from comment #7) > Just wondering if there is any progress on this? I can confirm that setting > the Tag works but setting the checkbox does not, so in general there seems > to be a place where the tag is evaluated but the check is ignored. Help wanted :-)
I'll try to take a look
New Gerrit change created: https://git.eclipse.org/r/163756
In the Gerrit there is the question how the closable status should be inherited from the placeholder and part: 1. Check Placeholder only, i.e. check the attribute and the tags of the placeholder only 2a. Check Placeholder and Part, i.e., check attribute and tag of Placeholder, check attribute of Part 2b. Check Placeholder and Part, i.e., check attribute and tag of Placeholder and check attribute and tag of Part 3. Check placeholder and Part (extended), the placeholder would require a tri-state: closeable (override part flag) not closeable (override part flag) inherit (from Part) Please provide input such that we can make progress on the Gerrit.
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/163756 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a1cc94041900edcc093b7326e4c1c36538362662
This fix caused regression, see bug 574819.
