Bug 512608 - [part management] 4 parts lists with different L&F
Summary: [part management] 4 parts lists with different L&F
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-23 02:16 EST by Andrey Loskutov CLA
Modified: 2020-06-11 01:34 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2017-02-23 02:16:53 EST
Follow up on bug 506019 and bug 368977.

Right now we have at least 4 part lists with different L&F:

1) Ctrl+E - editors list (decorates hidden/current parts, shows tooltips), white background (WorkbookEditorsHandler)
2) Ctrl+Shift+F6 - "cycle" editors list (nothing from above), white background (CycleEditorHandler)
3) Ctrl+F7 - "cycle" views list (nothing from above), white background (CycleViewHandler).
4) "Chevron" - part list on the tab folder button - (decorates only hidden parts, shows tooltips), yellow background (BasicPartList)

The goal of this task is:
1) Make the L&F of those lists consistent. They all should:
 - decorate hidden parts
 - decorate *current* part
 - provide tooltips for parts
 - have same background and other visual things (borders/margins etc)
2) Ideally reduce the implementations to a single common denominator and have only really required different things be implemented by a dedicated subclasses. Partly we are already there (via bug 368977) but we still need some work after latest changes in bug 506019.
Comment 1 Andrey Loskutov CLA 2017-02-23 02:18:42 EST
Patrik, do you have time to work on this for 4.7?
Comment 2 Patrik Suzzi CLA 2017-02-23 03:01:42 EST
I would split this bug in two or three changes:

(A)
First, addressing (1) Make the L&F of those lists consistent, for those with the same implementation Ctrl+E, Ctrl+F6, Ctrl+F7 (perhaps also to Ctrl+F8 highlighting hidden and active perspectives)

(B)
Then, addressing (1) Make the L&F of those lists consistent, for the BasicPart list

(C) 
If possible, address (2) reduce the implementations to a single common denominator.

Considerations
Point (A) and (B) are feasible and doable for 4.7. 
I think the point (C) should be moved to a different bug, as it depends on Bug 506696 - (in particular, transforming the implementation to be in a Dialog)
Comment 3 Andrey Loskutov CLA 2017-02-23 03:09:00 EST
(In reply to Patrik Suzzi from comment #2)
> I would split this bug in two or three changes:

Sure.

> Point (A) and (B) are feasible and doable for 4.7. 

Would be great if you could do this.

> I think the point (C) should be moved to a different bug, as it depends on
> Bug 506696 - (in particular, transforming the implementation to be in a
> Dialog)

Yes. I was not aware of the difficulties with bug 506696.
Comment 4 Eclipse Genie CLA 2020-06-11 01:34:08 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.