Community
Participate
Working Groups
Eclipse SDK Version: Oxygen (4.7) Build id: I20161027-0700 OS: Windows 7, v.6.1, x86_64 / win32 - beeps on second press of Ctrl+E - assign "Next Editor" to Alt+`. Press and hold Alt, type `, type Tab, release Alt. Switch back to Eclipse. => Dialog stays visible, on top, cannot be focused via keyboard. - after opening Ctrl+E, pressing Ctrl+Shift+E should scroll backwards, like in other element switchers - Tab / Shift+Tab should put focus in filter field like in other quick views - visible/invisible tabs are not marked any more (see also open bugs about old switcher
Description for command Quick Switch Editor (Ctrl+E) says: "Open the editor drop down list"
The height of the editors list should not be artificially limited. Ctrl+E is often used in situation where you have many open editors and only a few tabs are visible. (E.g. my workbench is configured to keep 30 editors open.) Restricting the number of editors means that not even Ctrl+E gives you an overview of your open editors any more. Scrolling the list is not a solution when the original goal was to get an overview (e.g. to identify dirty editors).
I almost wasted even more time to file a similar bug again. When you start messing with a feature, you need to reserve time to polish it afterwards and at least react to regressions.
Sorry for this wait time. I'll solve the issues one by one.
Created attachment 265784 [details] Image: removed restriction on number of editors when pressing Ctrl+E Now, when you press Ctrl+E, there is no restriction on the number of editors. So, you can have an overview comparing simultaneously all the open editors. Note, this applies only to Ctrl+E and not to Ctrl+F6 / F7 / F8 See the upcoming change.
New Gerrit change created: https://git.eclipse.org/r/86787
(In reply to Markus Keller from comment #2) > The height of the editors list should not be artificially limited. Please see the proposed fix for this specific one: https://git.eclipse.org/r/86787 Hope you don't mind telling me if I'm on the right direction.
(In reply to Patrik Suzzi from comment #5) > there is no restriction on the number of editors This doesn't work on my display, which only has a limited number of pixels. Rather than reinventing the wheel, use a org.eclipse.jface.window.Window (or a subclass like PopupDialog) that already implements a solution for that problem in constrainShellSize().
Switching to Dialog seems not very easy to achieve. In any case, I will try to fix this.
Note for the resolution: check CycleBaseHandler#setDialogLocation
When too many editors are opened, dialog width gettings smaller and cannot see class names. Please see attached screenshots.
Created attachment 270092 [details] smallwidth cannot see class names
Created attachment 270093 [details] correctsize
Moving target milestone to 4.9 for all bugs that are major or above.
Moving target milestone to 4.11 for all bugs that are major or above.
Mass change, please reset target if you still planning to fix this for 4.11.
Please set the target milestone back to 4.12 if you still intend to fix this for 4.12.
The below points are still actual and need to be fixed. - beeps on second press of Ctrl+E - after opening Ctrl+E, pressing Ctrl+Shift+E should scroll backwards, like in other element switchers - Tab / Shift+Tab should put focus in filter field like in other quick views
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/188211
Ctrl+Shift+E is already bound to "Switch to Editor". Is there a way to make the key binding contextual or do we have to use another key binding? I didn't even know the "Switch to Editor" dialog existed. "Switch to Editor" seems to be broken in my environment when my focus is on an editor window. The dialog opens as expected when my focus is on the package explorer.