Bug 506696 - Ctrl+E bugs (Next Editor/View/Perspective switcher popups)
Summary: Ctrl+E bugs (Next Editor/View/Perspective switcher popups)
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P2 major with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 506019
Blocks:
  Show dependency tree
 
Reported: 2016-10-28 06:41 EDT by Markus Keller CLA
Modified: 2021-11-27 13:02 EST (History)
6 users (show)

See Also:


Attachments
Image: removed restriction on number of editors when pressing Ctrl+E (114.56 KB, image/png)
2016-12-08 19:59 EST, Patrik Suzzi CLA
no flags Details
smallwidth (42.47 KB, image/png)
2017-09-06 04:22 EDT, Ugur Ozdemir CLA
no flags Details
correctsize (38.81 KB, image/png)
2017-09-06 04:22 EDT, Ugur Ozdemir CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2016-10-28 06:41:55 EDT
Eclipse SDK
Version: Oxygen (4.7)
Build id: I20161027-0700
OS: Windows 7, v.6.1, x86_64 / win32

- beeps on second press of Ctrl+E
- assign "Next Editor" to Alt+`. Press and hold Alt, type `, type Tab, release Alt. Switch back to Eclipse. => Dialog stays visible, on top, cannot be focused via keyboard.
- after opening Ctrl+E, pressing Ctrl+Shift+E should scroll backwards, like in other element switchers
- Tab / Shift+Tab should put focus in filter field like in other quick views
- visible/invisible tabs are not marked any more (see also open bugs about old switcher
Comment 1 Markus Keller CLA 2016-10-28 06:48:46 EDT
Description for command Quick Switch Editor (Ctrl+E) says:
"Open the editor drop down list"
Comment 2 Markus Keller CLA 2016-10-28 17:36:47 EDT
The height of the editors list should not be artificially limited. Ctrl+E is often used in situation where you have many open editors and only a few tabs are visible. (E.g. my workbench is configured to keep 30 editors open.)

Restricting the number of editors means that not even Ctrl+E gives you an overview of your open editors any more. Scrolling the list is not a solution when the original goal was to get an overview (e.g. to identify dirty editors).
Comment 3 Markus Keller CLA 2016-12-07 10:31:09 EST
I almost wasted even more time to file a similar bug again.

When you start messing with a feature, you need to reserve time to polish it afterwards and at least react to regressions.
Comment 4 Patrik Suzzi CLA 2016-12-08 18:51:55 EST
Sorry for this wait time. I'll solve the issues one by one.
Comment 5 Patrik Suzzi CLA 2016-12-08 19:59:30 EST
Created attachment 265784 [details]
Image: removed restriction on number of editors when pressing Ctrl+E

Now, when you press Ctrl+E, there is no restriction on the number of editors. So, you can have an overview comparing simultaneously all the open editors. 

Note, this applies only to Ctrl+E and not to Ctrl+F6 / F7 / F8

See the upcoming change.
Comment 6 Eclipse Genie CLA 2016-12-08 20:00:03 EST
New Gerrit change created: https://git.eclipse.org/r/86787
Comment 7 Patrik Suzzi CLA 2016-12-08 20:32:40 EST
(In reply to Markus Keller from comment #2)
> The height of the editors list should not be artificially limited. 

Please see the proposed fix for this specific one: https://git.eclipse.org/r/86787

Hope you don't mind telling me if I'm on the right direction.
Comment 8 Markus Keller CLA 2016-12-14 10:51:19 EST
(In reply to Patrik Suzzi from comment #5)
> there is no restriction on the number of editors

This doesn't work on my display, which only has a limited number of pixels.

Rather than reinventing the wheel, use a org.eclipse.jface.window.Window (or a subclass like PopupDialog) that already implements a solution for that problem in constrainShellSize().
Comment 9 Patrik Suzzi CLA 2016-12-16 10:34:43 EST
Switching to Dialog seems not very easy to achieve. In any case, I will try to fix this.
Comment 10 Patrik Suzzi CLA 2017-05-24 09:47:46 EDT
Note for the resolution: check CycleBaseHandler#setDialogLocation
Comment 11 Ugur Ozdemir CLA 2017-09-06 04:21:37 EDT
When too many editors are opened, dialog width gettings smaller and cannot see class names. Please see attached screenshots.
Comment 12 Ugur Ozdemir CLA 2017-09-06 04:22:27 EDT
Created attachment 270092 [details]
smallwidth

cannot see class names
Comment 13 Ugur Ozdemir CLA 2017-09-06 04:22:48 EDT
Created attachment 270093 [details]
correctsize
Comment 14 Dani Megert CLA 2018-05-24 13:01:21 EDT
Moving target milestone to 4.9 for all bugs that are major or above.
Comment 15 Dani Megert CLA 2018-12-04 11:37:05 EST
Moving target milestone to 4.11 for all bugs that are major or above.
Comment 16 Lars Vogel CLA 2019-02-19 03:32:38 EST
Mass change, please reset target if you still planning to fix this for 4.11.
Comment 17 Kalyan Prasad Tatavarthi CLA 2019-05-28 05:46:27 EDT
Please set the target milestone back to 4.12 if you still intend to fix this for 4.12.
Comment 18 Patrik Suzzi CLA 2019-12-05 01:58:35 EST
The below points are still actual and need to be fixed.

- beeps on second press of Ctrl+E
- after opening Ctrl+E, pressing Ctrl+Shift+E should scroll backwards, like in other element switchers
- Tab / Shift+Tab should put focus in filter field like in other quick views
Comment 19 Eclipse Genie CLA 2021-11-27 12:59:41 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.ui/+/188211
Comment 20 Fabian Pfaff CLA 2021-11-27 13:02:37 EST
Ctrl+Shift+E is already bound to "Switch to Editor".
Is there a way to make the key binding contextual or do we have to use another key binding?

I didn't even know the "Switch to Editor" dialog existed.
"Switch to Editor" seems to be broken in my environment when my focus is on an editor window. The dialog opens as expected when my focus is on the package explorer.