Community
Participate
Working Groups
I would like to customize the reconciler of the generic editor (note, not the PresentationREconciler, but the regular Reconciler), in order to switch off spell checking explicitly for specific editors. Usually I would do this by providing a specific TextSourceViewerConfiguration that overrides the getReconciler method. I could still do that with for a generic editor, but I would have to subclass it. Would be much nicer if I could configure that via an extension, in a similar way than it is implemented for the presentation reconciler.
> in order to switch off spell checking explicitly for specific editors. The spell-checker is disabled by default (bug 513314 ) Can you elaborate of some other use-case you have for reconcilers? Is there any of these that cannot be achieved with documentListener and documentSetupParticipant extension point? Examples would be important here as the reconcilers aren't clearly specified and are a bit of a "wildcard extension" that IMO should be used as little as possible in favor of more scoped extensions. > Would be much nicer if I could configure that via an extension, in a similar way than it is implemented for the presentation reconciler. +1. I've figured out a case recently that I believe cannot be done without extensible reconcilers (or without creating a new API, that is something we need to avoid): folding (bug 512956). So unless there is a better way to do folding -and if you know one, please tell ASAP!- we'll have to create the extension point for reconcilers.
I had the spell checker use case in mind and no other use cases in addition to that. Sorry, no additional requirements here... :-)
(In reply to Martin Lippert from comment #2) > I had the spell checker use case in mind and no other use cases in addition > to that. Sorry, no additional requirements here... :-) You don't have to be sorry, it's actually the best answer I was hoping ;)
New Gerrit change created: https://git.eclipse.org/r/101429
Proposed patch seems very close to be merged soon. Once this is done, it's important to add a note about it in the documentation, in the News and Noteworthy page and in the PDE template.
Gerrit change https://git.eclipse.org/r/101429 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=798ba99e71d97835741ac91d068afc2130c66bcc
New Gerrit change created: https://git.eclipse.org/r/101673
New Gerrit change created: https://git.eclipse.org/r/101674
New Gerrit change created: https://git.eclipse.org/r/101686
Gerrit change https://git.eclipse.org/r/101686 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=e43e81a4da43b601a90bf0d6b494c157230f1621
Gerrit change https://git.eclipse.org/r/101673 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=1af8e5eb25ee42863e43a8e77d9fd74feeaaeca4
Gerrit change https://git.eclipse.org/r/101674 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=2ff2a5d86a247dfe76235cb06e0f0d24b154b55c
Lucas, AFAIK the N&N contains errors. Can you run the HTML document though https://validator.w3.org/check can correct it?
New Gerrit change created: https://git.eclipse.org/r/101825
You are correct Lars. There was a closing p tag with no opening one. Fix applied in patch above.
Gerrit change https://git.eclipse.org/r/101825 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=77f890dce43e1c12f083e94f57c6bc2080da4938
I think we're done here. Remaining (minor) issues are tracked in separate tickets. Thanks a lot Lucas for this good contribution, and for taking care of doc and PDE by the way!
