Community
Participate
Working Groups
Created attachment 264345 [details] New color screenshot Currently color for highlighting search results results in unreadable text. I suggest to change it to a better color. My current suggestion would be to set org.eclipse.search.ui.match.highlight to 206,92,0. Screenshots attached.
Created attachment 264346 [details] Old hightlight color
New Gerrit change created: https://git.eclipse.org/r/81685
Adding a few people interested in the dark theme. If nobody objects or suggests a better color, I merge this in a few days.
New Gerrit change created: https://git.eclipse.org/r/81688
Created attachment 264347 [details] blue highlighting color
Hi Lars, it looks like on my end, my highlighting color is actually blue, but both the color of our highlighting search results is the same off-white color. It might not be best to set the org.eclipse.search.ui.match.highlight to the static color of 206,92,0 in this case. I tried checking on preferences for why mine highlights to blue instead of the orange on your workspace, but I couldn't find anything custom.
(In reply to Ian Pun from comment #6) > Hi Lars, it looks like on my end, my highlighting color is actually blue, > but both the color of our highlighting search results is the same off-white > color. It might not be best to set the org.eclipse.search.ui.match.highlight > to the static color of 206,92,0 in this case. I tried checking on > preferences for why mine highlights to blue instead of the orange on your > workspace, but I couldn't find anything custom. My change should not affect the "active selection color" but on the other color. In your screenshot it is used in line 18, 35, 41 and makes the matching result not readable. Can you try the patch to see the result?
(In reply to Lars Vogel from comment #7) > (In reply to Ian Pun from comment #6) > > Hi Lars, it looks like on my end, my highlighting color is actually blue, > > but both the color of our highlighting search results is the same off-white > > color. It might not be best to set the org.eclipse.search.ui.match.highlight > > to the static color of 206,92,0 in this case. I tried checking on > > preferences for why mine highlights to blue instead of the orange on your > > workspace, but I couldn't find anything custom. > > My change should not affect the "active selection color" but on the other > color. In your screenshot it is used in line 18, 35, 41 and makes the > matching result not readable. Can you try the patch to see the result? I gave the patch a go and it didn't seem to fix the issue as I am still seeing the bad highlighting. I even created a new workspace to see if that was the issue but it is not setting the color at all. Any suggestions?
(In reply to Ian Pun from comment #8) > I gave the patch a go and it didn't seem to fix the issue as I am still > seeing the bad highlighting. I even created a new workspace to see if that > was the issue but it is not setting the color at all. Any suggestions? I tested on my second workstation and indeed the patch does not work. I will investigate.
(In reply to Ian Pun from comment #8) > I gave the patch a go and it didn't seem to fix the issue as I am still > seeing the bad highlighting. Any suggestions? EGit is overriding this setting because of Bug 466075. Can you test the patch without EGit in your runtime configuration?
Created attachment 264466 [details] New Search Highlight Coloro in Mac The new color looks good on mac. See my screenshot
(In reply to Matthias Becker from comment #11) > The new color looks good on mac. See my screenshot Thanks Matthias. Ian, do you still see problems with the change? If not, I plan to merge it tomorrow.
(In reply to Lars Vogel from comment #12) > (In reply to Matthias Becker from comment #11) > > The new color looks good on mac. See my screenshot > > Thanks Matthias. Ian, do you still see problems with the change? If not, I > plan to merge it tomorrow. Can confirm this works without egit in run configuration. Go ahead with the merge!
Gerrit change https://git.eclipse.org/r/81685 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=09c1ac42b00d3e3f8520073d1ece33e82476a899
Thanks for the patch Lars! Also, is there any fix to the highlighting if we do happen to use egit?
Gerrit change https://git.eclipse.org/r/81688 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=baf26f1be0056e92392c490d41c48df9c311a7e0
We first fix things and then announce them. I'll remove this item from the M3 N&N, since it's not worth wasting our readers' time until it works.
(In reply to Markus Keller from comment #17) > We first fix things and then announce them. Bug 466075 is not specific to this development, it affects all preference styling, e.g, the JDT code editor styling. This development works fine, similar to the JDT code styling or other styling. I'll remove this item from the > M3 N&N, since it's not worth wasting our readers' time until it works. -1, please see above commend.
Users don't care why something doesn't work. It just doesn't work and that gives the whole project a bad reputation.
(In reply to Markus Keller from comment #19) > Users don't care why something doesn't work. It just doesn't work and that > gives the whole project a bad reputation. I completely agree. Unfortunately that is how the CSS engine was implemented by Daniel Rolka. So I have to assume this is works as designed until we redesign the preference CSS styling engine via Bug 466075.
New Gerrit change created: https://git.eclipse.org/r/94324
Gerrit change https://git.eclipse.org/r/94324 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=59de15fd6e532bddd353eec0f7cde9afd4b9c229
