501597 – [Model] Support new trimbars for Part and Perspective in e4 model editor

Bug 501597 - [Model] Support new trimbars for Part and Perspective in e4 model editor

Summary: [Model] Support new trimbars for Part and Perspective in e4 model editor

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.6
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	4.15 M3
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:	501573
Blocks:
	Show dependency tree

Reported:	2016-09-16 08:12 EDT by Lars Vogel
Modified:	2020-02-04 11:17 EST (History)
CC List:	6 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2016-09-16 08:12:59 EDT

+++ This bug was initially created as a clone of Bug #501573 +++

Once we fix Bug 501573, we should extend the e4 tools editor.

Comment 1 Eclipse Genie

2019-11-19 04:43:51 EST Comment hidden (obsolete)

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 2 Lars Vogel

2019-11-19 04:46:34 EST

Benedikt, something for you?

Comment 3 Benedikt Kuntz

2019-12-06 04:19:59 EST

Maybe it would be a good idea to have a mixin interface (something like "MTrimmed") for the elements having trim bars... Otherwise there is a lot of overhead for the separate virtual editors.
And all in all, this is another good reason for implementing bug 552639 ;)

Comment 4 Eclipse Genie

2019-12-06 04:22:47 EST

New Gerrit change created: https://git.eclipse.org/r/153973

Comment 5 Lars Vogel

2020-01-23 09:40:03 EST

Benedikt, AFAICS the default renderer does not yet support these new model elements. Do you see the same? If yes, can you open a new bug for the adjustment of the renderer?

Comment 6 Benedikt Kuntz

2020-02-04 10:27:16 EST

Sorry for the late response, but I cannot see any differences between the "standard" Part and a Part containing a Trimbar...

Comment 7 Benedikt Kuntz

2020-02-04 10:30:15 EST

I think the bug concerning the renderer is Bug 507394?

Comment 8 Eclipse Genie

2020-02-04 11:16:51 EST

Gerrit change https://git.eclipse.org/r/153973 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=133c3e75ee94b95a1afd15e04c2f2e35fa5856d4

Comment 9 Lars Vogel

2020-02-04 11:17:05 EST

(In reply to Benedikt Kuntz from comment #7)
> I think the bug concerning the renderer is Bug 507394?

Thanks, Benedikt. Could you test the patch from Bug 507394?