501573 – [Model] Extend application model to allow trimbars for views and perspectives

Bug 501573 - [Model] Extend application model to allow trimbars for views and perspectives

Summary: [Model] Extend application model to allow trimbars for views and perspectives

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.6
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	4.7 M3
Assignee:	Lars Vogel
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:
Blocks:	501597
	Show dependency tree

Reported:	2016-09-16 05:41 EDT by Lars Vogel
Modified:	2019-12-06 04:46 EST (History)
CC List:	5 users (show)

See Also:	497814 Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Lars Vogel

2016-09-16 05:41:50 EDT

Split of from Bug 497814 for the final conclusing of this. From https://bugs.eclipse.org/bugs/show_bug.cgi?id=497814#c9

Quoting Tom:
---------
I would give MPerspective also TrimAreas ;-) In RCPs it is quite usual that the ToolBar between Perspectives has no item in common hence it is currently a lot of overhead to add visibleWhen clauses just to swap out all items.

We then have 3 Model-Elements holding MTrims:
- MWindow
- MPart
- MPerspective
---------

This bug is for the relevant model changes. Changes in the renderer implementation and the e4 model editor should be handled by separate bugs.

Comment 1 Lars Vogel

2016-09-16 07:37:18 EDT

(In reply to Lars Vogel from comment #0)
 
I think Tom had a small error here:
> We then have 3 Model-Elements holding MTrims:
> - MWindow
....
> ---------

Correct would be:

We then have 3 Model-Elements holding MTrims:
- MTrimmedWindow
- MPart
- MPerspective
---------

Comment 2 Eclipse Genie

2016-09-16 07:38:40 EDT

New Gerrit change created: https://git.eclipse.org/r/81232

Comment 3 Eclipse Genie

2016-09-19 03:44:49 EDT

Gerrit change https://git.eclipse.org/r/81232 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=3e72adb11fc225ec89d022c123bb1c2e51600856

Comment 4 Eclipse Genie

2016-09-19 04:47:51 EDT

New Gerrit change created: https://git.eclipse.org/r/81311

Comment 5 Eclipse Genie

2016-09-19 04:49:02 EDT

Gerrit change https://git.eclipse.org/r/81311 was merged to [master].
Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=3272a1d2eed98d9cd6debeb21606e76d74b7647c

Comment 6 Eclipse Genie

2019-12-06 04:16:16 EST

New Gerrit change created: https://git.eclipse.org/r/153972

Comment 7 Benedikt Kuntz

2019-12-06 04:24:12 EST

Sorry, pushed for wrong bug This was intended for follow-up bug 501597.

Comment 8 Lars Vogel

2019-12-06 04:36:27 EST

(In reply to Benedikt Kuntz from comment #7)
> Sorry, pushed for wrong bug This was intended for follow-up bug 501597.

Sorry to hear, I'm delivering a RCP this week and the participants were really happy about this new upcoming functionality. :-)

Comment 9 Benedikt Kuntz

2019-12-06 04:46:26 EST

(In reply to Lars Vogel from comment #8)
> 
> Sorry to hear, I'm delivering a RCP this week and the participants were
> really happy about this new upcoming functionality. :-)

The functionality is still there, just moved the patch set here: https://git.eclipse.org/r/153973 ;)