Bug 498301 - Ctrl+C is broken in the About dialog
Summary: Ctrl+C is broken in the About dialog
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.7 M1   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 496319
Blocks:
  Show dependency tree
 
Reported: 2016-07-21 12:50 EDT by Markus Keller CLA
Modified: 2016-08-03 11:22 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2016-07-21 12:50:04 EDT 
In the About dialog, Ctrl+C always copies some static information. This is a regression in 4.7.

The standard behavior of the Copy (Ctrl+C) command is to copy the selection, and the About dialog has to respect that convention.

You can add a separate "Copy Build ID Information" command to the context menu.

BTW: The context menu already contains a "Copy (Ctrl+C)" command which at least allows the user to copy the selection, but which lies about its shortcut.
Comment 1 Lars Vogel CLA 2016-07-21 13:09:48 EDT 
I agree with Markus, Bug 496319 does break the existing copy and paste. Patrik, I suggest to revert the change. Maybe we should rather add a button to the About dialog for copying the build information?
Comment 2 Patrik Suzzi CLA 2016-07-26 11:06:03 EDT 
I plan to solve this by unlinking Ctrl+C in about dialog, 
and adding a button to copy build information.
Comment 3 Dani Megert CLA 2016-07-26 11:15:41 EDT 
(In reply to Patrik Suzzi na until 0108 from comment #2)
> I plan to solve this by unlinking Ctrl+C in about dialog, 
No, Ctrl+C must copy he selection as it did before.

> and adding a button to copy build information.
-1. That is definitely overkill.
Comment 4 Markus Keller CLA 2016-08-02 10:08:41 EDT 
Patrick, please revert the regression for M1.
Comment 5 Eclipse Genie CLA 2016-08-02 11:41:43 EDT 
New Gerrit change created: https://git.eclipse.org/r/78335
Comment 6 Eclipse Genie CLA 2016-08-02 12:33:23 EDT 
New Gerrit change created: https://git.eclipse.org/r/78340
Comment 7 Patrik Suzzi CLA 2016-08-02 12:38:55 EDT 
(In reply to Markus Keller from comment #4)
> Patrik, please revert the regression for M1.

Fixed with the below changes: 
https://git.eclipse.org/r/78335 : reverts + adds a context menu
https://git.eclipse.org/r/78340 : updates the N&N

I can merge the first change to master, as it is on Platform project. 
I can not merge the second change as it is on news. 

Would you mind reviewing the second one?
Comment 10 Patrik Suzzi CLA 2016-08-02 14:31:06 EDT 
(In reply to Patrik Suzzi from comment #7)
> Would you mind reviewing the second one

Already merged, thanks anyway!
Comment 11 Markus Keller CLA 2016-08-03 11:22:56 EDT 
Verified in I20160802-2000 and removed unused NLS strings with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=67c1c75debc6377e84ece04c9fb2d90d8c103cfd