Community
Participate
Working Groups
We have Ctrl+3 following by "Copy Build id into the clipboard". Other IDEs makes that smarter. If you open the "About" dialog you can copy the Build ID via Ctrl+C. I suggest to add this to our about dialog also.
Patrik, can you take this one?
If possible it should include the product name and the version, like: Eclipse SDK Version: Neon (4.6) Build id: I20160524-2000
I'll work on this. It seems feasible. In org.eclipse.ui\plugin.xml, I observed that "M1+C" is assigned to the command "org.eclipse.ui.edit.copy", within context "org.eclipse.ui.contexts.dialogAndWindow". No scope is assigned. To fix this, I see two possible ways: (1.) Add another "M1+C" bindings in dialogAndWindow, under a different scope. Then hook the command org.eclipse.ui.ide.copyBuildIdCommand. In this case I'm going to re-use the copyBuildId command, and I will edit is so that will return three lines (Product, Version, BuildId). (2.) A second, more direct way: Avoid dealing with Binding infrastructure, and directly listen to SWT.KeyDown in the dialog I think that, Ideally, I should go for (1.) ; But eventually I'll implement the (2.) as it is more direct and will avoid possible troubles within AboutDialog. It will be good to - have feedback - know if there are similar cases that we can consider "best-practices". Thanks and Regards.
(In reply to Patrik Suzzi from comment #3) > I'll work on this. It seems feasible. > > In org.eclipse.ui\plugin.xml, I observed that "M1+C" is assigned to the > command "org.eclipse.ui.edit.copy", within context > "org.eclipse.ui.contexts.dialogAndWindow". No scope is assigned. I would suggest to use the binding infrastructure. A user might have bound Ctrl+X to another key.
(In reply to Patrik Suzzi from comment #3) > - know if there are similar cases that we can consider "best-practices". I used EGit as model, as reused Ctrl+C for org.eclipse.egit.ui.RepositoriesViewCopyPath (In reply to Lars Vogel from comment #4) > I would suggest to use the binding infrastructure. A user might have bound > Ctrl+X to another key. Perfect, this is my plan: - edit CopyBuildIdToClipboardHandler, so it will copy three lines - keep org.eclipse.ui.ide.copyBuildIdCommand as is now. - add M1+C binding to the command with a new context org.eclipse.ui.AboutDialog - activate the context when about Dialog is active The only unclear point is: how to activate the new context in a Legacy dialog. -> I'm currently investigating this, then I can proceed. ( Any suggestion would be useful :)
(In reply to Patrik Suzzi from comment #5) > The only unclear point is: how to activate the new context in a Legacy > dialog. > -> I'm currently investigating this, then I can proceed. I'll follow doc guidelines #1, Getting context instance via singleton: IContextService contextService = (IContextService)PlatformUI.getWorkbench() .getService(IContextService.class); [#1] http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fguide%2Fworkbench_advext_contexts.htm
New Gerrit change created: https://git.eclipse.org/r/75658
With the proposed change, the copyBuildId is now extended, and Ctrl+C will trigger the command, only when the AboutDialog is active. see: http://i.imgur.com/o1Sapp7.gifv
Created attachment 262595 [details] Analysus of the problem and description of the approach.
Gerrit change https://git.eclipse.org/r/75658 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c1aa656c39e929445847dbe6d180c8b653b8142f
Adding also News and Noteworthy for the feature
New Gerrit change created: https://git.eclipse.org/r/75961
To make it more useful, I suggest to add the GTK version, if invoked on Linux. Patric, what do you think?
(In reply to Lars Vogel from comment #13) > To make it more useful, I suggest to add the GTK version, if invoked on > Linux. Patric, what do you think? Also the OS system? I think that would be useful for bug triage.
(In reply to Lars Vogel from comment #14) > (In reply to Lars Vogel from comment #13) > > To make it more useful, I suggest to add the GTK version, if invoked on > > Linux. Patric, what do you think? > > Also the OS system? I think that would be useful for bug triage. It is a great Idea! For Linux, I suggest to report also the version of libwebkitgtk. Adding Alex in c/c as he might be interested.
New Gerrit change created: https://git.eclipse.org/r/76002
(In reply to Eclipse Genie from comment #16) > New Gerrit change created: https://git.eclipse.org/r/76002 After last change, This is a sample of the Ctrl+C result in three different systems: Eclipse SDK Version: Neon (4.6) Build id: I20160606-1100 OS: Mac OS X, v.10.11.5, x86_64 / cocoa Eclipse SDK Version: Neon (4.6) Build id: I20160606-1100 OS: Linux, v.4.4.0-24-generic, x86_64 / gtk,v. 3.18.9 Eclipse SDK Version: Neon (4.6) Build id: I20160606-1100 OS: Windows 10, v.10.0, x86_64 / win32 Note: I was not able to get the libwebkitgtk used, as for this is required to deal directly with the O.S.
Looks great but I suggest to drop the ,v. in the the Gtk info. So only: "gtk 3.18.9" instead of "gtk,v. 3.18.9".
Ok. See also Bug 496854
Gerrit change https://git.eclipse.org/r/76002 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0f0d8b4f63b7b569f675138bde11bc576f14d9b9
Gerrit change https://git.eclipse.org/r/75961 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=cde9586af450df16120423fda9aab7b8c3ce22ab
Reopen to fix a minor bug: the id in the N&N: The id below should be edited to remove the last character (last hypen) ctrl-c-binding-to-copy-build-information-in-about-dialog-
New Gerrit change created: https://git.eclipse.org/r/76322
Gerrit change https://git.eclipse.org/r/76322 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=2d003a4942b152ed03bb37d063f272f8bac1db21
New Gerrit change created: https://git.eclipse.org/r/76621
Gerrit change https://git.eclipse.org/r/76621 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=ebac197d48c13aca1b3ccd2b08689f6970557702
