Community
Participate
Working Groups
COLOR_INFO constants are used for tooltips drawing (as stated in the javadoc even). As dialogs are supposed to be user interacting it is best to switch to COLOR_LIST_[BACKGROUND|FOREGROUND] as selection colors are also based on the same widget thus inconsistency like white on white, blue on blue by default or when selected will be prevented. Further more this would give a bit more predictable dialog colors in eclipse as some system themes use funky yellow, blue, black tooltip colors (aka COLOR_INFO_*) making these dialogs not integrate well with the workbench.
Created attachment 263130 [details] Inconsistent quick outline dialog.
New Gerrit change created: https://git.eclipse.org/r/77402
Gerrit change https://git.eclipse.org/r/77402 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e7cd5a080e88b2004cbcafc117fe90c9b65d3c10
Can we downport this to 4.6.1?
(In reply to Lars Vogel from comment #4) > Can we downport this to 4.6.1? -1. The visual change is too big for that. I would at least wait for 4.6.2 or even 4.6.3 with that.
New Gerrit change created: https://git.eclipse.org/r/79328
Created attachment 263668 [details] Javadoc popup still looks misplaced Unfortunately the Javadoc popup still looks bad. Not sure if it should be affected by this change.
(In reply to Lars Vogel from comment #7) > Created attachment 263668 [details] > Javadoc popup still looks misplaced > > Unfortunately the Javadoc popup still looks bad. Not sure if it should be > affected by this change. That's a different thing.
(In reply to Dani Megert from comment #8) > That's a different thing. Is there a separate bug for the Javadoc popup?
(In reply to Sergey Prigogin from comment #9) > (In reply to Dani Megert from comment #8) > > That's a different thing. > > Is there a separate bug for the Javadoc popup? The Javadoc issue will be slightly alleviated by the fix for bug 477950. In general I think a fix for the Javadoc issue should be similar to this one: perhaps make the Javadoc popup use the same colors as the editors. The tooltip colors work well for things with a white foreground and a black background. This color scheme is ideal for short pieces of information. Once you start having large groups of text (not all white, some of it dark blue, etc.) it gets a bit difficult to read. It's also worth mentioning that the Javadoc popup isn't strictly a tooltip, it's a Browser widget.
(In reply to Eric Williams from comment #10) Javadoc popup should probably use the same colors as the Javadoc view.
(In reply to Sergey Prigogin from comment #11) > (In reply to Eric Williams from comment #10) > > Javadoc popup should probably use the same colors as the Javadoc view. Doesn't the Javadoc view use the same COLOR_INFO_* colors as the popup?
(In reply to Eric Williams from comment #12) You're right, it does use COLOR_INFO_* colors, which means that it is affected by this issue together with the Javadoc popup.
(In reply to Sergey Prigogin from comment #13) > You're right, it does use COLOR_INFO_* colors, which means that it is > affected by this issue together with the Javadoc popup. In this case, I think the Javadoc colors should be standard for all Javadoc widgets: the popups, Javadocs view, etc. If the Javadoc popups adopt the same color scheme as the editor then the Javadoc view should as well.
Gerrit change https://git.eclipse.org/r/79328 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=96b2faaf8b6760ee778eca8f321c0cca0820bec6
New Gerrit change created: https://git.eclipse.org/r/79609
(In reply to Sergey Prigogin from comment #9) > (In reply to Dani Megert from comment #8) > > That's a different thing. > > Is there a separate bug for the Javadoc popup? Is was unable to find one and created Bug 500196
(In reply to Eclipse Genie from comment #2) > New Gerrit change created: https://git.eclipse.org/r/77402 4.6.1 is finished, Alex can you prepare the downport Gerrit?
I would appreciate someone taking it as I would not be able to look into it in the next week or even 2.
(In reply to Alexander Kurtakov from comment #19) > I would appreciate someone taking it as I would not be able to look into it > in the next week or even 2. Working on it.
New Gerrit change created: https://git.eclipse.org/r/81499
(In reply to Eclipse Genie from comment #21) > New Gerrit change created: https://git.eclipse.org/r/81499 I don't have commit rights to platform.ui. Could someone please review/merge patch into R6_4? Thanks.
Gerrit change https://git.eclipse.org/r/81499 was merged to [R4_6_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=df057ac34e6919891a9502f0c42f6218a4c41be9
