Bug 497618 - Quick switch editors (Ctrl + E) enhancements: center dialog
Summary: Quick switch editors (Ctrl + E) enhancements: center dialog
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7 M1   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-10 05:04 EDT by Hugh Yang CLA
Modified: 2016-07-19 12:09 EDT (History)
3 users (show)

See Also:


Attachments
Ctrl + E popup dialog appear too far away from the center of the screen. Usability will be much better if it appears on the center of the screen. (481.87 KB, image/png)
2016-07-10 05:04 EDT, Hugh Yang CLA
no flags Details
As contrast, IntelliJ's open recent files shortcut (cmd + e) show the popup dialog on the center of the screen, which help user concentrate on his work (924.64 KB, image/png)
2016-07-10 11:26 EDT, Hugh Yang CLA
no flags Details
Consider supporting searching by capital letters or by substring in Ctrl+E popup (251.83 KB, image/png)
2016-07-12 04:59 EDT, Hugh Yang CLA
no flags Details
IntelliJ's cmd+e popup supports searching by substring, just for reference (823.58 KB, image/png)
2016-07-12 05:30 EDT, Hugh Yang CLA
no flags Details
IntelliJ's cmd+e popup supports searching by capital letters, just for reference (810.83 KB, image/png)
2016-07-12 05:31 EDT, Hugh Yang CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hugh Yang CLA 2016-07-10 05:04:44 EDT
Created attachment 263007 [details]
Ctrl + E popup dialog appear too far away from the center of the screen. Usability will be much better if it appears on the center of the screen.

Ctrl + E is an efficient way to switching between current open editors. I would like to propose two enhancements to improve usability:

1. Make the popup dialog appears on the center of the screen. The current behavior of Ctrl + E opens a popup dialog on the top right section of the screen (just besides the collapse arrow on editor title), user has to move his eyes from the center of the screen to the top right section of the screen in order to see the content of the popup dialog. This is annoying especially when user is busy coding. Make the popup dialog appears on the center of the screen will help user focus on his work. This enhancement is inspired by IntelliJ's open recent files (cmd + o) shortcut, which opens the popup dialog on the center of the screen.


2. Support search by leading uppercase characters, like what is already supported in Open Resources dialog. e.g. search ACAC should find AnnotationConfigApplicationContext
Comment 1 Hugh Yang CLA 2016-07-10 11:26:10 EDT
Created attachment 263010 [details]
As contrast, IntelliJ's open recent files shortcut (cmd + e) show the popup dialog on the center of the screen, which help user concentrate on his work
Comment 2 Patrik Suzzi CLA 2016-07-11 17:24:55 EDT
New Gerrit change created: https://git.eclipse.org/r/#/c/77097/
Comment 3 Patrik Suzzi CLA 2016-07-11 17:27:21 EDT
The proposed change centers horizontally, and put at 1/3rd vertically. 
Please, check see the video and share your feedback: https://www.youtube.com/watch?v=2gn9xdWF6Js
Comment 4 Hugh Yang CLA 2016-07-12 00:02:14 EDT
Thanks Patrik!

One thing I noticed in the video is that the popup dialog centers on the editor section, when Package Explorer/Project Explorer occupies most of the screen estate, the popup dialog is driven to the right side. I feel it looks better and more consistent if the popup dialog centers on the whole window, no matter the proportion of the editor section.
Comment 5 Eclipse Genie CLA 2016-07-12 00:03:27 EDT
New Gerrit change created: https://git.eclipse.org/r/77097
Comment 6 Patrik Suzzi CLA 2016-07-12 02:42:50 EDT
(In reply to Hugh Yang from comment #4)
> Thanks Patrik!
> 
> One thing I noticed in the video is that the popup dialog centers on the
> editor section, when Package Explorer/Project Explorer occupies most of the
> screen estate, the popup dialog is driven to the right side. I feel it looks
> better and more consistent if the popup dialog centers on the whole window,
> no matter the proportion of the editor section.

That was my design decision to have the popup always centered on the working editor. I rarely have the case of a big package explorer and a small editor; but often I work with two editors side-by-side; in this case the popup is centered on the active stack of editors, making the interaction more intuitive. 

WDYT?
Comment 7 Hugh Yang CLA 2016-07-12 04:51:58 EDT
Hi Patrik,

I am ok to have the popup centered on the working editor.

Additionally, what about proposal 2? I often open 40 - 50 editors, if the popup supports searching by capital letters (alternatively, support searching by substring), user can switch to his desired editor more quickly.

- searching by capital letter, e.g. type AC should find ApplicationContext
- searching by substring, like the new content assist feature in Neon, see attachment.
Comment 8 Hugh Yang CLA 2016-07-12 04:59:54 EDT
Created attachment 263042 [details]
Consider supporting searching by capital letters or by substring in Ctrl+E popup
Comment 9 Hugh Yang CLA 2016-07-12 05:24:12 EDT
Just for reference, I just had a look at IntelliJ's cmd+e popup behavior, it supports searching both by capital letters and substring.
Comment 10 Hugh Yang CLA 2016-07-12 05:30:45 EDT
Created attachment 263044 [details]
IntelliJ's cmd+e popup supports searching by substring, just for reference
Comment 11 Hugh Yang CLA 2016-07-12 05:31:50 EDT
Created attachment 263045 [details]
IntelliJ's cmd+e popup supports searching by capital letters, just for reference
Comment 12 Patrik Suzzi CLA 2016-07-12 09:19:51 EDT
(In reply to Hugh Yang from comment #10)
> Created attachment 263044 [details]
> IntelliJ's cmd+e popup supports searching by substring, just for reference

in Eclipse, with Ctrl+E, you can search substring using wildcards. This will give you finer control especially when work with many editors.
Comment 13 Patrik Suzzi CLA 2016-07-12 09:30:17 EDT
Addin Lars in c/c, as he might be interested in this.
Comment 14 Hugh Yang CLA 2016-07-12 10:08:30 EDT
Yes, but I need to type * first in order to trigger substring search.

It would be more convenient if searching by substring is supported directly, and this is also consistent with the new substring code completion feature implemented in Eclipse Neon.

In addition, Ctrl+O (Quick Outline) would also benefit from substring search.

My typical workflow is usually like this: first quickly locate the desired editor with Ctrl+E, then quickly jump to the desired method with Ctrl+O. Type * twice in the process in order to trigger substring search would definitely slow me down.

What do you think?
Comment 15 Lars Vogel CLA 2016-07-12 12:28:09 EDT
(In reply to Patrik Suzzi from comment #13)
> Addin Lars in c/c, as he might be interested in this.

Patrik, do you know the differences between Ctrl+E and Ctrl+F6. Looks to me that both are doing the same. Ctrl+F6 looks much nicer and is already centered. Maybe we should simply re-map Ctrl+E to the same command as Ctrl+F6 and retire the other one?
Comment 16 Hugh Yang CLA 2016-07-12 13:13:26 EDT
Hi Lars,

Please don't replace Ctrl+E with Ctrl+F6. Ctrl+E works much better than Ctrl+F6:

1. When you press Ctrl+F6, and release both keys, it will switch to a different editor. This behavior is far from ideal because user even doesn't have the chance to type anything.

2. Ctrl+F6 doesn't support searching, user has to move the arrow key to select.
Comment 17 Lars Vogel CLA 2016-07-12 13:19:10 EDT
(In reply to Hugh Yang from comment #16)
> Hi Lars,
> 
> Please don't replace Ctrl+E with Ctrl+F6. Ctrl+E works much better than
> Ctrl+F6:

Than we should replace Ctrl+F6 with Ctrl+E. I fail to see why we need two options for the same thing. We should offer one optional way.
Comment 18 Hugh Yang CLA 2016-07-12 22:54:20 EDT
Hi Lars,

Maybe Ctrl+F6 is useful to switch back and forth between two editors, while Ctrl+E is super useful to locate desired editor in a lot of editors.

Would you consider enhancing Ctrl+E's search experience (substring matching, capital letters matching, etc) ? 

Thanks.
Comment 19 Patrik Suzzi CLA 2016-07-14 17:51:12 EDT
(In reply to Lars Vogel from comment #15)
> 
> (...) Ctrl+E and Ctrl+F6. Looks to me that both are doing the same. 
> (...) Maybe we should simply re-map Ctrl+E to the same command as
> Ctrl+F6 and retire the other one?

Ctrl+E is more intuitive, Ctrl+F6 looks nicer. They do the same: choosing one of the editor tabs. 

As discussed we should enhance Ctrl+E "filtered" dialog and make it the default. We should also retire the Ctrl+E binding in favor of Ctrl+F6

For this, please see Bug 497937 

(In reply to Hugh Yang from comment #18)
> 
> Would you consider enhancing Ctrl+E's search experience (substring matching,
> capital letters matching, etc) ? 

Yes, great idea1 please see Bug 497938 

Note: 
- I'm creating new bugs to manage growing complexity and have manageable size bugs. 
- I'm gooing to add you both in c/c to the mentioned bugs.
Comment 20 Hugh Yang CLA 2016-07-14 22:35:55 EDT
Thanks Patrik!
Comment 22 Patrik Suzzi CLA 2016-07-19 12:09:51 EDT
Ctrl+E centered dialog is now merged into master. 

Follows up are Bug 497937 and Bug 497938