Bug 497937 - Replace Ctrl+F6 legacy dialog with Ctrl+E filtered dialog
Summary: Replace Ctrl+F6 legacy dialog with Ctrl+E filtered dialog
Status: CLOSED DUPLICATE of bug 368977
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Windows 10
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-14 17:34 EDT by Patrik Suzzi CLA
Modified: 2016-12-07 10:33 EST (History)
4 users (show)

See Also:


Attachments
Ctrl+F6 and Ctrl+Shift+F6 (447.98 KB, image/png)
2016-07-15 09:57 EDT, Hugh Yang CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Patrik Suzzi CLA 2016-07-14 17:34:18 EDT
The Ctrl+E and Ctrl+F6 bindings are triggering similar dialogs, to choose one between open editor tabs. 

The Ctrl+E "filtered" (Intelli-J style) dialog is persistent after releasing the Ctrl key, and you can filter the list with text and wildcards. 

The Ctrl+F6 "legacy" can only cycle between opened editor tabs, but the dialog disappears when releasing the Ctrl key. It is not intuitive. 

We should
- bind Ctrl-F6 to the same command that triggers the "filtered" dialog. 
- remove the Ctrl+E binding (exactly the same as in Intelli-J)

And, if not API,
- remove the extra code related to the "legacy" dialog.
Comment 1 Lars Vogel CLA 2016-07-14 17:41:49 EDT
+1
Comment 2 Lars Vogel CLA 2016-07-14 17:42:30 EDT
Even though I would not yet remove Ctrl+E binding...  People might be used to it.
Comment 3 Hugh Yang CLA 2016-07-14 22:33:31 EDT
Hi Patrik,

Please don't remove Ctrl+E binding. Ctrl+E binding is much easier to hit than Ctrl+F6. For me, Ctrl+F6 is difficult to press because I have to look at the keyboard to find the F6 key. People like me might already develop the habit of using Ctrl+E to switch editors.
Comment 4 Patrik Suzzi CLA 2016-07-15 06:32:05 EDT
(In reply to Hugh Yang from comment #3)
> Hi Patrik,
> 
> Please don't remove Ctrl+E binding. Ctrl+E binding is much easier to hit
> than Ctrl+F6. For me, Ctrl+F6 is difficult to press because I have to look
> at the keyboard to find the F6 key. People like me might already develop the
> habit of using Ctrl+E to switch editors.

I think is confusing using two different bindings for the same command. 
I agree with you that is easier pressing Ctrl+E. 

I'd vote for keeping Ctrl+F6, as the shortcut is there since a long time and it is connected to Ctrl+F7 (switch perspective)

Adding also Dani in c/c as he might be interested as well.
Comment 5 Hugh Yang CLA 2016-07-15 06:46:07 EDT
Maybe we can just leave Ctrl+F6 there as it is, as Ctrl+F6 style of switching editors is consistent with Ctrl+F7 (switching views) and Ctrl+F8 (switching perspective).
Comment 6 Hugh Yang CLA 2016-07-15 09:57:00 EDT
Created attachment 263127 [details]
Ctrl+F6 and Ctrl+Shift+F6

Just had a look at eclipse help manual, it indicates Ctrl+F6 and Ctrl+Shift+F6 can be used together:

Ctrl+F6: Next Editor
Ctrl+Shift+F6: Previous Editor
Ctrl+F7: Next View
Ctrl+Shift+F7: Previous View
Ctrl+F8: Next Perspective
Ctrl+Shift+F8: Previous Perspective

Although I use Ctrl+F6 rarely, I think we can just leave it there since it is in accordance with Ctrl+F7 and Ctrl+F8.
Comment 7 Patrik Suzzi CLA 2016-08-12 08:56:10 EDT
Eclipse 3.x had a strong distinction between Editor and Views

- Ctrl(+Shift)+F6: switch between all editors in the current perspective
- Ctrl(+Shift)+F7: switch between all views in the current perspective
- Ctrl(+Shift)+F7: switch between perspectives

Eclipse 4.x allows also putting Views in the central part stack (Editor area)

- Ctrl+(Shift)+E: switch between all editor/views in the current part stack, using a text to filter among the items to select.

And, note there is also another binding to switch between tabs

- Ctrl+PagUp(PagDown): switch next (previous) tab in any TabFolder, so it is not limited to Parts (editors/views)

All the above commands are covering different areas and are not replaceable each other. Hence, I'm closing this bug as wontfix.
Comment 8 Markus Keller CLA 2016-12-07 10:33:49 EST
The WONTFIX was overthrown a few weeks later, see bug 368977 and its dependency tree of regressions.

*** This bug has been marked as a duplicate of bug 368977 ***