Bug 496780 - Bug201002TreeViewerTest.testBug201002 fails on Gerrit
Summary: Bug201002TreeViewerTest.testBug201002 fails on Gerrit
Status: CLOSED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ian Pun CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 496860 (view as bug list)
Depends on: 489025 495909
Blocks:
  Show dependency tree
 
Reported: 2016-06-26 02:57 EDT by Andrey Loskutov CLA
Modified: 2016-06-29 17:14 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Loskutov CLA 2016-06-26 02:57:02 EDT 
See latest builds on platform ui gerrit instance, all starting from

https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9645/
...
https://hudson.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/9652/

junit.framework.AssertionFailedError: expected:<true> but was:<false>
	at junit.framework.Assert.fail(Assert.java:57)
	at junit.framework.Assert.failNotEquals(Assert.java:329)
	at junit.framework.Assert.assertEquals(Assert.java:78)
	at junit.framework.Assert.assertEquals(Assert.java:174)
	at junit.framework.Assert.assertEquals(Assert.java:181)
	at junit.framework.TestCase.assertEquals(TestCase.java:341)
	at org.eclipse.jface.tests.viewers.Bug201002TreeViewerTest.testBug201002(Bug201002TreeViewerTest.java:169)

The failing assertion is:
assertEquals(true, getTreeViewer().getTree().getTopItem() != getTreeViewer().getTree().getItem(0));
Comment 1 Andrey Loskutov CLA 2016-06-26 03:01:21 EDT 
Probably caused by fix for bug 489025, see https://git.eclipse.org/r/75946, but I don't see how.
Comment 2 Leo Ufimtsev CLA 2016-06-27 09:37:36 EDT 
hmm, could be since it changes how icons are handled. Let me investigate.
Comment 3 Leo Ufimtsev CLA 2016-06-27 10:24:33 EDT 
(In reply to Andrey Loskutov from comment #1)
> Probably caused by fix for bug 489025, see https://git.eclipse.org/r/75946,
> but I don't see how.

Thanks for submitting issue and pointing this out Andrey. 
I did a bisect and found that this guy broke the jUnit:
Bug 495909 - [GTK3.20+] test_setTopItemLorg_eclipse_swt_widgets_TreeItem() fails 

We will revert(shortly) /investigate why that fix broke the jUnit.
Comment 4 Andrey Loskutov CLA 2016-06-28 03:20:34 EDT 
*** Bug 496860 has been marked as a duplicate of this bug. ***
Comment 5 Leo Ufimtsev CLA 2016-06-29 17:14:36 EDT 
This should now be resolved as relevant patch was reverted in SWT.
(Please reopen this bug if the issue still occurs).