Bug 495909 - [GTK3.20+] test_setTopItemLorg_eclipse_swt_widgets_TreeItem() fails
Summary: [GTK3.20+] test_setTopItemLorg_eclipse_swt_widgets_TreeItem() fails
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.7 M1   Edit
Assignee: Ian Pun CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
: 74739 202392 490240 (view as bug list)
Depends on:
Blocks: 461354 496780
  Show dependency tree
 
Reported: 2016-06-10 14:36 EDT by Eric Williams CLA
Modified: 2016-11-02 22:18 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Williams CLA 2016-06-10 14:36:21 EDT 
On GTK3.20 and above, test_setTopItemLorg_eclipse_swt_widgets_TreeItem() fails.
Comment 1 Eclipse Genie CLA 2016-06-13 14:50:54 EDT 
New Gerrit change created: https://git.eclipse.org/r/75178
Comment 3 Eric Williams CLA 2016-06-23 14:15:38 EDT 
(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/75178 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=7e5f98bb2b5f6f1dadb9ec6a9723c4817caab045

In master now, thanks for the patch Ian. AllNonBrowser JUnit tests back to passing on all versions of GTK.
Comment 4 Eclipse Genie CLA 2016-06-27 07:02:25 EDT 
New Gerrit change created: https://git.eclipse.org/r/75997
Comment 6 Leo Ufimtsev CLA 2016-06-27 10:23:08 EDT 
This patch broke:
Bug 496780 - Bug201002TreeViewerTest.testBug201002 fails on Gerrit 

We should revert/investigate.
Comment 7 Eclipse Genie CLA 2016-06-27 10:37:58 EDT 
New Gerrit change created: https://git.eclipse.org/r/76014
Comment 9 Eric Williams CLA 2016-06-27 10:47:39 EDT 
(In reply to Eclipse Genie from comment #8)
> Gerrit change https://git.eclipse.org/r/76014 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=c1aa36436e881ddc20f54147fbf3ead08989f297

I've reverted the fix for now, Ian will investigate.
Comment 10 Eclipse Genie CLA 2016-06-28 11:54:52 EDT 
New Gerrit change created: https://git.eclipse.org/r/76144
Comment 12 Eric Williams CLA 2016-07-06 15:16:49 EDT 
(In reply to Eclipse Genie from comment #11)
> Gerrit change https://git.eclipse.org/r/76144 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=a5877a53231f7c5c335c58415c50611fa5ff1b59

In master now. Adds a regression test and fixes the failing Platform UI test case. Thanks for the patch Ian!
Comment 13 Leo Ufimtsev CLA 2016-07-07 09:56:30 EDT 
It's always nice to see junits being fixed. Thanks for the patch.
Comment 14 Eric Williams CLA 2016-10-18 12:05:18 EDT 
*** Bug 74739 has been marked as a duplicate of this bug. ***
Comment 15 Eric Williams CLA 2016-10-18 12:06:02 EDT 
*** Bug 202392 has been marked as a duplicate of this bug. ***
Comment 16 Marc-André Laperle CLA 2016-11-02 22:18:31 EDT 
*** Bug 490240 has been marked as a duplicate of this bug. ***