Community
Participate
Working Groups
+++ This bug was initially created as a clone of Bug #467744 +++ Every year we take time to thank people in the Eclipse community who have helped us during the release. The file to update this year is development/acknowledgements_4_6.php in http://git.eclipse.org/c/www.eclipse.org/eclipse.git Please attach a patch or text if you don't have commit rights on that file (but I think all project leads to). Here is the 4.5 acknowledgments page as a reference: http://www.eclipse.org/eclipse/development/acknowledgements_4_5.php I have "primed" the content in the 4.6 version by leaving in the substance as comments, but left the paragraphs that begin with "such and such team would like to thank ...". I have combined some components (UI and Text) to reflect their current grouping. As you complete your section, please remove the comment of old content. Since this is a web page, we could technically update at any time. But let's set a self-imposed deadline of June 15 for your FINAL version. That is after RC4 (final) deliverable and one week before the overall release which should give time for questions and review. But please do not put it off entirely until after RC4. Incremental progress is always best. :) Over next week or two, I'll work on getting some "commit reports" from Git, for both "Active Committers" and "Active Community Authors" (Just to make sure we don't miss mentioning anyone) and then ask you (project leads) to review and modify as appropriate. To cross-reference, the bug where we drove this process last year is bug 467744.
(In reply to David Williams from comment #0) > Here is the 4.5 acknowledgments page as a reference: > http://www.eclipse.org/eclipse/development/acknowledgements_4_5.php > https://www.eclipse.org/eclipse/development/acknowledgements_4.5.php
Added acknowledgements for JDT/UI: https://www.eclipse.org/eclipse/development/acknowledgements_4.6.php
Updated Acknowledgements for Platform Ant, Debug and JDT Debug.
Added acknowledgements for Platform Resources: http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=563837125ad96bd028457cbb05fd5cd63e91b2c9
JDT Core added via http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=962f2167277546f7b0d23833e63f8af43c42ee59
NOTE: If you have committers on your AKN, then please remove them. They are all listed at the end of the document.
JDT Core modified by removing the name of the committers- except the names of two who received the committer status only last week. http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=0b834a744cb9cf40e5b2b1deb78064eb579c4d03
Project leads, please also make sure that all your active committers are listed.
(In reply to Manoj Palat from comment #7) > JDT Core modified by removing the name of the committers- except the names > of two who received the committer status only last week. > http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/ > ?id=0b834a744cb9cf40e5b2b1deb78064eb579c4d03 It seems there is a typo in the name of one of the new JDT Core committers - Till's last name misses one 'c' compared to the author field in the Git history. It would be bad to release with a typo in the name, so could you please double check what is the right spelling and update the file accordingly? Thanks.
(In reply to Szymon Ptaszkiewicz from comment #9) > (In reply to Manoj Palat from comment #7) > > It seems there is a typo in the name of one of the new JDT Core committers - http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=7b3b37cbb55c45589a21457f1ee21e7bf463c6ab Thanks Szymon. Corrected and added to committer's list. Added missing committers as well.
Updated the list of active Platform Resources committers: http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=02b3cf88d69eefffb51b0001f9e6dfe360865eb8
Added acknowledgements for Platform UI (and Text): http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=cde1b20d0909b0b4f8fbab54d6e8943eb476ade8 Excluded the Platform UI committers listed here: https://projects.eclipse.org/projects/eclipse.platform.ui/who
Updated the list of active committers for JDT UI: http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=230b1f9860d240abe34990cffe95af5e7f9ab951
(In reply to Noopur Gupta from comment #12) > Added acknowledgements for Platform UI (and Text): > http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/ > ?id=cde1b20d0909b0b4f8fbab54d6e8943eb476ade8 Thanks. I removed the double entry for Conrad with http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=d472e9630c8451df9f8b8a71444daac31338480f
New Gerrit change created: https://git.eclipse.org/r/73917
Added acknowledgements for Platform SWT and updated the active committers list: http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=29af1ae152970cdfa267b944d33edb876f288d25
I have added a section for "releng". Plus, I added the introductory paragraph on who the "whole team" thanks. The only thing explicitly left is p2 -- Pascal? And, Tom, you have not provided a "thanks" section in the past, but you could. Perhaps with your new project structure, you could say "The Equinox and p2 team would like to thank ... ". If Pascal or Tom plan on adding nothing, please say so I can remove the "under development" description. If you do plan to, but it will take more than a few days, let us know your target date. = = = = = = BTW, I never did generate a list of "committers" but I get the impression that is not needed. That project leads have generated their own. Let me know if that is still needed. Otherwise, I will save myself the time. Thanks,
Since I haven't heard from Tom or Pascal, I removed the word "Equinox" from the document, and the p2 placeholders (left from previous years). Of course, you may still "join in", if you'd like -- I just wanted to have something we could call "finished". I also made a bunch of edits to get it more "HTML5" compliant. All current errors and warnings are from the "infrastructure" code (i.e. solstice itself) not out our input.
Two questions: 1) Platform Text joined Platform UI, but on the page they are still separated. Should we merge them? 2) How one can find this page if not listening to this bug? I couldn't find a way to see who contributed to 4.5 or 4.4 or 3.7. Do we have *any* page on eclipse.org referring to the "release x.y acknowledgements"?
(In reply to Andrey Loskutov from comment #19) > 2) How one can find this page if not listening to this bug? Like the New and Noteworthy, it is listed on our downloads page, e.g. http://download.eclipse.org/eclipse/downloads/drops4/R-4.5.2-201602121500/
(In reply to Dani Megert from comment #20) > (In reply to Andrey Loskutov from comment #19) > > 2) How one can find this page if not listening to this bug? > > Like the New and Noteworthy, it is listed on our downloads page, e.g. > http://download.eclipse.org/eclipse/downloads/drops4/R-4.5.2-201602121500/ OMG, thanks, although I download SDK very often, I never realized that the link is there, I expected it to be somewhere like on https://projects.eclipse.org/projects/release/3.8.0.
Dani answered in parallel, but I'll post my answer anyway since he didn't address the "text vs. ui" question: = = = = = (In reply to Andrey Loskutov from comment #19) > Two questions: > 1) Platform Text joined Platform UI, but on the page they are still > separated. Should we merge them? Oh, yes, I thought I did "join" them, so suggest Dani answer this one. Perhaps I forgot? > 2) How one can find this page if not listening to this bug? I couldn't find > a way to see who contributed to 4.5 or 4.4 or 3.7. Do we have *any* page on > eclipse.org referring to the "release x.y acknowledgements"? It is listed at the top of every "release" download page. Even though we have not released yet, see http://download.eclipse.org/eclipse/downloads/drops4/S-4.6RC4a-201606061100/ For 4.5.2 see http://download.eclipse.org/eclipse/downloads/drops4/R-4.5.2-201602121500/ for "4.4" see http://archive.eclipse.org/eclipse/downloads/drops4/R-4.4.2-201502041700/ etc.
(In reply to David Williams from comment #22) > (In reply to Andrey Loskutov from comment #19) > > Two questions: > > 1) Platform Text joined Platform UI, but on the page they are still > > separated. Should we merge them? > > Oh, yes, I thought I did "join" them, so suggest Dani answer this one. Fine with me.
(In reply to Dani Megert from comment #23) > (In reply to David Williams from comment #22) > > (In reply to Andrey Loskutov from comment #19) > > > Two questions: > > > 1) Platform Text joined Platform UI, but on the page they are still > > > separated. Should we merge them? > > > > Oh, yes, I thought I did "join" them, so suggest Dani answer this one. > > Fine with me. I see now. At the top of the document we had combined where we say "the team would like to thank ... " It was only in the list of committers where they were separate, and since Dani and Markus already listed in "UI" it was just a matter of removing the "Text" committers section. The paragraph at the top said "Platform UI (and Text)" would like to thank ... " so I changed the committer section to also say "Platform UI (and Text)". I also added an HTML comment at the top to serve as a reminder for next year: <!-- For Neon, we say "Platform UI (and Text)" since they combined near the end of the cycle. In future versions, should just say "Platform UI" --> Thanks for spotting that, Andrey.
And just to prove updates can still be made :) I decided in the releng section to say "thanks" to the other Eclipse projects we depend on: for pre-reqs, EMF and ECF, and for infrastructure not only Tycho, but also EGit and Hudson.
Updated the active committers list for Platform UI (and Text): http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=13249d3bfd58a4cfbbce34cc03bc1c1000274a9a
(In reply to Noopur Gupta from comment #26) > Updated the active committers list for Platform UI (and Text): > http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/ > ?id=13249d3bfd58a4cfbbce34cc03bc1c1000274a9a Can you re-add <td style="width: 23%;">Olivier Prouvost</td>? Olivier is active in the eclipse.platform.ui.tools repo.
(In reply to Lars Vogel from comment #27) > (In reply to Noopur Gupta from comment #26) > > Updated the active committers list for Platform UI (and Text): > > http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/ > > ?id=13249d3bfd58a4cfbbce34cc03bc1c1000274a9a > > Can you re-add <td style="width: 23%;">Olivier Prouvost</td>? Olivier > is active in the eclipse.platform.ui.tools repo. Done.
Updated active JDT and PDE committers: http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=6f7ae63bba4097def7badcadda09fbe3ac360ca0
Hi Dani, Word wrap in text editors is promoted as one of the top most features of Eclipse Neon [1][2]. In the Eclipse Bugzilla it is the bug with the most votes [3]. Word wrap is a contribution from Florian Weßling and was improved by himself, me and Andrey Loskutov. You will find our names in the header of a couple of source files, including new public API [4]. Regardless of this facts, only Andrey Loskutov has been mentioned in the Eclipse Neon acknowledgments [5]. Was our contribution to small? [1] http://www.eclipse.org/neon/noteworthy/#_word_wrap_in_text_editors [2] https://youtu.be/HTa8tZbf3EA?t=19m40s [3] http://eclip.se/35779 [4] http://eclip.se/al [5] https://www.eclipse.org/eclipse/development/acknowledgements_4.6.php
(In reply to Holger Voormann from comment #30) > Regardless of this facts, only Andrey Loskutov has been mentioned in the > Eclipse Neon acknowledgments [5]. Was our contribution to small? Definitely not. BTW my name is mentioned because of this contribution, but because I was the active committer on UI/text for this release. I don't know how the other contributions were counted, but probably the script should not only count commit authors, but also the contributors mentioned in "Also-by" header attributes: git show a50bb821beaaf193dc9bf412316a0c15b32ac0f1 commit a50bb821beaaf193dc9bf412316a0c15b32ac0f1 Author: Andrey Loskutov <loskutov@gmx.de> Date: Tue Aug 5 19:09:27 2014 +0200 Bug 35779 - [misc] Text Viewer and Editor needs to support word wrap Added "Enable word wrap when opening an editor" preference to "Text Editors" preference page, "Toggle Word Wrap" text editor action / toolbar button and ALT+SHIFT+Y shortcut for text editors extending AbstractTextEditor. Change-Id: Ibc4d64d0c76a31aff781726336d41b9ee1cbd659 Also-by: Florian We<C3><9F>ling <flo@cdhq.de> Also-by: Holger Voormann <eclipse@voormann.de> Also-by: Lars Vogel <Lars.Vogel@vogella.com> Signed-off-by: Andrey Loskutov <loskutov@gmx.de> @David: do we have a shared script or something automated to count contributors or each team is doing this manually?
(In reply to Holger Voormann from comment #30) > Hi Dani, > > Word wrap in text editors is promoted as one of the top most features of > Eclipse Neon [1][2]. In the Eclipse Bugzilla it is the bug with the most > votes [3]. Word wrap is a contribution from Florian Weßling and was improved > by himself, me and Andrey Loskutov. You will find our names in the header of > a couple of source files, including new public API [4]. > > Regardless of this facts, only Andrey Loskutov has been mentioned in the > Eclipse Neon acknowledgments [5]. Was our contribution to small? > > [1] http://www.eclipse.org/neon/noteworthy/#_word_wrap_in_text_editors > [2] https://youtu.be/HTa8tZbf3EA?t=19m40s > [3] http://eclip.se/35779 > [4] http://eclip.se/al > [5] https://www.eclipse.org/eclipse/development/acknowledgements_4.6.php Hi Holger and Florian, I volunteered to add the Neon Acknowledgements for Platform UI (comment #12) and Lars glanced over it (comment #14). I used the command from bug 467744 comment #7 to generate the acknowledgement list which does not list your names for Neon. It only lists the primary authors from the commits and not the additional authors specified via "Also-by:" in the commits. In all the word wrap related commits, I can see your names in the "Also-by:" and Andrey's name in the author field. As a result, your names were missed from the acknowledgements and I apologize for that. I have added your names to the list now: https://www.eclipse.org/eclipse/development/acknowledgements_4.6.php I have already done this for JDT UI. It would be good if others can also check the same for their respective components so that other notable authors are not missed.
(In reply to Holger Voormann from comment #30) Thanks Noopur for the fast correction. > Was our contribution to small? Definitely not. Thanks again for your contributions.
(In reply to Noopur Gupta from comment #32) > I used the command from bug 467744 comment #7 to generate the > acknowledgement list which does not list your names for Neon. It only lists > the primary authors from the commits and not the additional authors > specified via "Also-by:" in the commits. Do we have now an improved command line to create the "right" list of contributors? If yes, can you please post it here (or somewhere in the wiki? do we have a wiki for that?), because we will face the same problem again at 4.6.1, 4.6.2, 4.7....
(In reply to Andrey Loskutov from comment #34) > (In reply to Noopur Gupta from comment #32) > > I used the command from bug 467744 comment #7 to generate the > > acknowledgement list which does not list your names for Neon. It only lists > > the primary authors from the commits and not the additional authors > > specified via "Also-by:" in the commits. > > Do we have now an improved command line to create the "right" list of > contributors? If yes, can you please post it here (or somewhere in the wiki? > do we have a wiki for that?), because we will face the same problem again at > 4.6.1, 4.6.2, 4.7.... I couldn't find a command / option to do so quickly. I have just added the above two names for Platform UI and checked it manually for JDT UI.
Thanks.
(In reply to Andrey Loskutov from comment #31) > @David: do we have a shared script or something automated to count > contributors or each team is doing this manually? No, we don't have any general purpose script for this. If someone wanted to create one, there is a set of scripts in another project http://git.eclipse.org/c/simrel/org.eclipse.simrel.tools.git/tree/reportUtilities that might serve as a starting point. I have not used them for several years so not sure what shape they are in, but were helpful in that other project, once. = = = = = = I think the immediate issue has been resolved, so will move this bug back to 'fixed'. If anyone wants a more general purpose tool or process, should probably be handled in a different enhancement request. I mention "process" since one reason this is "hard to do" is we always wait until the last minute. Perhaps we should do something each milestone (as we do with "new and noteworthy" to the final list is easier and more accurate. = = = = = = Much thanks to those who "spoke up" about being inadvertently left off the list.
(In reply to Holger Voormann from comment #36) > Thanks. Thanks. (sorry, I'm quite late..)
