Bug 467744 - Mars Acknowledgements
Summary: Mars Acknowledgements
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.5   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: Documentation
Depends on:
Blocks:
 
Reported: 2015-05-20 14:00 EDT by David Williams CLA
Modified: 2016-05-10 14:21 EDT (History)
16 users (show)

See Also:


Attachments
Contributors (7.57 KB, application/x-zip-compressed)
2015-06-17 11:42 EDT, David Williams CLA
no flags Details
sorted list, per subproject (6.73 KB, application/x-zip-compressed)
2015-06-17 11:48 EDT, David Williams CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2015-05-20 14:00:40 EDT
Every year we take time to thank people in the Eclipse community who have helped us during the release.  The file to update this year is
development/acknowledgements_4_5.php
in
http://git.eclipse.org/c/www.eclipse.org/eclipse.git

Please attach a patch or text if you don't have commit rights on that file (but I think all project leads to).

Here is the 4.4 acknowledgments page as a reference:
http://www.eclipse.org/eclipse/development/acknowledgements_4_4.php

Since this is a web page, we could technically update at any time. But let's set a self-imposed deadline of June 10. That is three weeks from now, which will be a few days after our RC4 (final) deliverable, and two weeks before formal release. 

Over next week or two, I'll work on getting some "commit reports" from Git, for both "Active Committers" and "Active Community Authors" (Just to make sure we don't miss mentioning anyone). 

To cross-reference, the bug where we drove this process last year is bug 436365.
Comment 1 Andrey Loskutov CLA 2015-05-20 14:17:51 EDT
(In reply to David Williams from comment #0)
> Here is the 4.4 acknowledgments page as a reference:
> http://www.eclipse.org/eclipse/development/acknowledgements_4_4.php
 
The link is broken?
Comment 2 Markus Keller CLA 2015-05-20 14:35:35 EDT
http://www.eclipse.org/eclipse/development/acknowledgements_4.4.php works.

David, could you please rename the acknowledgements_4.*.php to *_4_*.php and add a redirect from the oddly-named acknowledgements_4.4.php to the version with the established naming?
Comment 3 Dani Megert CLA 2015-05-20 16:02:56 EDT
David, as discussed, please add a section for Luis Bernardo and the Batik team.
Comment 4 David Williams CLA 2015-05-21 09:35:27 EDT
(In reply to Markus Keller from comment #2)
> http://www.eclipse.org/eclipse/development/acknowledgements_4.4.php works.
> 
> David, could you please rename the acknowledgements_4.*.php to *_4_*.php and
> add a redirect from the oddly-named acknowledgements_4.4.php to the version
> with the established naming?

Sorry, no, this was changed deliberately to use '.', (see bug 436365 comment 38) and is an attempt to get consistency with "everything else" where we use 
<major>.<minor> instead of <major>_<minor>. 
I see no advantage to leaving it as underscore, except for the occasional copy/paste error ... which should be over soon.
Comment 5 Curtis Windatt CLA 2015-05-21 14:07:54 EDT
Can someone add the following for PDE:
The Plug-in Development Environment team would like to thank the numerous contributors who continue to improve the component every release.  We received many well written bug reports and the community was quick to verify our fixes.  Special thanks to Lars Vogel who contributed in several areas of PDE, reviewed contributions of others and was voted in as a committer during the release.  We thank Markus Keller for demonstrating high quality bug reporting and answering our many expert level questions about JDT and Platform.  We appreciate all of the value our community adds to PDE and would specifically like to thank Brian de Alwis (Specify API baselines via target0, Peter Schulz (Edit software dialog in targets), Tony McCrary (replacing the entire icon set), Olivier Provoust (e4 integration into wizards), Simon Scholz (wildcard support in dialogs) and Pragya Gaur (huge number of polish fixes).
Comment 6 Manoj N Palat CLA 2015-05-26 01:02:57 EDT
JDT Core would like to add the following:

The JDT Core team would like to thank everyone who has helped us to improve quality by testing and filing good bug reports. We would like to thank Stephan Hermann for his continued support with the huge number of fixes committed. We had two major contributions for Mars which resulted in the "greatfix" tag - Thanks to  a)John Glassmyer for the set of bugs related to import rewrite consistency and cleanup and b) Mateusz Matula for formatter redesign. We would also like to thank Alexander Kurtakov, Ed Merks, Harry Terkelsen,Kenneth Olson, Szymon Ptaszkiewicz, Terry Parker, Ulrich Grave and Vladimir Piskarev.  A special appreciation goes to Olivier Thomann for continuing to support the team.
Comment 7 Markus Keller CLA 2015-05-28 06:08:01 EDT
(Adapted from bug 436365 comment #15)
If your Git Author fields are correct, then this command summarizes code contributors to Mars:

$ git shortlog -sn R4_4..master

- add -e to see email addresses as well
- use just -n to see commit messages as well

I don't think it makes sense to mention every contributor who added a single line of code, but this query should help you getting started with a list of value-adders.
Comment 8 Lars Vogel CLA 2015-05-28 06:31:30 EDT
(In reply to Markus Keller from comment #7)
> (Adapted from bug 436365 comment #15)
> If your Git Author fields are correct, then this command summarizes code
> contributors to Mars:
> $ git shortlog -sn R4_4..master

Great tip, thanks. I used it to create a unique list of names with the following:

git log R4_4..master --pretty=format:"%an" | sort -u

For eclipse.platform.ui.tools, which is new, I used --since:

git log --since "July 2014" --pretty=format:"%an" | sort -u

Once I had the list of contributors, I created a comma separated list based on the following command.

sed ':a;N;$!ba;s/\n/, /g' AlternativeThankyou


> I don't think it makes sense to mention every contributor who added a single
> line of code, but this query should help you getting started with a list of
> value-adders.

IMHO it is good to thank everyone, even a typo was an effort from the contributor.
Comment 9 Lars Vogel CLA 2015-05-28 06:54:09 EDT
Acknowledgements for platform UI are entered. 

https://www.eclipse.org/eclipse/development/acknowledgements_4.5.php
Comment 10 Sarika Sinha CLA 2015-05-28 08:16:44 EDT
JDT Debug:
The JDT Debug team would like to thank everyone who helped improve the Java debugger by filing bugs, testing and providing patches. Specifically we would like to thank  Aditya Aswani, Frits Jalvingh, Holger Schill and Max L. for bug fixes and Stephan Herrmann for work related to supporting external annotation to a JRE container.

Platform Debug:
The Platform Debug team would like to thank everyone who helped improve the debugger framework by filing bugs, testing and providing patches. Specifically we would like to thank Lars and Tony McCrary for the new icons, Robert Roth for the "greatfix" contribution, Andrey Loskutov, Anton Leherbauer, Philippe Marschall and Richard Birenheide for bug fixes.

Platform Ant:
The Platform Ant team would like to thank everyone who helped improve the ant framework by filing bugs, testing and providing patches. Specifically we would like to thank  Rob Stryker and Julian Enoch for bug fixes.
Comment 11 Szymon Ptaszkiewicz CLA 2015-05-29 08:11:27 EDT
I have added the following note for Platform Workspace:

The Platform Workspace team would like to thank everyone who has helped by filing bugs, testing and providing patches. Specifically we would like to thank the following people who have helped improve the Workspace components by their code contributions to this release: Mat Booth, Steve Francisco, Markus Keller, Alexander Kurtakov, Robin Stocker, Lars Vogel, Paul Webster.

http://git.eclipse.org/c/www.eclipse.org/eclipse.git/commit/?id=0c21a7717d43e8a8b0835ff359bba61c23c02bc9
Comment 12 Noopur Gupta CLA 2015-05-29 09:26:06 EDT
Added acknowledgements for Platform/Text and JDT/UI:

https://www.eclipse.org/eclipse/development/acknowledgements_4.5.php
Comment 13 Arun Thondapu CLA 2015-06-11 14:35:29 EDT
Added acknowledgements for SWT!
Comment 14 Dani Megert CLA 2015-06-11 17:38:03 EDT
Eclipse Platform
Dani 

Am I a component? ;-)
Comment 15 David Williams CLA 2015-06-15 00:38:50 EDT
(In reply to Curtis Windatt from comment #5)
> Can someone add the following for PDE:

Done.

(In reply to Manoj Palat from comment #6)
> JDT Core would like to add the following:

Done.

(In reply to Sarika Sinha from comment #10)
> JDT Debug:

Done.

> Platform Debug:
Done.

> Platform Ant:

Done.

(In reply to Dani Megert from comment #14)
> Eclipse Platform
> Dani 
> 
> Am I a component? ;-)

Accidental paste? Introduced with commit f4a354dc8cb7004ecec9070acd30802c588f1087

(May want to check, Lars ... did you intend something else, or probably accident and already corrected what you intended). 

It was actually hard to find ... a stray "text node" between two rows of the 
committers table, that is displayed somewhere unrelated to the table ... don't you love HTML. :) 

= = = = = = = = = = = = = = = = = = = = = = = = 

I think this completes all the component main sections, except for 
Equinox. (But, feel free to edit/add or correct anything I pasted incorrectly. 

I hope to work on the "committers list" for the bottom of the page 
Monday night.
Comment 16 David Williams CLA 2015-06-17 11:42:34 EDT
Created attachment 254513 [details]
Contributors

This attachment has 5 files, one per "subproject" in Eclipse Platform (matching what is in acknowledgments). 

But, in each file, the contributors are listed "by repository" and sorted by "number of commits". 
 
I generated these using Markus's suggestion with Lars clarification on the one new repository: 

 git shortlog -sne R4_4..master
 git shortlog -sne --since 7/1/2014

(in a little bash script, to group repositories, by subproject). 


These lists will be useful as sanity check, to see if anyone deserves special "thanks", that has not already been covered. 

(Some of you, I'm sure, have already generated similar lists).
Comment 17 Lars Vogel CLA 2015-06-17 11:45:55 EDT
Releng needs to thank the "e4Build" guy, he is almost as active as David. ;-)
Comment 18 David Williams CLA 2015-06-17 11:48:15 EDT
Created attachment 254514 [details]
sorted list, per subproject

The data in this zip is similar to the first one, but has been "sorted" and "duplicate names" removed. Hence, the "numbers" are not accurate of total contributions ... I should have removed those ... since when removing dups based on names it keeps just one line. 

Plus, some "dups" might still be in the files, if contributions had slight variations in name or email. 

But, these files, would be most useful to look at when updating the "committers" section of each of our sub-projects.
Comment 19 David Williams CLA 2015-06-17 11:56:01 EDT
Ok, team, I was hoping to come up with initial "list of committers" in each subproject, but would now like to delegate that to project leads. The reason being that a) it would be very tedious for me, and I am running out of time; and, just as important, b) project leads would still have to carefully review the lists to make sure they were accurate, so ... I think just easier if project leads just do it yourselves. 

When assessing "active committers", it should be based on at least one commit during the mars time-frame (which means, people just from the provided lists). 
AND
It means anyone who was a committer, at any time. Could have just been the last month of the release ... maybe just the first month of the release. 
Put another way, this is not a "legal document", there is no need to make sure a persons "commit" was made during the time they were officially a committer. 

Today's Wednesday ... May at please ask these lists be completed by Friday? 

You can just paste the list here, and I'll handle putting in "html format" for the document itself, if anyone prefers that. If you edit the document directly, please make a note here once you are done. 

Thanks,
Comment 20 Lars Vogel CLA 2015-06-17 14:33:09 EDT
(In reply to David Williams from comment #19)
> Ok, team, I was hoping to come up with initial "list of committers" in each
> subproject, but would now like to delegate that to project leads. 

Any tips how I can get my list of platform.ui committers? I know they are listed at https://projects.eclipse.org/projects/eclipse.platform.ui/who but the list from this website is not easily to be converted to committer ids.
Comment 21 David Williams CLA 2015-06-17 20:51:30 EDT
(In reply to Lars Vogel from comment #20)
> (In reply to David Williams from comment #19)
> > Ok, team, I was hoping to come up with initial "list of committers" in each
> > subproject, but would now like to delegate that to project leads. 
> 
> Any tips how I can get my list of platform.ui committers? I know they are
> listed at https://projects.eclipse.org/projects/eclipse.platform.ui/who but
> the list from this website is not easily to be converted to committer ids.

Committer ids? I would have assumed you'd just go by people's names? 
Or, are you talking about those few cases where people didn't have their configuration setup correctly? 

The only thing I know, to go from 'id' to "real name" is to use 'finger'. 
I'm pretty sure an committer can execute it, even without a shell account, such as 
with shell account: 
finger lvogel
without shell accoutn
ssh david_williams@build.eclipse.org finger lvogel

(And, if you get "no such user", then, they are not a committer!) 

If you really want a list of committer IDs that are part of a component, you need to know the "group" that the component has been assigned (which is usually the group that "owns" the git repository. Then you can 
getent group <groupid>

such as 
getent group eclipse.platform.ui

OR ... you can ask the webmasters? I think this stuff with "groups" is a little out-dated, that in reality, to check permissions on Git, they use an LDap database ... and ... I do not know how to acess the data there (or, if it's even possible). 

But, I think in 99.9 percent of the cases, the name in the lists I provided would be all you need.

HTH
Comment 22 Lars Vogel CLA 2015-06-18 12:18:51 EDT
(In reply to David Williams from comment #21)
> Committer ids? I would have assumed you'd just go by people's names? 

According to the Git logs the following platfrom UI committers never committed anything. That does not sound right, does it?

Chris Austin
Susan McCourt
Hao Zhang 

Based on for example: git shortlog --author "Hao"
Comment 23 Lars Vogel CLA 2015-06-18 12:22:29 EDT
(In reply to Lars Vogel from comment #22)
> (In reply to David Williams from comment #21)
> > Committer ids? I would have assumed you'd just go by people's names? 
> 
> According to the Git logs the following platfrom UI committers never
> committed anything. That does not sound right, does it?
> 
> Chris Austin
> Susan McCourt
> Hao Zhang 
> 
> Based on for example: git shortlog --author "Hao"

OK forget my request. Just learned that I have https://dev.eclipse.org/portal/myfoundation/portal/portal.php and there a link: [manage] inactive committers on the project

That makes it easy to provive the list of active committers.
Comment 24 Arun Thondapu CLA 2015-06-18 13:07:04 EDT
(In reply to David Williams from comment #19)
> You can just paste the list here

Here is the list of active SWT committers:

Arun Thondapu
Alexander Kurtakov
Lakshmi Shanmugam
Leo Ufimtsev
Lina Kemmel
Markus Keller
Niraj Modi
Sravan Kumar Lakkimsetti

Thanks!
Comment 25 Markus Keller CLA 2015-06-18 13:43:34 EDT
(In reply to Lars Vogel from comment #22)
> According to the Git logs the following platfrom UI committers never
> committed anything. That does not sound right, does it?
> 
> Chris Austin
Chris was probably only a Platform UA committer (UA recently got merged into UI)

> Susan McCourt
Susan committed under her former name Susan Franklin

> Hao Zhang 
Vivian was also a Platform UA committer

See bug 439258 for the last Platform UI committers cleanup.
Comment 26 David Williams CLA 2015-06-18 13:49:24 EDT
(In reply to Lars Vogel from comment #23)

> 
> OK forget my request. Just learned that I have
> https://dev.eclipse.org/portal/myfoundation/portal/portal.php and there a
> link: [manage] inactive committers on the project
> 
> That makes it easy to provive the list of active committers.

You probably don't mean this literally, but some care may be needed, as I think the definition of "active" in that listing is a source commit within last 6 months? Whereas in our acknowledgment page, we want "for past year" (basically). 

But, yes, probably provides easier format to get "list of names" and would help narrow down the list of who to look at closely. 

Thanks,
Comment 27 Markus Keller CLA 2015-06-18 14:25:26 EDT
Active JDT Committers:

Andrew Clement
Dani Megert
Jayaprakash Arthanareeswaran
Manju Mathew
Manoj Palat
Markus Keller
Michael Rennie
Noopur Gupta
Olivier Thomann
Sarika Sinha
Sasikanth Bharadwaj
shankha banerjee
Srikanth Sankaran
Stephan Herrmann
Comment 28 Szymon Ptaszkiewicz CLA 2015-06-19 08:32:51 EDT
Active Platform Workspace committers:

John Arthorne
Dani Megert
Sergey Prigogin
Szymon Ptaszkiewicz
Atsuhiko Yamanaka
Comment 29 Lars Vogel CLA 2015-06-19 09:01:14 EDT
Platform UI active committer (according to Git shortlog)

Steve Francisco
Sopot Cela
Brian de Alwis
Paul Elder
Dirk Fauth
Markus Keller
Andrey Loskutov
Dani Megert
Eric Moffatt
Sergey Prigogin
Olivier Prouvost
Szymon Ptaszkiewicz
Thomas Schindl
Wojciech Sudol
Paul Webster
Lars Vogel
Comment 30 David Williams CLA 2015-06-23 11:17:49 EDT
Please take a look at what I have so far, especially for Platform Committers: 

https://www.eclipse.org/eclipse/development/acknowledgements_4.5.php

Since people were reporting Platform Committers component by component, I thought maybe it would be a good idea to list them that way in acknowledgments. But, except where people tell me exactly what to put ... I am guessing a little. 

The ones I have still to add are "Platform Text" and "Platform Debug". 

Or ... if the preferences is for only one "Platform" list, I could combine what people have listed here. 

Preferences?
Comment 31 David Williams CLA 2015-06-23 14:02:21 EDT
I'm going to consider my work here done. 

There could be some who want to still add or edit acknowledgments, and/or check committer lists. 

In particular, I "filled in" PDE and Equinox committer lists as best as I could tell. I IM'd with Tom about his list, but might still be tweaks to make? 

And, PDE ? Vikas wasn't online, so if I missed anyone, apologies, and feel free to correct.
Comment 32 Vikas Chandra CLA 2015-06-24 02:21:24 EDT
Hi David,

For PDE committers, Curtis Windatt should be added.
Comment 33 David Williams CLA 2015-06-24 04:13:39 EDT
(In reply to Vikas Chandra from comment #32)
> Hi David,
> 
> For PDE committers, Curtis Windatt should be added.

Done.