Description Markus Keller 2016-02-10 08:06:18 EST

For completion proposals that implement all ICompletionProposalExtensions,
org.eclipse.jface.text.contentassist.CompletionProposalPopup#handleSetData(Event) currently:
- calls ICompletionProposalExtension6#getStyledDisplayString() and throws the returned value away
- calls ICompletionProposalExtension7#emphasizeMatch(..) and uses the returned StyledString

Problems:
1. getStyledDisplayString() should not be called if the result is not used
2. ICompletionProposalExtension6#getStyledDisplayString() and ICompletionProposal#getDisplayString() need to tell that ICompletionProposalExtension7 exists, and getStyledDisplayString() needs to tell that it's not used in that case
3. emphasizeMatch(..) is not a good API name. The method doesn't emphasize a match in an existing string, but it returns a new styled display string in which the matching characters should be emphasized. I see two possible solutions:
3.a) pass the result of getStyledDisplayString() as an additional parameter to emphasizeMatch(..)
3.b) rename the method to getStyledDisplayString(IDocument, int, BoldStylerProvider) or getEmphasizedStyledDisplayString(..) (though I prefer the getStyledDisplayString(..)). In this case, solutions for problems 1 and 2 need to be adjusted accordingly.