Community
Participate
Working Groups
Once Bug 350000 is fixed, it would be nice if the LabelProvider used to display matches could highlight the matching parts. For example: Button b = new Button(..); b.selection -> Results in b.addSelectionListener would be great if Selection would be in bold.
Created attachment 257381 [details] patch Attaching WIP patch based on current master branch. The patch is in working condition. Need to modify for substring completion and test further. Any early feedback on the patch would be great.
(In reply to Noopur Gupta from comment #1) > Created attachment 257381 [details] [diff] > patch > > Attaching WIP patch based on current master branch. The patch is in working > condition. Need to modify for substring completion and test further. Any > early feedback on the patch would be great. There is a problem with keyword proposals: on completion the matches are not shown but if one presses backspace and then enters the character again, it works. I don't like that only some proposals show the matching characters. For example templates don't. Users can see this as being broken. Of course we can also add the code there, but we should try to find a solution that works for all proposals. We also have to validate our feature against Code Recommenders. AFAIK they already do this and we don't want to break them.
New Gerrit change created: https://git.eclipse.org/r/60935
New Gerrit change created: https://git.eclipse.org/r/60936
Gerrit change https://git.eclipse.org/r/60935 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=ed9bc992c5e7369f0146149b6431951010069c3e
(In reply to Dani Megert from comment #2) > We also have to validate our feature against Code Recommenders. AFAIK they > already do this and we don't want to break them. To repeat in Bugzilla what was said at EclipseCon: We are happy to remove our highlighting in favor of more general an API provided by JDT. I kindly ask for a heads up via Mail or Bugzilla a few weeks before this feature will be released so that we can pick up the changes.
(In reply to Marcel Bruch from comment #6) > (In reply to Dani Megert from comment #2) > > We also have to validate our feature against Code Recommenders. AFAIK they > > already do this and we don't want to break them. > > To repeat in Bugzilla what was said at EclipseCon: We are happy to remove > our highlighting in favor of more general an API provided by JDT. > > I kindly ask for a heads up via Mail or Bugzilla a few weeks before this > feature will be released so that we can pick up the changes. Marcel, I suggest you take a look at the initial API that we release for M4 (see comment 5). We did not yet release the JDT part, since there are life-cycle issues with the font.
New Gerrit change created: https://git.eclipse.org/r/62382
Gerrit change https://git.eclipse.org/r/62382 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=6609897c2bbf882fcd53e2ebdf1e0783db9158c8
I think we should relabel the bug report, AFAICS the styling it not specific to substring completion (which is good).
(In reply to Eclipse Genie from comment #9) > Gerrit change https://git.eclipse.org/r/62382 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=6609897c2bbf882fcd53e2ebdf1e0783db9158c8 > Removed duplicate #getBoldStylerProvider call with http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=48c24e2f1e475f55f3b737256122c0c0e32e36d6
Gerrit change https://git.eclipse.org/r/60936 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=7fd37c8e139cdceae09290ace1aeba8b2de7a6d2
Created attachment 259148 [details] Screenshot Highlighting for templates look different than for methods. Not sure if that is intended but IMHO this looks strange. See screenshot.
.
(In reply to Lars Vogel from comment #13) > Created attachment 259148 [details] > Screenshot > > Highlighting for templates look different than for methods. Not sure if that > is intended but IMHO this looks strange. See screenshot. Templates are blue by default, so, that's not a bug, but the match should be highlighted with bold blue. Please file a separate bug. Thanks.
