Community
Participate
Working Groups
If I start Eclipse with the dark theme the progress bar frequently turn white during an update. Looks to me that SWT does not respect the background color if it triggers an update.
Created attachment 258478 [details] Animated Gif
Created attachment 258479 [details] Another animated git which shows this during p2 installation
This is still reproducible with the 4.6 M7 build but its unlikely we can investigate it for 4.6, moving the target to 4.7.
*** Bug 465905 has been marked as a duplicate of this bug. ***
Color for progress bar items are set from platform.ui in ProgressInfoItem.java lines 188-195. The darkRGB values are set by acquiring COLOR_LIST_BACKGROUND and applying a shift (in linux, the shift is -10). However, this only causes the items to look slightly darker since COLOR_LIST_BACKGROUND is 255,255,255 (white). We can change the color to match something correctly to Progress items by adjusting the shift.
(In reply to Ian Pun from comment #5) > Color for progress bar items are set from platform.ui in > ProgressInfoItem.java lines 188-195. The darkRGB values are set by acquiring > COLOR_LIST_BACKGROUND and applying a shift (in linux, the shift is -10). > However, this only causes the items to look slightly darker since > COLOR_LIST_BACKGROUND is 255,255,255 (white). We can change the color to > match something correctly to Progress items by adjusting the shift. Based on this, moving to Platform UI.
It actually looks like setColor() is actually the culprit; ProgressInfoItem calls setColor() whenever there is an update, which overrides the dark theme css momentarily (until you refresh the widget by switching tabs). the setColor() is mainly used so that in the Progress view, there is a slight shift difference in color between different items. I think the best thing to do is to not have it set those colors if we are running dark theme (or many any theme at all besides classic?). I did a bit of research into how we could find it, and I came this method : PlatformUI.getWorkbench().getThemeManager().getCurrentTheme(), but I am not sure how to get the actual themes "name" to compare to.
(In reply to Ian Pun from comment #7) > It actually looks like setColor() is actually the culprit; ProgressInfoItem > calls setColor() whenever there is an update, which overrides the dark theme > css momentarily (until you refresh the widget by switching tabs). I did not look into the code, but this sounds like setColor() should not be called at all during update.
(In reply to Lars Vogel from comment #8) > (In reply to Ian Pun from comment #7) > > It actually looks like setColor() is actually the culprit; ProgressInfoItem > > calls setColor() whenever there is an update, which overrides the dark theme > > css momentarily (until you refresh the widget by switching tabs). > > I did not look into the code, but this sounds like setColor() should not be > called at all during update. So far, the setColor() gets called whenever theres an add or remove, pretty much any "updates" to the progress (more info, less info, removing the info completely, etc). What it is suppose to do is give the related information to a central 'job' a shift of RGB values by 10 or so, making it slightly darker. However, this feature is messing up our dark theme completely, as it doesn't take account for any themeing whatsoever. I suggest we remove the setColor() method that has to do with shifting/updating any colors except for 'selected widget' color update. This will make any themeing work correctly as it will use the .css from org.eclipse.ui.themes as priority.
(In reply to Ian Pun from comment #9) > I suggest we remove setColor() method that has to do with shifting/updating any colors except > for > 'selected widget' color update. This will make any themeing work correctly > as it will use the .css from org.eclipse.ui.themes as priority. +1, sounds like a good plan.
New Gerrit change created: https://git.eclipse.org/r/81125
New Gerrit change created: https://git.eclipse.org/r/81359
Gerrit change https://git.eclipse.org/r/81359 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=129c14dfdbe2dd8dc56fb57fa1cd13087b54871d
Gerrit change https://git.eclipse.org/r/81125 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f0460844a5d97125d17b587d429f9a490453737e
Thanks Ian. Can you please create an entry for the N&N M3?
New Gerrit change created: https://git.eclipse.org/r/81382
(In reply to Lars Vogel from comment #15) > Thanks Ian. Can you please create an entry for the N&N M3? Should be in now with some before and after photos.
Gerrit change https://git.eclipse.org/r/81382 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=04292795ee932298850110b58faa7f577d9b17cb
Created attachment 265087 [details] Windows 7 This is how it looks on Windows 7 in I20161027-0700.
Reopening. Bugs on Windows 7: * Dark theme: - background is red * normal themes: - backgrounds are not using alternating colors any more - when changing the selection, all previously selected jobs are drawn in selection color (blue) I'll remove the entry from the M3 N&N. If you add the entry again in M4, then please spend more time with the formatting (e.g.: <b>Progress</b> view)
(In reply to Markus Keller from comment #20) > Reopening. Bugs on Windows 7: > > * Dark theme: > - background is red Will be fix with this bug (Gerrit upcoming) > * normal themes: > - backgrounds are not using alternating colors any more > - when changing the selection, all previously selected jobs are drawn in > selection color (blue) Handled by Bug 506553.
New Gerrit change created: https://git.eclipse.org/r/84042
Gerrit change https://git.eclipse.org/r/84042 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=995a28e980d8f86a6ec066bc59bb085e7de0ff28
Fixed black theme issue, white theme issue will be discussed via Bug 506553.
New Gerrit change created: https://git.eclipse.org/r/84762
