Bug 478366 - [UCOSP] tasks with INCOMING_REVIEW state have guaranteed visibility
Summary: [UCOSP] tasks with INCOMING_REVIEW state have guaranteed visibility
Status: ASSIGNED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Vaughan Hilts CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 479597 (view as bug list)
Depends on:
Blocks: 478362
  Show dependency tree
 
Reported: 2015-09-24 20:23 EDT by Vaughan Hilts CLA
Modified: 2015-12-10 14:37 EST (History)
0 users

See Also:


Attachments
mylyn/context/zip (6.39 KB, application/octet-stream)
2015-09-25 13:17 EDT, Sam Davis CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Vaughan Hilts CLA 2015-09-24 20:23:13 EDT
Investigate a data model for the tasks which could be used to store the INCOMING_REVIEW flag.
Comment 1 Sam Davis CLA 2015-09-25 13:17:54 EDT
I changed the summary because we can just store this as a property on the ITask. The interesting part will be updating the guaranteed visibility rules. See the attached context.
Comment 2 Sam Davis CLA 2015-09-25 13:17:55 EDT
Created attachment 256850 [details]
mylyn/context/zip
Comment 3 Vaughan Hilts CLA 2015-10-07 17:20:54 EDT
I'd like to work on this.
Comment 4 Sam Davis CLA 2015-10-13 18:39:21 EDT
*** Bug 479597 has been marked as a duplicate of this bug. ***
Comment 5 Vaughan Hilts CLA 2015-10-14 23:53:54 EDT
Thanks for the context Sam. It got me on the right track for the filtering aspect, which I think I have the barebones skeleton in place for.

The task updating workflow is a little vauge to me -- there's not a lot of comments so I've been relying on the context browser to guide me around (super handy, by the way!) For setting the attributes, this is my current plan of attack:

* I took a look at the SynchronizationJob's and their factory for generaring them.
* Eventually, this leads me to a lot of `updateTaskData` statements and I've discovered a TaskDataManager which eventually delegates to a connector. For "Tasks", or at least a Task as I know it, I believe I should be setting the attributes here, and looking up any particular mappings and setting them.
  * Blaine could be doing this and we could store the data as mappings in here? It's possible.
  
A few questions spring to mind...

 1) Why does a "BugzillaConnector" have an updateTaskData method? It doesn't manager "Tasks", right?
 2) At what point does it make  sense to set this indiciator? Maybe it should be done when a "review" changes?
 3) If the above, any suggestions on where to hook in a listener?
 
 Thanks!
Comment 6 Eclipse Genie CLA 2015-10-15 22:27:13 EDT
New Gerrit change created: https://git.eclipse.org/r/58293
Comment 7 Sam Davis CLA 2015-10-16 18:26:46 EDT
Vaughan, I don't think your question is related to guaranteed visibility, so I am going to respond on the parent bug.
Comment 8 Eclipse Genie CLA 2015-10-22 18:13:57 EDT
New Gerrit change created: https://git.eclipse.org/r/58768