Bug 478362 - [UCOSP] create an incoming review state for tasks
Summary: [UCOSP] create an incoming review state for tasks
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on: 478363 478366 478364 478367 480467
Blocks: 476925
  Show dependency tree
 
Reported: 2015-09-24 19:18 EDT by Vaughan Hilts CLA
Modified: 2015-10-22 18:16 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vaughan Hilts CLA 2015-09-24 19:18:21 EDT
This will involve a few subtasks. This serves as the parent for the original task. To summarize, it will involve a few aspects...

* A new state / flag for all tasks to let them know they have some incoming review changes
* This flag should be cleared when there's nothing coming in / it's read
* We'll need some decorators and the legend will need updating
Comment 1 Sam Davis CLA 2015-10-15 14:42:57 EDT
We need to set the incoming_review state on tasks based on the incoming state of associated reviews:
* set incoming_review state on associated task when a review gets an incoming
* clear incoming_review state on associated task when no associated review is incoming

You can use ITaskListChangeListener to listen for changes to the incoming state (SynchronizationState) of reviews.
Comment 2 Sam Davis CLA 2015-10-15 14:45:08 EDT
In addition to listening for changes to existing reviews, we need to listen for new reviews coming into the task list and update the associated task. Maybe that can happen in the same place we update the task-review mappint.
Comment 3 Sam Davis CLA 2015-10-16 18:30:54 EDT
(In reply to comment #5 from bug 478366)
> 1) Why does a "BugzillaConnector" have an updateTaskData method? It doesn't
> manager "Tasks", right?

Assuming you mean updateTaskFromTaskData, each connector has to update the corresponding ITask (in-memory cache) when receiving an updated TaskData from the repository. TaskMapper is used by connectors to abstract a lot of common update functionalty but generally connectors need to customize the behaviour.

> 2) At what point does it make  sense to set this indiciator? Maybe it should be
> done when a "review" changes?

Right, you can use ITaskListChangeListener as per my first comment.
Comment 4 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn