Bug 470417 - popups aren't styled by theme when no active shell
Summary: popups aren't styled by theme when no active shell
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.15   Edit
Hardware: PC Mac OS X
: P3 minor (vote)
Target Milestone: 3.17   Edit
Assignee: Chris Poon CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2015-06-17 13:06 EDT by Dawid Pakula CLA
Modified: 2015-06-25 17:27 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2015-06-17 13:06:33 EDT 
In general popups looks great after fix from bug 438817, but sometimes looks like before. It's random and I'm not sure how to reproduce.

Tested on RC4 build.
Comment 1 Sam Davis CLA 2015-06-17 13:44:26 EDT 
What theme are you using? Is there anything in the error log?
Comment 2 Dawid Pakula CLA 2015-06-17 17:42:22 EDT 
Theme dark, buil-in
Logs are empty

I had this when receiving new task and focus was on another app (firefox on second screen).
Comment 3 Sam Davis CLA 2015-06-19 17:30:12 EDT 
Chris, can you see if you can reproduce this?
Comment 4 Chris Poon CLA 2015-06-22 13:24:07 EDT 
It seems like if you get a notification while focus was on another application, it defaults back to the old gradient styling.  It retains styling if you are focusing on another window of the same Eclipse instance.

Tested on Windows with Eclipse Mars RC4 Dark Theme.
Comment 5 Sam Davis CLA 2015-06-22 14:26:50 EDT 
Thanks. Do you think it's possible to fix?
Comment 6 Chris Poon CLA 2015-06-22 17:40:45 EDT 
Yes, it seems like the problem is that we are retrieving the style from the active shell.  So if we have focus on another application, there is no more active shell and the default styling is applied.

I will push a fix for this very soon.
Comment 7 Sam Davis CLA 2015-06-24 18:44:56 EDT 
Fixed with https://git.eclipse.org/r/#/c/50681/.