Comment 1 Greg Amerson 2014-11-12 02:54:20 EST

Can the notication popup read some common platform preference (like console color, or text editor main font color) which is already styled by luna dark theme?

Comment 2 Sam Davis 2014-11-12 14:56:53 EST

It probably could. :) It looks like it's already trying to do that because the colours are different with that theme, but clearly the colours that it's reading are not good choices.

Comment 3 Greg Amerson 2014-11-12 16:50:54 EST

Created attachment 248621 [details]
screenshot using another dark theme

Just to add another test data point, I'm using Luna with the eclipse-ui-theme plugin[1], Moonrise look-and-feel with the RainbowDrops.epf[2] syntax color presets.

[1] https://github.com/guari/eclipse-ui-theme
[2] https://github.com/guari/eclipse-ui-theme/blob/master/com.github.eclipseuitheme.themes.plugin/bin/color-scheme/RainbowDrops.epf

Comment 4 Sam Davis 2015-02-23 13:42:08 EST

Related to bug 460623.

Comment 5 Sam Davis 2015-05-07 20:03:01 EDT

Also related: bug 428324

Comment 6 Sam Davis 2015-05-11 14:57:32 EDT

*** Bug 466833 has been marked as a duplicate of this bug. ***

Comment 7 Sam Davis 2015-05-22 14:10:15 EDT

I've merged https://git.eclipse.org/r/#/c/48483/ which seems to fix the issue on Windows, but we'll need to test it on other platforms. The fix will be available from the weekly update site http://download.eclipse.org/mylyn/snapshots/weekly within an hour.

Comment 8 Gorkem Ercan 2015-05-22 17:23:04 EDT

Fix seems to be good on Mac too.

Comment 9 Sam Davis 2015-05-22 17:33:57 EDT

Thanks for checking that!

Comment 10 Chris Poon 2015-05-25 17:24:47 EDT

Tested this change on OpenSUSE. It fixes the dark theme notification on Eclipse Luna and notifications are unchanged in Eclipse 3.8.

Comment 11 Chris Poon 2015-05-26 14:12:42 EDT

Also tested this in Eclipse Luna for Windows and Linux (OpenSUSE) with the Moonrise UI Eclipse theme and multiple color themes (including Rainbow Drops, Sublime Text).  The Mylyn notification is fixed.  It seems like the notification background is determined by the Eclipse theme and the color theme has no effect on it.

Comment 12 Sam Davis 2015-05-26 15:50:27 EDT

Tested on Mac: Luna with dark and moonrise themes and 3.8.

Comment 13 Chris Poon 2015-05-27 19:26:50 EDT

So there seems to be an issue with the borders on dark-themed notifications.  It looks like the border is being overwritten by some CSS values, so the border does not show on the dark theme.  The light themes (tested on Classic, Windows and Windows XP Blue themes) the border does show and it doesn't seem like their values are overwritten by CSS.

Comment 14 Sam Davis 2015-05-27 19:50:27 EDT

Based on the screenshots, it seems that the border is being drawn, but for some reason the colour is set by the theme to the background colour and we are not able to change that. It's not clear how the current borders are being drawn but they seem to come from the shell. If we set a border using the SWT.BORDER style bit on the composite, it shows up but doesn't have rounded corners. That could be a workaround for the dark theme but it's not clear how we would determine when we need to set that bit, so we'll leave it as is for now.

The original issue of unreadable text is fixed.

Comment 15 Dawid Pakula 2015-05-29 16:45:00 EDT

Work finally ok. THANK YOU!!!

Links styling was reported on SWT level: bug 401015

Comment 16 Sam Davis 2015-06-04 16:28:42 EDT

I think we will need to revert the change because it has replaced the nice gradient background with a solid grey. I'm not sure if we'll be able to support the Dark theme for Mars.

Comment 17 Gunnar Wagenknecht 2015-06-04 16:38:39 EDT

I think that ideally the theme would provide the gradient color. It could then be customized within the dark theme.

Comment 18 Sam Davis 2015-06-04 16:42:04 EDT

Chris is looking into whether it's possible to get suitable colours from the theme manager.

Comment 19 Chris Poon 2015-06-05 14:53:28 EDT

Reverted the changes in https://git.eclipse.org/r/#/c/48483/ to re-introduce the gradient to the notifications. 

We are now retrieving background color from the theme CSS if it exists (seems like it is only in the Dark theme in the standard Eclipse themes for Windows).  If it doesn't exist it will fall back to the old way of retrieving the background color.  This background color is then blended to produce the gradient.

Tested on Eclipse Luna on all of the default themes for Windows and Ubuntu.  Also tested that the notification background is displayed properly on Eclipse 3.8.

Comment 20 Sam Davis 2015-06-05 14:58:06 EDT

Well, we haven't merged the change yet, but that's what we're considering doing.

Comment 21 Chris Poon 2015-06-05 19:04:25 EDT

Also tested on Mac OSX on the default Eclipse Luna and Eclipse 3.8 themes.

Comment 22 Sam Davis 2015-06-08 17:19:15 EDT

Chris, could you also test the Dark theme and the standard theme with Mars RC3 https://www.eclipse.org/downloads/packages/eclipse-ide-java-developers/marsrc3 on all three platforms (mac, linux, windows), and post a screenshot showing the 6 different versions of the popup?

Comment 23 Chris Poon 2015-06-08 18:52:58 EDT

Created attachment 254206 [details]
OSX Dark Theme Notification on Mars

Comment 24 Chris Poon 2015-06-08 18:54:00 EDT

Created attachment 254207 [details]
OSX Mac (Default) Theme on Mars

Comment 25 Chris Poon 2015-06-08 18:54:34 EDT

Created attachment 254208 [details]
Ubuntu Dark Theme on Mars

Comment 26 Chris Poon 2015-06-08 18:54:55 EDT

Created attachment 254209 [details]
Ubuntu GTK Theme on Mars

Comment 27 Chris Poon 2015-06-08 18:55:14 EDT

Created attachment 254210 [details]
Windows Dark Theme on Mars

Comment 28 Chris Poon 2015-06-08 18:55:35 EDT

Created attachment 254211 [details]
Windows "Windows" (Default) Theme on Mars

Comment 29 Sam Davis 2015-06-09 02:24:26 EDT

Thanks Chris. We ended up modifying it slightly so that it only uses the theme colour if it's significantly different from the standard background colour, because it seems to look better that way. The upshot of all this is that the behaviour will be exactly the same as it was in previous releases except for themes with very different background colours, like the dark theme

Comment 30 Toni Heimala 2015-07-10 06:54:46 EDT

I believe this was supposed to be fixed in latest Mylyn release (3.16). However, this does not seem to work for me with Eclipse Luna SR2 (4.4.2) in Windows 8.1.

I have tried changing from Dark to Classic, saving, restarting and changing back to Dark and restarting again. The Notification window still stays with the default theme colors.

Comment 31 Sam Davis 2015-07-10 13:17:24 EDT

I think this should work on Luna with Mylyn Commons 3.16. Toni, could you attach your Eclipse error log to help us investigate?

Comment 32 Toni Heimala 2015-08-12 09:47:26 EDT

Created attachment 255816 [details]
Eclipse error log

Mylyn errors especially noteworthy on days 2015-07-08 - 2015-07-10.

Comment 33 Toni Heimala 2015-08-12 09:49:47 EDT

Sorry for the long delay, I was on vacation. The most interesting times on that log should be between 2015-07-08 and 2015-07-10 when I tried changing the themes to get Mylyn coloring working.

Comment 34 Sam Davis 2015-08-12 13:43:20 EDT

Thanks. There is an NPE in the log which I'll push a fix for now, but it is probably not related. Have you tried upgrading to Mars?

Comment 35 Eclipse Genie 2015-08-12 13:46:14 EDT

New Gerrit change created: https://git.eclipse.org/r/53659

Comment 36 Eclipse Genie 2015-08-12 13:56:59 EDT

Gerrit change https://git.eclipse.org/r/53659 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.commons.git/commit/?id=2790406d64853459a59ef459868d894e0db7e6e9

Comment 37 Toni Heimala 2015-08-13 04:06:39 EDT

I upgraded to Mars and it seems that the problem is fixed.

Comment 38 Sam Davis 2015-08-13 13:52:38 EDT

Great, thanks for letting me know!