Bug 466833 - Error reporting notification unreadable with Dark theme
Summary: Error reporting notification unreadable with Dark theme
Status: RESOLVED DUPLICATE of bug 438817
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.15   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mylyn Inbox CLA
QA Contact: Steffen Pingel CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-08 08:58 EDT by Andreas Sewe CLA
Modified: 2015-06-04 17:08 EDT (History)
1 user (show)

See Also:


Attachments
Screenshot illustrating the situation (28.15 KB, image/png)
2015-05-08 08:58 EDT, Andreas Sewe CLA
no flags Details
Standard Mylyn notifications suffering from some of the same problems (50.68 KB, image/png)
2015-05-08 09:06 EDT, Andreas Sewe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sewe CLA 2015-05-08 08:58:46 EDT
Created attachment 253335 [details]
Screenshot illustrating the situation

See the attached screenshot (taken using the Mars M7 JEE package).
Comment 1 Andreas Sewe CLA 2015-05-08 09:06:45 EDT
Created attachment 253336 [details]
Standard Mylyn notifications suffering from some of the same problems

The attached screenshot shows that standard Mylyn notifications also suffer from the problem of too light foreground colors, but not from the problem of a dark gray background.
Comment 2 Marcel Bruch CLA 2015-05-08 09:29:22 EDT
Moving this to Mylyn Commons since this affects the use APIs of Mylyn. What are your houghts? Will Mylyn Commons investigate how to render popups in a readable way for dark theme users? Or is there a workaround?
Comment 3 Sam Davis CLA 2015-05-11 14:57:32 EDT
This is planned for Mars.

*** This bug has been marked as a duplicate of bug 438817 ***
Comment 4 Sam Davis CLA 2015-05-21 14:59:05 EDT
After investigation, the problem is that the background colour of the notifications is inherited and this prevents the theme's background colour from being applied. We're considering changing the background mode to not inherit as this seems to fix the problem on Windows at least. I'm not sure why the error report notification has a grey background but I assume you're creating a custom control with the background mode not set to inherit?
Comment 5 Marcel Bruch CLA 2015-05-21 17:10:57 EDT
(In reply to Sam Davis from comment #4)
> creating a custom control with the background mode not set to inherit?

That's certainly true. We'll inherit the background (it's just using a SWT.INHERIT style flag in the constructor I guess).
Comment 6 Sam Davis CLA 2015-05-26 13:23:23 EDT
Marcel, there's a fix available from the weekly update site http://download.eclipse.org/mylyn/snapshots/weekly if you want to confirm that it works for the error notifications.
Comment 7 Sam Davis CLA 2015-06-04 16:35:20 EDT
See my comment on  bug 438817. I think we will have to revert the fix.
Comment 8 Marcel Bruch CLA 2015-06-04 17:08:07 EDT
Thanks for the heads up. FWIW, I'm happy with the best Mylyn can offer. I just have to make sure we behave the same as Mylyn.