Comment 1 Lars Vogel 2015-03-26 11:40:37 EDT

Requires only a change in the default preference setting. If you want Dani, I can fix that. In this case assign the bug to me.

Comment 2 Dani Megert 2015-03-26 11:41:54 EDT

(In reply to Lars Vogel from comment #1)
> Requires only a change in the default preference setting. If you want Dani,
> I can fix that. In this case assign the bug to me.

I'll do it, np.

Comment 3 Ed Willink 2015-03-26 11:47:32 EDT

+1. Thanks.

May be the default default MRU for a workspace upgrade could be theme dependent. 

For clarity. There are two issues, both of which go wrong with the MRU preference set to the M6 default.

a) editors with visible tabs are random, not chronologically last
b) the ordering in the show list of all open editors is random / chronologocical

With the preference ticked, we get what I expect

a) editors with visible tabs are MRU (but in a wierd order, alphabetical would be nice)
b) the ordering in the show list of all open editors is alphabetical (but alphabetical now includes the dirty "*", better to not sort all *'s at one end, forcing me to look in two places rather than one).

So please please please do not suddenly introduce chronological order into the show list, since IMHO the behavior I see and nearly like is a) MRU, b) not-MRU so refering to this as an MRU preference is very confusing.

Comment 4 Dani Megert 2015-03-26 12:21:16 EDT

(In reply to Ed Willink from comment #3)
> +1. Thanks.
> 

Ed, this bug is only about switching the preference to MRU (as it was in the Classic theme). If you use MRU and see issues like bug 462713, please file separate bugs that can be looked at.


Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=746be88c1f8b8aa7fa6508167aacb98d95bb1141

Comment 5 Lars Vogel 2015-03-26 12:30:58 EDT

Verified by looking really hard at the code.

Comment 6 Lars Vogel 2015-03-26 12:32:11 EDT

This should be added to the N&N in M7.

Comment 7 Ed Willink 2015-03-26 12:38:11 EDT

(In reply to Dani Megert from comment #4)
> (In reply to Ed Willink from comment #3)
> Ed, this bug is only about switching the preference to MRU

I am trying to help by identifying that the term MRU is dangerously confusing.

The left hand wants MRU, the right hand wants non-MRU, so doing MRU in one place can very easily break behaviour in another. I suspect this is the real problem two meanings for one term.

As a minimum the new preference should be:

Ordering of visible view tabs:
- alphabetically sorted
- MRU sorted

Ordering of show list entries:
- alphabetically sorted
- MRU sorted

The classic behavior is neither MRU nor not-MRU so changing the default to either MRU false or MRU true probably just moves the bug around. Neither is a non-regression.

Comment 8 Dani Megert 2015-03-26 15:09:01 EDT

(In reply to Ed Willink from comment #7)

I'm going to ignore this as per comment 4.

Comment 9 Dani Megert 2015-03-26 15:15:04 EDT

(In reply to Dani Megert from comment #8)
> (In reply to Ed Willink from comment #7)
> 
> I'm going to ignore this as per comment 4.

Just to clarify: I ignore it in this bug. I agree that the preference could still be improved, and we tried that for M6 (see bug 462216). I suggest you open a new bug with your suggestions. Thanks.