Community
Participate
Working Groups
BordereredStyleDescription and BorderedStyle should have an attribute typed by LineStyle. The default value should be solid (as current borders) (no required migration). This will allow the specifier do choose the border line style for containers and node mappings. All our Node and Container figures have to be updated to handle the chosen line style from the VSM (description -> style, style to figure). The customization from the style property section should put the attribute in the custom list. The figure should be update when the style change (style customization, conditional style, user change from the property sections) (see the line width setter/getter/changes). The appearance property section might propose to change the line style. The tabbar might potentially propose this too.
See https://git.eclipse.org/r/#/c/44490/
(In reply to Maxime Porhel from comment #0) > The tabbar might potentially propose this too. The line style button will not be added to the tabbar: it is currently not available for edges and will be sufficient in the appearance properties tab.
I put work around this ticket paused (see: https://git.eclipse.org/r/#/c/44490/) and here the list of work to do : 1- Add the line style button in the appearance properties tab (the button is grayed and it must be enabled for nodes and containers). 2- Complete the test org.eclipse.sirius.tests.swtbot.BorderLineStyleTest. 3- Update the Release notes.
WARNING: this patchset contains 1062 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
New Gerrit change created: https://git.eclipse.org/r/51240
New Gerrit change created: https://git.eclipse.org/r/51241
New Gerrit change created: https://git.eclipse.org/r/51251
Created attachment 255758 [details] Solid, dot, dash_dot line style (bordersize:3)
Created attachment 255759 [details] Solid, dot, dash_dot line styles (borderSize/edgeSize = 3)
Created attachment 255760 [details] Solid, dot, dash_dot line styles (borderSize/edgeSize = 3)
Created attachment 255761 [details] Dash line style for 1, 3 and 5 pix widths This show the differences in the dash line style rendering between the different existing styles: this comes from the fact that we use a pattern and the Graphics.LINE_CUSTOM (ie. SWT.LINE_CUSTOM) instead of LINE_DASH when the service is available on the figures in the current patch set as it was done for edges from the beginning of Sirius. We might change this: . For the edge, but it will change the rendering of all existing diagrams . Keep this pattern only for the edges . Extends all used figures to support the LINE_CUSTOM and its dash pattern.
For the validation: see org.eclipse.sirius.tests.swtbot.BorderLineStyleTest, the test data has been created with layer and style customizations to easily change the border/edge size and line style of all figures in "one click".
BorderLineStyleTest has been renamed into LineStyleTest as it also test the udpate of the edge line style.
Created attachment 255784 [details] Line style test case
Steps to reproduce/validate: . Unzip the attached project . Open the diagram . (De)Activate the layers to change the line style . Select each node/container/edge and play with the Style property tab to change the line style / border line style and the size / border size. . Use the reset style to default property to reset the style to the VSM configuration
Gerrit change https://git.eclipse.org/r/51232 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=7bcb318f802da151e5d71024fd9509af7ae98994
Gerrit change https://git.eclipse.org/r/51231 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c82881f992a9724efca8ea1d0d6951025d00ec62
Gerrit change https://git.eclipse.org/r/51251 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=4ee4ae3c6813e3ac0ca99a540d6c09407a236429
Gerrit change https://git.eclipse.org/r/51241 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ea398377c4e45d95683da9c4b1a8fdfd9323bb64
Gerrit change https://git.eclipse.org/r/51240 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0efca49704889e752bddb94087f353c083981095
Gerrit change https://git.eclipse.org/r/44490 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ed1189102d121d94e42aa34f2018b9b06ebc3af3
The dash pattern {5, 5} will only be used for edges. The node and containers will use the standard SWT.LINE_DASH line style
New Gerrit change created: https://git.eclipse.org/r/54116
Created attachment 255955 [details] Final dash line style for 1, 3 and 5 pix widths
Gerrit change https://git.eclipse.org/r/54116 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=edb7de4da37d98f2e36f2a5f713a315f17714292
validated with solid, dash, dash_dot and dash_dot_dot styles. Double style is excluded from this ticket
Available in Sirius 3.1.0.
