Bug 436359 - Support Compartments in Sirius diagrams
Summary: Support Compartments in Sirius diagrams
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 1.0.0   Edit
Hardware: PC Windows NT
: P3 enhancement (vote)
Target Milestone: 3.0.0   Edit
Assignee: Maxime Porhel CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on: 461590 461593 462927 463297 463299
Blocks: 469820 465661
  Show dependency tree
 
Reported: 2014-06-02 09:00 EDT by Maxime Porhel CLA
Modified: 2015-06-24 11:15 EDT (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2014-06-02 09:00:30 EDT
CombinedFragments and Operands can be specified in Sirius Sequence diagrams. A set of policy and layout has been created to specifically manage the layout, placement, resize, move and other user interactions on these specific constructs. 

Operands are compartments/regions of a CombinedFragment, they should be generalized into compartments/regions and available in the standard diagrams.

Several preparation steps are required to get a satisfactory result: possibility to hide labels of containers/list, improvement of container/list label types in style descriptions, DNodeContainer/DNodeList merge, ...
Comment 1 Maxime Porhel CLA 2014-06-02 09:20:23 EDT
Several experimental steps have already been done, they are present on master but speficier cannot use them without a textual modification of their VSM. 

There are two specific ContainerLayout: VerticalStack and HorizontalStack which can be used as children presentation. With one of these children presentation, a Container is considered as a RegionContainer. Its mapping must only have children ContainerMappings with a FreeForm or List children presentation. They will be considered as Region. 

A set of edit policy, layout, commands already manage these Region and RegionContainer in a basic way. See RegionContainerLayoutManager, RegionResizableEditPolicy, RegionContainerResizableEditPolicy, RegionContainerUpdateLayoutOperation, ContainerMappingExperimentalQuery, DNodeContainerExperimentalQuery)

The Sequence code has not been migrated yet.

A specifier can change a container mapping into a Region container mapping by changing childrenPresentation="FreeForm" into childrenPresentation="VerticalStack" or childrenPresentation="HorizontalStack" regarding the wanted stack direction.
Comment 2 Eclipse Genie CLA 2015-02-11 05:42:46 EST
New Gerrit change created: https://git.eclipse.org/r/41598
Comment 3 Maxime Porhel CLA 2015-03-06 09:06:20 EST
The patch referenced in Comment 2 has been merged for Bug 459635
Comment 4 Eclipse Genie CLA 2015-03-25 07:46:36 EDT
New Gerrit change created: https://git.eclipse.org/r/44580
Comment 5 Eclipse Genie CLA 2015-03-27 10:57:09 EDT
New Gerrit change created: https://git.eclipse.org/r/44748
Comment 6 Eclipse Genie CLA 2015-03-27 10:57:21 EDT
New Gerrit change created: https://git.eclipse.org/r/44749
Comment 7 Eclipse Genie CLA 2015-03-27 10:57:27 EDT
New Gerrit change created: https://git.eclipse.org/r/44754
Comment 9 Eclipse Genie CLA 2015-03-31 11:06:59 EDT
New Gerrit change created: https://git.eclipse.org/r/44918
Comment 13 Eclipse Genie CLA 2015-04-16 05:20:09 EDT
New Gerrit change created: https://git.eclipse.org/r/45914
Comment 14 Eclipse Genie CLA 2015-04-16 11:10:39 EDT
New Gerrit change created: https://git.eclipse.org/r/45943
Comment 15 Eclipse Genie CLA 2015-04-17 04:09:26 EDT
WARNING: this patchset contains 1279 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 16 Eclipse Genie CLA 2015-04-30 10:00:02 EDT
New Gerrit change created: https://git.eclipse.org/r/46886
Comment 17 Eclipse Genie CLA 2015-05-06 11:25:10 EDT
New Gerrit change created: https://git.eclipse.org/r/47326
Comment 22 Eclipse Genie CLA 2015-05-07 12:07:15 EDT
New Gerrit change created: https://git.eclipse.org/r/47459
Comment 23 Eclipse Genie CLA 2015-05-11 06:09:05 EDT
New Gerrit change created: https://git.eclipse.org/r/47614
Comment 24 Eclipse Genie CLA 2015-05-12 11:43:59 EDT
New Gerrit change created: https://git.eclipse.org/r/47749
Comment 25 Eclipse Genie CLA 2015-05-13 04:24:54 EDT
New Gerrit change created: https://git.eclipse.org/r/47780
Comment 26 Eclipse Genie CLA 2015-05-13 05:59:21 EDT
New Gerrit change created: https://git.eclipse.org/r/47803
Comment 30 Eclipse Genie CLA 2015-05-13 09:02:51 EDT
New Gerrit change created: https://git.eclipse.org/r/47836
Comment 31 Eclipse Genie CLA 2015-05-13 09:28:05 EDT
New Gerrit change created: https://git.eclipse.org/r/47838
Comment 35 Eclipse Genie CLA 2015-05-18 03:42:18 EDT
New Gerrit change created: https://git.eclipse.org/r/48051
Comment 40 Maxime Porhel CLA 2015-05-29 03:16:42 EDT
Compartiments are available in Sirius (the feature is still marked as experimental but available in the VSM editor):
 . Validation rules have been added to help the user to avoid unsupported mapping strucure (node mappings in region container, border node mappings on regions, unsupported styles, recursive regions, ..)
 . Some GMF actions might still produce unexpected behavior (make same size, make same width,)
 . Show/Hide, Hide filters have been disabled on regions (specifier can create hide filters on the region content but not on the region mapping)
 . Collapse of region has not been implemented in this ticket
 . Documentation will come in a separated commit/ticket
 . Test/validation VSM and diagram can be found in /org.eclipse.sirius.tests.junit/data/unit/compartments
Comment 41 Maxime Porhel CLA 2015-05-29 03:17:16 EDT
See previous comment
Comment 42 Eclipse Genie CLA 2015-06-02 10:41:44 EDT
New Gerrit change created: https://git.eclipse.org/r/49216
Comment 44 Pierre-Charles David CLA 2015-06-24 11:15:58 EDT
Available in Sirius 3.0.0. See https://wiki.eclipse.org/Sirius/3.0.0.