Community
Participate
Working Groups
Created attachment 252830 [details] Compartments use case We have several issues when we change a children presentation for compartments from VStack/HStack to FreeForm with opened diagram. And from FreeForm to VStack/HStack with closed diagram. The first scenario : 1- Import attached project. 2- Open both representations "new Diag with HStack" and "new Diag with VStack". 3- Open the odesign file and set the children presentation value of the both Compartment mapping (Diag with HStack -> Default -> Compartment and Diag with VStack -> Default -> Compartment) to "FreeForm" and save the odesign file. 4- KO : in the both opened presentations, children presentations are not changed as expected. The second scenario : 1- Import attached project. 2- Open the odesign file and set the children presentation value of the both Compartment mapping (Diag with HStack -> Default -> Compartment and Diag with VStack -> Default -> Compartment) to "FreeForm" and save the odesign file. 3- Open representations "new Diag with HStack" and "new Diag with VStack". 4- OK : children presentations are changed as expected. 5- Return to the odesign file editor and discard children presentation changes (double undo action) 6- KO : in opened presentations, children presentations are not changed as expected.
The figures and policies should be update when the model change from VStack/HStack to free form and vice versa. (See existing code which handles list <-> freeform)
Label styles also have to be checked.
Additional scenario: . Create a VSM with ContainerMappingImport in several optional layers to switch between presentation mode: HStack, VStack and FreeFrom (no layer with List because List accepts only node mapping as children and H/VStack accept only container as children).
Created attachment 255786 [details] Compartments use case
New Gerrit change created: https://git.eclipse.org/r/53573
Gerrit change https://git.eclipse.org/r/53573 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=1ae35b3dc73e716a426ea15e67b6c4eb64435740
Created attachment 255834 [details] Compartment use case
New Gerrit change created: https://git.eclipse.org/r/53706
New Gerrit change created: https://git.eclipse.org/r/53787
New Gerrit change created: https://git.eclipse.org/r/54010
New Gerrit change created: https://git.eclipse.org/r/54009
Gerrit change https://git.eclipse.org/r/54010 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=41103ec770492bbe54529720353c7487329227c0
Gerrit change https://git.eclipse.org/r/53706 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=c4bfa13be645b1f3154f1e4e2439216b7b9dfb51
New Gerrit change created: https://git.eclipse.org/r/55956
Gerrit change https://git.eclipse.org/r/55956 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=ceac912486b48c809b6a6b9ae68172e6a5cc104b
Corrected on master for Sirius 3.1.0 ContainerMappingImportWithChildrenPresentationChangesTests test the children presentation changes through layers with container mapping imports: changing activated layers changes the children presentation. The tests check that the expected changes occurs without throwing errors in the Sirius model, the edit parts structure, the installed edit policies, the figures and borders (FreeForm -> VStack -> List -> HStack).
Validated with Sirius 3.1.0.201509241504
Available in Sirius 3.1.0.
