Bug 474677 - Line style menus and buttons in appearance property section are always disabled
Summary: Line style menus and buttons in appearance property section are always disabled
Status: NEW
Alias: None
Product: Sirius
Classification: Modeling
Component: Diagram (show other bugs)
Version: 3.0.0   Edit
Hardware: PC Mac OS X
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on: 461590
Blocks:
  Show dependency tree
 
Reported: 2015-08-11 04:23 EDT by Maxime Porhel CLA
Modified: 2015-08-21 03:17 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Porhel CLA 2015-08-11 04:23:26 EDT 
Discovered during Bug 461590 which add the line type capability to node and container borders. 

Step to reproduce: 
 . open a diagram (seeBug 461580 which provide a use case with all tests)
 . select iteratively each node/container/edge
 . in the apperance property tab, the button from "Lines and Arrows" group are always disabled


Some entry point for the analyse
 . ViewPropertiesSynchronizer
 . *ViewFactory
 . there is no LineStypeStyle on our GMF views: org.eclipse.gmf.runtime.diagram.ui.properties.sections.appearance.ColoursAndFontsAndLineStylesPropertySection.refresh() will never enable the buttons

We could at least enable the line type button, maybe the line width combo but not the arrow one for nodes/container; 

The other solution is to hide this group as some of these elements can be customized from the "Style" tab.
Comment 1 Maxime Porhel CLA 2015-08-20 11:13:54 EDT 
This comes mainly from the fact that there is no notation LineStyle on our edges and nodes views. 

We have to solutions here: 
 . Add the line style (and the arrow, width and other styles corresponding to non working menus)
 . Remove the default menu and buttons and replace them by Sirius specific ones able to handle our style elements (bonus: no need to maintain/synchronize/revert the notation changes)
Comment 2 Maxime Porhel CLA 2015-08-20 11:15:29 EDT 
Additional step in the reproduction case: right click > Format > Line style > grayed menus.