Bug 460039 - [Perspectives] Reset perspective does not reset File > Save tool item
Summary: [Perspectives] Reset perspective does not reset File > Save tool item
Status: CLOSED DUPLICATE of bug 395601
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Andrey Loskutov CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 420956
  Show dependency tree
 
Reported: 2015-02-16 11:43 EST by Noopur Gupta CLA
Modified: 2015-02-16 13:48 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2015-02-16 11:43:59 EST 
- Go to CPD and uncheck File > Save.
- Invoke Reset Perspective...
- "File > Save" does not come back though it is checked in CPD.

This does not work even with the code at commit:
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1d3294204c71b0cd1e7e2e831feb2faf6133ec38

However, taking the code up to its parent commit and adding the reset perspective fix "legacyWindow.updateActionSets();" to WorkbenchPage.resetPerspective() makes the issue disappear.

Hence, looks like some other change from the above mentioned commit is causing this.
Comment 1 Andrey Loskutov CLA 2015-02-16 12:17:08 EST 
Noopur, can you try if this review fixes this issue too: https://git.eclipse.org/r/#/c/41378/
Comment 2 Andrey Loskutov CLA 2015-02-16 13:48:12 EST 
(In reply to Andrey Loskutov from comment #1)
> Noopur, can you try if this review fixes this issue too:
> https://git.eclipse.org/r/#/c/41378/

Yes, it also fixes this issue.

*** This bug has been marked as a duplicate of bug 395601 ***