Bug 441165 - Import maven projects into nested working sets
Summary: Import maven projects into nested working sets
Status: CLOSED WONTFIX
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: m2e (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 245412 427768 441169
Blocks:
  Show dependency tree
 
Reported: 2014-08-05 06:55 EDT by Ivica Loncar CLA
Modified: 2021-04-19 13:22 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ivica Loncar CLA 2014-08-05 06:55:22 EDT
Accordingly to http://help.eclipse.org/luna/topic/org.eclipse.platform.doc.isv/reference/api/org/eclipse/ui/IAggregateWorkingSet.html
since 3.5 eclipse it's possible to have working sets inside working sets

It would be nice if we coud import nested maven projects into "nested working sets". Instead of one big ball of projects in one working set we could mimic structure of the project.
Comment 1 Igor Fedorenko CLA 2014-08-05 07:21:15 EDT
This is not an enhancement, this is yet another workaround for the lack of nested project support. I do not plan to work on this myself and unlikely to review/accept a patch either. Other m2e committers are free to work on this, however.
Comment 2 Ivica Loncar CLA 2014-08-05 08:21:36 EDT
I have seen the code and I understand you. 

I have created request for JDT support: bug 441169.
If JDT fixes it then maybe it could be reused. I guess this is not going to happen soon. Sigh.
Comment 3 Igor Fedorenko CLA 2014-08-05 08:31:34 EDT
I meant proper nested project support, which needs jdt bug 356450.

I honestly don't believe nested working set will improve overall usability all to much, it will likely just add to UI clutter.
Comment 4 Mickael Istria CLA 2014-08-05 09:47:08 EDT
Using working sets to show nested projects is IMO a bad idea. Note that the aggregated working set is not a composite working set, and is not rendered as multiple levels of working set in UI, so the API you suggest is not enough.
IMO, Working Set are often used as a workaround to lack of nested projects.

As Igor explained, supporting nested projects are not specific to m2e and should be addressed in Platform directly, so various plugins could reuse the same mechanism to show nested projects.

In bug #427768, you can find a link to a GitHub repo that enables nested view of projects (this is just a some UI, no structural change). I'm often using it for my Maven projects: I include the top-level directory as a plain project, and then I open children projects directly in the tree to show them nested.
I suggest you give it a try and provide feedback either via GitHub issues/PRs, or as comment on bug #422768

You could also think of contributing to bug #424317 which has a similar goal of improving navigation from modules to submodules in m2e projects.
Comment 5 Ivica Loncar CLA 2014-08-13 11:08:55 EDT
Ok, Mickael you have a first PR :)
Comment 6 Fred Bricon CLA 2017-12-12 14:45:04 EST
Closing as won't fix, since Eclipse now supports a nested view.
Comment 7 Denis Roy CLA 2021-04-19 13:22:56 EDT
Moved to https://github.com/eclipse-m2e/m2e-core/issues/