Community
Participate
Working Groups
Test case: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet025TabEditing.java The editing works correctly with GTK2. GTK3 <= 3.8 - it works, but a context menu doesn't work. Right-click in an editing field, leave edit mode and actions (Cut, Copy, Paste ...) don't work. GTK3 >= 3.10 - you can't enter editing mode. See https://issues.jboss.org/browse/JBIDE-17075
*** Bug 461041 has been marked as a duplicate of this bug. ***
If so, raise the importance to critical
*** Bug 458630 has been marked as a duplicate of this bug. ***
New Gerrit change created: https://git.eclipse.org/r/47652
The issue is caused by a change in the way GTK 3.10 sends the draw signal. The patch https://git.eclipse.org/r/47652 fixes the issue so that it uses fixedHandle (SwtFixed) instead of handle (GtkTreeView) when painting children of a table/tree. I have tested the following: - http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet025TabEditing.java - http://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/examples/org.eclipse.swt.snippets/src/org/eclipse/swt/snippets/Snippet88.java - http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet019TableViewerAddRemoveColumnsWithEditingNewAPI.java - the Arquillian XML editor (the issue described in https://issues.jboss.org/browse/JBIDE-17075) - the issue described in bug 458630 - http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet026TreeViewerTabEditing.java The last two tests are related to the tree editing.
*** Bug 436324 has been marked as a duplicate of this bug. ***
*** Bug 460581 has been marked as a duplicate of this bug. ***
Patch is good by me. Thanks for it Snjezana.
Gerrit change https://git.eclipse.org/r/47652 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d2af9778a61685fac23a2f74ff7d7c90b2c69ed4
Pushed to master.
Created attachment 253463 [details] Screenshot of Trace Compass This doesn't fully fix bug 436324 (Trace Compass) and bug 460581 (Papyrus). Now there seems to be a problem with the position of the selected item. In Trace Compass, if click on a row, it selects the one below. That wasn't the case before this fix. In Papyrus, it is similar except that some rows are editable, I have to select the row above to edit.
Created attachment 253464 [details] Screenshot of Papyrus
Please REOPEN this bug then, until it is properly solved. /Toni
New Gerrit change created: https://git.eclipse.org/r/47920
The patch https://git.eclipse.org/r/47920 fixes the issue in bug 460581 (Papyrus). I suppose it also fixes the issue in bug 436324.
(In reply to Snjezana Peco from comment #15) > The patch https://git.eclipse.org/r/47920 fixes the issue in bug 460581 > (Papyrus). > I suppose it also fixes the issue in bug 436324. I can confirm that it fixes the issue for Trace Compass (bug 436324) thank you!
Alex, will you be reviewing the new patch from Snjezana? RC2 needs two committer reviews, so I can also do a quick review.
(In reply to Arun Thondapu from comment #17) > Alex, will you be reviewing the new patch from Snjezana? > RC2 needs two committer reviews, so I can also do a quick review. On it now.
Patch is good by me. Approved in gerrit but not pushed. My review+ from previous patch still applies. Arun, please do your review and push if fine.
(In reply to Alexander Kurtakov from comment #19) > Patch is good by me. Approved in gerrit but not pushed. My review+ from > previous patch still applies. > Arun, please do your review and push if fine. Looks good to me as well. Did some testing on Ubuntu 14.04 (GTK 3.10.8) and the patch mostly works except for one scenario. Using test case from comment 0, the context menu actions via right mouse click still do not seem to work for me. Cut, copy, paste via keyboard shortcuts are working though. Snjezana, is the context menu problem expected to be fixed with this patch?
(In reply to Arun Thondapu from comment #20) > > Snjezana, is the context menu problem expected to be fixed with this patch? I haven't tested the context menu problem. I propose that we create a new bug related to it.
Gerrit change https://git.eclipse.org/r/47920 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=28ac128ec47e5a30f68629d0b81dac5ba61e2eb4
(In reply to Snjezana Peco from comment #21) > (In reply to Arun Thondapu from comment #20) > > > > Snjezana, is the context menu problem expected to be fixed with this patch? > > I haven't tested the context menu problem. I propose that we create a new > bug related to it. Sounds good, I've pushed the new patch, thanks Snjezana!
*** Bug 467977 has been marked as a duplicate of this bug. ***
This fixed the getBounds(int) method but not getBounds(), see bug 486302.
Table/tree editing doesn't work properly on GTK 3.18.9 + SWT 3.107.0 Seems the changes in 511133 cause the issue again The test case fails on GTK 3.18.9: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/tree/examples/org.eclipse.jface.snippets/Eclipse%20JFace%20Snippets/org/eclipse/jface/snippets/viewers/Snippet025TabEditing.java
Table/tree editing doesn't work properly on GTK 3.18.9 + SWT 3.107.0 See comment above.
(In reply to Ulyana Skorokhodova from comment #29) > Table/tree editing doesn't work properly on GTK 3.18.9 + SWT 3.107.0 > See comment above. Please open a new bug report.
I saw the same issue in Eclipse 2018-12 with GTK3.18. Upgrading to GTK3.20.8 solved my problems.
(In reply to Oscar Asterkrans from comment #31) > I saw the same issue in Eclipse 2018-12 with GTK3.18. Upgrading to GTK3.20.8 > solved my problems. See comment 30.
